| Age | Commit message (Collapse) | Author |
|---|
|
|
|
shader: Implement S2R Tid{XYZ} and CtaId{XYZ}
|
|
The intention behind this commit is to hint someone inspecting an
apitrace dump to ignore this ill-formed GLSL code.
|
|
This addresses a bug on geometry shaders where code was being written
before all #extension declarations were done. Ref to #2523
|
|
Uses a std::string_view instead of a std::string, given the pointed to
string isn't modified and is only used in a formatting operation.
This is nice because a few usages directly supply a string literal to
the function, allowing these usages to otherwise not heap allocate,
unlike the std::string overloads.
While we're at it, we can combine the address formatting into a single
formatting call.
|
|
gl_shader_cache: Use shared contexts to build shaders in parallel at boot
|
|
The following code is broken on AMD's proprietary GLSL compiler:
```glsl
uint idx = ...;
vec4 values = ...;
float some_value = values[idx & 3];
```
It index the wrong components, to fix this the following pessimized code
is emitted when that bug is present:
```glsl
uint idx = ...;
vec4 values = ...;
float some_value;
if ((idx & 3) == 0) some_value = values.x;
if ((idx & 3) == 1) some_value = values.y;
if ((idx & 3) == 2) some_value = values.z;
if ((idx & 3) == 3) some_value = values.w;
```
|
|
Component indexing on AMD's proprietary driver is broken. This commit adds
a test to detect when we are on a driver that can't successfully manage
component indexing.
It dispatches a dummy draw with just one vertex shader that writes to an
indexed SSBO from the GPU with data sent through uniforms, it then reads
that data from the CPU and compares the expected output.
|
|
format string
This accidentally slipped through a rebase.
|
|
|
|
|
|
|
|
|
|
std::string concatenation
|
|
Gets rid of the need to special-case brace handling depending on the
overload used, and makes it consistent across the board with how fmt
handles them.
Strings with compile-time deducible strings are directly forwarded to
std::string's constructor, so we don't need to worry about the
performance difference here, as it'll be identical.
|
|
|
|
In a lot of places throughout the decompiler, string concatenation via
operator+ is used quite heavily. This is usually fine, when not heavily
used, but when used extensively, can be a problem. operator+ creates an
entirely new heap allocated temporary string and given we perform
expressions like:
std::string thing = a + b + c + d;
this ends up with a lot of unnecessary temporary strings being created
and discarded, which kind of thrashes the heap more than we need to.
Given we utilize fmt in some AddLine calls, we can make this a part of
the ShaderWriter's API. We can make an overload that simply acts as a
passthrough to fmt.
This way, whenever things need to be appended to a string, the operation
can be done via a single string formatting operation instead of
discarding numerous temporary strings. This also has the benefit of
making the strings themselves look nicer and makes it easier to spot
errors in them.
|
|
shader: Implement AL2P and ALD.PHYS
|
|
gl_shader_disk_cache: Minor cleanup
|
|
gl_rasterizer: Pass the right number of array quad vertices count
|
|
gl_rasterizer: Limit OpenGL point size to a minimum of 1
|
|
maxwell_to_gl: Add TriangleFan primitive topology
|
|
Avoids performing copies into the pair being returned. Instead, we can
just move the resources into the pair, avoiding the need to make copies
of both the std::string and ShaderEntries struct.
|
|
ShaderDiskCacheOpenGL
Given the offset is assigned a fixed value in the constructor, we can
just assign it directly and get rid of the need to write the name of the
variable again in the constructor initializer list.
|
|
Given the disk shader cache contains non-trivial types, we should
default it in the cpp file in order to prevent inlining of the
complex destruction logic.
|
|
The standard library expects hash specializations that don't throw
exceptions. Make this explicit in the type to allow selection of better
code paths if possible in implementations.
|
|
LoadDecompiledEntry()
We don't need to load the code into a vector and then construct a string
over the data. We can just create a string with the necessary size ahead
of time, and read the data directly into it, getting rid of an
unnecessary heap allocation.
|
|
std::move does nothing when applied to a const variable. Resources can't
be moved if the object is immutable. With this change, we don't end up
making several unnecessary heap allocations and copies.
|
|
Booleans don't have a guaranteed size, but we still want to have them
integrate into the disk cache system without needing to actually use a
different type. We can do this by supplying non-template overloads for
the bool type.
Non-template overloads always have precedence during function
resolution, so this is safe to provide.
This gets rid of the need to smatter ternary conditionals, as well as
the need to use u8 types to store the value in.
|
|
|
|
|
|
|
|
video_core: Remove a few unused variables and functions
|
|
Rasterizer Cache: refactor flushing & optimize memory usage of surfaces
|
|
Silences a -Wreorder warning.
|
|
function
This isn't used at all, so it can be removed.
|
|
UploadGLMipmapTexture()
This variable is unused entirely, so it can be removed.
|
|
gl_shader_disk_cache: Skip stored shader variants instead of asserting
|
|
Makes use of src, so it's not considered unused.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Instead of asserting on already stored shader variants, silently skip them.
This shouldn't be happening but when a shader is invalidated and it is
not stored in the shader cache, this assert would hit and save that
shader anyways when the asserts are disabled.
|
|
gl_shader_disk_cache: Improve precompiled shader cache generation speed and size
|
|
video_core: Silent -Wswitch warnings
|
|
|
|
|
