diff options
| author | Lioncash <mathew1800@gmail.com> | 2019-05-24 23:32:01 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2019-05-24 23:50:10 -0400 |
| commit | 5a4564bd8eae9c8fef6da70009536ce50b5752d5 (patch) | |
| tree | e2c03d0a39175e2310d9a2289b7cf9274a8fa95a /src/video_core/renderer_opengl/utils.h | |
| parent | e86d2e2e5bb1929b4c5f3f5f43e510f262bd8875 (diff) | |
renderer_opengl/utils: Use a std::string_view with LabelGLObject()
Uses a std::string_view instead of a std::string, given the pointed to
string isn't modified and is only used in a formatting operation.
This is nice because a few usages directly supply a string literal to
the function, allowing these usages to otherwise not heap allocate,
unlike the std::string overloads.
While we're at it, we can combine the address formatting into a single
formatting call.
Diffstat (limited to 'src/video_core/renderer_opengl/utils.h')
| -rw-r--r-- | src/video_core/renderer_opengl/utils.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/video_core/renderer_opengl/utils.h b/src/video_core/renderer_opengl/utils.h index aef45c9dc..b3e9fc499 100644 --- a/src/video_core/renderer_opengl/utils.h +++ b/src/video_core/renderer_opengl/utils.h @@ -4,7 +4,7 @@ #pragma once -#include <string> +#include <string_view> #include <vector> #include <glad/glad.h> #include "common/common_types.h" @@ -30,6 +30,6 @@ private: std::vector<GLsizeiptr> sizes; }; -void LabelGLObject(GLenum identifier, GLuint handle, VAddr addr, std::string extra_info = ""); +void LabelGLObject(GLenum identifier, GLuint handle, VAddr addr, std::string_view extra_info = {}); } // namespace OpenGL
\ No newline at end of file |