From 5a4564bd8eae9c8fef6da70009536ce50b5752d5 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Fri, 24 May 2019 23:32:01 -0400 Subject: renderer_opengl/utils: Use a std::string_view with LabelGLObject() Uses a std::string_view instead of a std::string, given the pointed to string isn't modified and is only used in a formatting operation. This is nice because a few usages directly supply a string literal to the function, allowing these usages to otherwise not heap allocate, unlike the std::string overloads. While we're at it, we can combine the address formatting into a single formatting call. --- src/video_core/renderer_opengl/utils.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/video_core/renderer_opengl/utils.h') diff --git a/src/video_core/renderer_opengl/utils.h b/src/video_core/renderer_opengl/utils.h index aef45c9dc..b3e9fc499 100644 --- a/src/video_core/renderer_opengl/utils.h +++ b/src/video_core/renderer_opengl/utils.h @@ -4,7 +4,7 @@ #pragma once -#include +#include #include #include #include "common/common_types.h" @@ -30,6 +30,6 @@ private: std::vector sizes; }; -void LabelGLObject(GLenum identifier, GLuint handle, VAddr addr, std::string extra_info = ""); +void LabelGLObject(GLenum identifier, GLuint handle, VAddr addr, std::string_view extra_info = {}); } // namespace OpenGL \ No newline at end of file -- cgit v1.2.3