aboutsummaryrefslogtreecommitdiff
path: root/Ryujinx.Graphics/Shader/Translation/Optimizations
diff options
context:
space:
mode:
authorAlex Barney <thealexbarney@gmail.com>2019-07-01 21:39:22 -0500
committerAc_K <Acoustik666@gmail.com>2019-07-02 04:39:22 +0200
commitb2b736abc2569ab5d8199da666aef8d8394844a0 (patch)
tree88bcc2ae4fb0d4161c95df2cd7edb12388de922a /Ryujinx.Graphics/Shader/Translation/Optimizations
parent10c74182babaf8cf6bedaeffd64c3109df4ea816 (diff)
Misc cleanup (#708)
* Fix typos * Remove unneeded using statements * Enforce var style more * Remove redundant qualifiers * Fix some indentation * Disable naming warnings on files with external enum names * Fix build * Mass find & replace for comments with no spacing * Standardize todo capitalization and for/if spacing
Diffstat (limited to 'Ryujinx.Graphics/Shader/Translation/Optimizations')
-rw-r--r--Ryujinx.Graphics/Shader/Translation/Optimizations/BranchElimination.cs14
-rw-r--r--Ryujinx.Graphics/Shader/Translation/Optimizations/HalfConversion.cs4
-rw-r--r--Ryujinx.Graphics/Shader/Translation/Optimizations/Optimizer.cs12
-rw-r--r--Ryujinx.Graphics/Shader/Translation/Optimizations/Simplification.cs22
4 files changed, 26 insertions, 26 deletions
diff --git a/Ryujinx.Graphics/Shader/Translation/Optimizations/BranchElimination.cs b/Ryujinx.Graphics/Shader/Translation/Optimizations/BranchElimination.cs
index 2b0f1905..070f07a4 100644
--- a/Ryujinx.Graphics/Shader/Translation/Optimizations/BranchElimination.cs
+++ b/Ryujinx.Graphics/Shader/Translation/Optimizations/BranchElimination.cs
@@ -19,13 +19,13 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
private static bool IsRedundantBranch(Operation current, BasicBlock nextBlock)
{
- //Here we check that:
- //- The current block ends with a branch.
- //- The next block only contains a branch.
- //- The branch on the next block is unconditional.
- //- Both branches are jumping to the same location.
- //In this case, the branch on the current block can be removed,
- //as the next block is going to jump to the same place anyway.
+ // Here we check that:
+ // - The current block ends with a branch.
+ // - The next block only contains a branch.
+ // - The branch on the next block is unconditional.
+ // - Both branches are jumping to the same location.
+ // In this case, the branch on the current block can be removed,
+ // as the next block is going to jump to the same place anyway.
if (nextBlock == null)
{
return false;
diff --git a/Ryujinx.Graphics/Shader/Translation/Optimizations/HalfConversion.cs b/Ryujinx.Graphics/Shader/Translation/Optimizations/HalfConversion.cs
index 9ef35abc..96060272 100644
--- a/Ryujinx.Graphics/Shader/Translation/Optimizations/HalfConversion.cs
+++ b/Ryujinx.Graphics/Shader/Translation/Optimizations/HalfConversion.cs
@@ -12,7 +12,7 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
if (exponent == 0x1f)
{
- //NaN or Infinity.
+ // NaN or Infinity.
mantissa <<= 13;
exponent = 0xff;
}
@@ -20,7 +20,7 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
{
if (exponent == 0)
{
- //Denormal.
+ // Denormal.
int e = -1;
int m = mantissa;
diff --git a/Ryujinx.Graphics/Shader/Translation/Optimizations/Optimizer.cs b/Ryujinx.Graphics/Shader/Translation/Optimizations/Optimizer.cs
index 88118e3a..8cce0e74 100644
--- a/Ryujinx.Graphics/Shader/Translation/Optimizations/Optimizer.cs
+++ b/Ryujinx.Graphics/Shader/Translation/Optimizations/Optimizer.cs
@@ -81,8 +81,8 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
private static void PropagateCopy(Operation copyOp)
{
- //Propagate copy source operand to all uses of
- //the destination operand.
+ // Propagate copy source operand to all uses of
+ // the destination operand.
Operand dest = copyOp.Dest;
Operand src = copyOp.GetSource(0);
@@ -102,8 +102,8 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
private static bool PropagatePack(Operation packOp)
{
- //Propagate pack source operands to uses by unpack
- //instruction. The source depends on the unpack instruction.
+ // Propagate pack source operands to uses by unpack
+ // instruction. The source depends on the unpack instruction.
bool modified = false;
Operand dest = packOp.Dest;
@@ -132,8 +132,8 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
private static void RemoveNode(BasicBlock block, LinkedListNode<INode> llNode)
{
- //Remove a node from the nodes list, and also remove itself
- //from all the use lists on the operands that this node uses.
+ // Remove a node from the nodes list, and also remove itself
+ // from all the use lists on the operands that this node uses.
block.Operations.Remove(llNode);
Queue<INode> nodes = new Queue<INode>();
diff --git a/Ryujinx.Graphics/Shader/Translation/Optimizations/Simplification.cs b/Ryujinx.Graphics/Shader/Translation/Optimizations/Simplification.cs
index 56b1543f..d6366dfe 100644
--- a/Ryujinx.Graphics/Shader/Translation/Optimizations/Simplification.cs
+++ b/Ryujinx.Graphics/Shader/Translation/Optimizations/Simplification.cs
@@ -14,7 +14,7 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
{
case Instruction.Add:
case Instruction.BitwiseExclusiveOr:
- TryEliminateBinaryOpComutative(operation, 0);
+ TryEliminateBinaryOpCommutative(operation, 0);
break;
case Instruction.BitwiseAnd:
@@ -34,7 +34,7 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
break;
case Instruction.Multiply:
- TryEliminateBinaryOpComutative(operation, 1);
+ TryEliminateBinaryOpCommutative(operation, 1);
break;
case Instruction.ShiftLeft:
@@ -48,9 +48,9 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
private static void TryEliminateBitwiseAnd(Operation operation)
{
- //Try to recognize and optimize those 3 patterns (in order):
- //x & 0xFFFFFFFF == x, 0xFFFFFFFF & y == y,
- //x & 0x00000000 == 0x00000000, 0x00000000 & y == 0x00000000
+ // Try to recognize and optimize those 3 patterns (in order):
+ // x & 0xFFFFFFFF == x, 0xFFFFFFFF & y == y,
+ // x & 0x00000000 == 0x00000000, 0x00000000 & y == 0x00000000
Operand x = operation.GetSource(0);
Operand y = operation.GetSource(1);
@@ -70,9 +70,9 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
private static void TryEliminateBitwiseOr(Operation operation)
{
- //Try to recognize and optimize those 3 patterns (in order):
- //x | 0x00000000 == x, 0x00000000 | y == y,
- //x | 0xFFFFFFFF == 0xFFFFFFFF, 0xFFFFFFFF | y == 0xFFFFFFFF
+ // Try to recognize and optimize those 3 patterns (in order):
+ // x | 0x00000000 == x, 0x00000000 | y == y,
+ // x | 0xFFFFFFFF == 0xFFFFFFFF, 0xFFFFFFFF | y == 0xFFFFFFFF
Operand x = operation.GetSource(0);
Operand y = operation.GetSource(1);
@@ -101,7 +101,7 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
}
}
- private static void TryEliminateBinaryOpComutative(Operation operation, int comparand)
+ private static void TryEliminateBinaryOpCommutative(Operation operation, int comparand)
{
Operand x = operation.GetSource(0);
Operand y = operation.GetSource(1);
@@ -125,8 +125,8 @@ namespace Ryujinx.Graphics.Shader.Translation.Optimizations
return;
}
- //The condition is constant, we can turn it into a copy, and select
- //the source based on the condition value.
+ // The condition is constant, we can turn it into a copy, and select
+ // the source based on the condition value.
int srcIndex = cond.Value != 0 ? 1 : 2;
Operand source = operation.GetSource(srcIndex);