aboutsummaryrefslogtreecommitdiff
path: root/src/video_core/command_classes
AgeCommit message (Collapse)Author
2021-02-13video_core: Reimplement the buffer cacheReinUsesLisp
Reimplement the buffer cache using cached bindings and page level granularity for modification tracking. This also drops the usage of shared pointers and virtual functions from the cache. - Bindings are cached, allowing to skip work when the game changes few bits between draws. - OpenGL Assembly shaders no longer copy when a region has been modified from the GPU to emulate constant buffers, instead GL_EXT_memory_object is used to alias sub-buffers within the same allocation. - OpenGL Assembly shaders stream constant buffer data using glProgramBufferParametersIuivNV, from NV_parameter_buffer_object. In theory this should save one hash table resolve inside the driver compared to glBufferSubData. - A new OpenGL stream buffer is implemented based on fences for drivers that are not Nvidia's proprietary, due to their low performance on partial glBufferSubData calls synchronized with 3D rendering (that some games use a lot). - Most optimizations are shared between APIs now, allowing Vulkan to cache more bindings than before, skipping unnecesarry work. This commit adds the necessary infrastructure to use Vulkan object from OpenGL. Overall, it improves performance and fixes some bugs present on the old cache. There are still some edge cases hit by some games that harm performance on some vendors, this are planned to be fixed in later commits.
2021-01-15common/bit_util: Replace CLZ/CTZ operations with standardized onesLioncash
Makes for less code that we need to maintain.
2021-01-07remove inaccurate referenceAmeer J
Co-authored-by: LC <mathew1800@gmail.com>
2021-01-07fix for nvdec disabled, cleanup host1xameerj
2021-01-07nvdec syncpt incorporationameerj
laying the groundwork for async gpu, although this does not fully implement async nvdec operations
2021-01-02general: Fix various spelling errorsMorph
2020-12-30video_core: Rewrite the texture cacheReinUsesLisp
The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage.The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage. This commit aims to address those issues.
2020-12-07video_core: Remove unnecessary enum class casting in logging messagesLioncash
fmt now automatically prints the numeric value of an enum class member by default, so we don't need to use casts any more. Reduces the line noise a bit.
2020-12-05video_core: Resolve more variable shadowing scenarios pt.2Lioncash
Migrates the video core code closer to enabling variable shadowing warnings as errors. This primarily sorts out shadowing occurrences within the Vulkan code.
2020-12-05Merge pull request #5124 from lioncash/video-shadowbunnei
video_core: Resolve more variable shadowing scenarios
2020-12-04codec: Remove deprecated usage of AVCodecContext::refcounted_framesLioncash
This was only necessary for use with the avcodec_decode_video2/avcoded_decode_audio4 APIs which are also deprecated. Given we use avcodec_send_packet/avcodec_receive_frame, this isn't necessary, this is even indicated directly within the FFmpeg API changes document here on 2017-09-26: https://github.com/FFmpeg/FFmpeg/blob/master/doc/APIchanges#L410 This prevents our code from breaking whenever we update to a newer version of FFmpeg in the future if they ever decide to fully remove this API member.
2020-12-04video_core: Resolve more variable shadowing scenariosLioncash
Resolves variable shadowing scenarios up to the end of the OpenGL code to make it nicer to review. The rest will be resolved in a following commit.
2020-12-03vp9/vic: Resolve pessimizing movesLioncash
Removes the usage of moves that don't result in behavior different from a copy, or otherwise would prevent copy elision from occurring.
2020-12-02Merge pull request #5002 from ameerj/nvdec-frameskipbunnei
nvdec: Queue and display all decoded frames, cleanup decoders
2020-11-26codec: Fix `pragma GCC diagnostic pop` missing corresponding pushcomex
2020-11-26Limit queue size to 10 framesameerj
Workaround for ZLA, which seems to decode and queue twice as many frames as it displays.
2020-11-26Address PR feedbackameerj
remove some redundant moves, make deleter match naming guidelines. Co-Authored-By: LC <712067+lioncash@users.noreply.github.com>
2020-11-25Queue decoded frames, cleanup decodersameerj
2020-11-02nvdec: Make use of [[nodiscard]] where applicableLioncash
Prevents bugs from occurring where the results of a function are accidentally discarded
2020-10-29vp9: Be explicit with copy and move operatorsLioncash
It's deprecated in the language to autogenerate these if the destructor for a type is specified, so we can explicitly specify how we want these to be generated.
2020-10-29vp9: Mark functions with [[nodiscard]] where applicableLioncash
Prevents values from mistakenly being discarded in cases where it's a bug to do so.
2020-10-29vp9: Provide a default initializer for "hidden" memberLioncash
The API of VP9 exposes a WasFrameHidden() function which accesses this member. Given the constructor previously didn't initialize this member, it's a potential vector for an uninitialized read. Instead, we can initialize this to a deterministic value to prevent that from occurring.
2020-10-29vp9: Make some member functions internally linkedLioncash
These helper functions don't directly modify any member state and can be hidden from view.
2020-10-29Merge pull request #4837 from lioncash/nvdec-2bunnei
nvdec: Minor tidying up
2020-10-28Merge pull request #4838 from lioncash/syncmgrbunnei
sync_manager: Amend parameter order of calls to SyncptIncr constructor
2020-10-28Merge pull request #4848 from ReinUsesLisp/type-limitsLC
video_core: Enforce -Werror=type-limits
2020-10-28video_core: Enforce -Wredundant-move and -Wpessimizing-moveReinUsesLisp
Silence three warnings and make them errors to avoid introducing more in the future.
2020-10-28video_core: Enforce -Werror=type-limitsReinUsesLisp
Silences one warning and avoids introducing more in the future.
2020-10-27sync_manager: Amend parameter order of calls to SyncptIncr constructorLioncash
Corrects some cases where the arguments would be incorrectly swapped.
2020-10-27h264: Make WriteUe take a u32Lioncash
Enforces the type of the desired value in calling code.
2020-10-27vp9: std::move buffer within ComposeFrameHeader()Lioncash
We can move the buffer here to avoid a heap reallocation
2020-10-27vp9: Remove dead codeLioncash
2020-10-27vp9: Join declarations with assignmentsLioncash
2020-10-27vp9: Remove pessimizing movesLioncash
The move will already occur without std::move.
2020-10-27vp9: Resolve variable shadowingLioncash
2020-10-27nvdec: Tidy up header includesLioncash
Prevents a few unnecessary inclusions.
2020-10-26video_core: NVDEC Implementationameerj
This commit aims to implement the NVDEC (Nvidia Decoder) functionality, with video frame decoding being handled by the FFmpeg library. The process begins with Ioctl commands being sent to the NVDEC and VIC (Video Image Composer) emulated devices. These allocate the necessary GPU buffers for the frame data, along with providing information on the incoming video data. A Submit command then signals the GPU to process and decode the frame data. To decode the frame, the respective codec's header must be manually composed from the information provided by NVDEC, then sent with the raw frame data to the ffmpeg library. Currently, H264 and VP9 are supported, with VP9 having some minor artifacting issues related mainly to the reference frame composition in its uncompressed header. Async GPU is not properly implemented at the moment. Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>