| Age | Commit message (Collapse) | Author |
|---|
|
|
|
bcat: Fix settings access
telemetry_session: Fix settings accesses
So this is what I get for testing with the web service disabled.
touch_from_button: Fix settings access for clang
|
|
Transition to PascalCase for result names.
|
|
|
|
|
|
|
|
Resolves a few localized instances of member variable shadowing. Brings
us a little closer to turning shadowing warnings into errors.
|
|
- Removes a dependency on core and input_common from common.
|
|
|
|
|
|
|
|
Completely removes all usages of the global system instance within the
services code by passing in the using system instance to the services.
|
|
Resolves numerous deprecation warnings throughout the codebase due to
inclusion of this header. Now building core should be significantly less
noisy (and also relying on less global state).
This also uncovered quite a few modules that were relying on indirect
includes, which have also been fixed.
|
|
|
|
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.
Fixes #4795
|
|
WriteBuffer (#4465)
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer
With the support of C++20, we can use concepts to deduce if a type is an STL container or not.
* More agressive concept for stl containers
* Add -fconcepts
* Move to common namespace
* Add Common::IsBaseOf
|
|
* bcat: Update function tables and add missing classes
|
|
Keeps the service function tables up to date.
Updated based off information on SwitchBrew.
|
|
service: Update function tables
|
|
kernel objects. (#3154)
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects.
- See https://github.com/citra-emu/citra/pull/4710 for details.
|
|
Keeps the function tables up to date.
Updated based off information from Switchbrew.
|
|
These functions are marked for deprecation and it's recommended that the
*_ret variants be used instead.
|
|
Removes all uses of the global system accessor within the BCAT
interface.
|
|
core: Remove Core::CurrentProcess()
|
|
We need to perform explicit casts here, otherwise we're implicitly
truncating a 64-bit type to a 32-bit one.
|
|
Migrates the HLE service code off the use of directly accessing the
global system instance where trivially able to do so.
This removes all usages of Core::CurrentProcess from the service code,
only 8 occurrences of this function exist elsewhere. There's still quite
a bit of "System::GetInstance()" being used, however this was able to
replace a few instances.
|
|
|
|
Ports BCAT to use FSC interface
|
|
|
|
Huge thanks to lioncash for re-ing this for me.
|
|
|
|
Takes a title ID and simply deletes all the data for that title ID's bcat. Invokes the respective backend command.
|
|
Takes a title ID and passphrase (0x40 byte string) and passes it to the backend.
|
|
Variant also supports only updating a single directory. These just both invoke backend commands.
|
|
Used to query completion status and events for the current delivery task.
|
|
Used to read the contents of files and access their metadata.
|
|
Used to list and get directories at the root level.
|
|
Used to create subclasses to manage files and directories and to list directories.
|
|
Used to access contents of download.
|
|
|
|
services should now log on some level
|
|
applicable
When a destructor isn't defaulted into a cpp file, it can cause the use
of forward declarations to seemingly fail to compile for non-obvious
reasons. It also allows inlining of the construction/destruction logic
all over the place where a constructor or destructor is invoked, which
can lead to code bloat. This isn't so much a worry here, given the
services won't be created and destroyed frequently.
The cause of the above mentioned non-obvious errors can be demonstrated
as follows:
------- Demonstrative example, if you know how the described error happens, skip forwards -------
Assume we have the following in the header, which we'll call "thing.h":
\#include <memory>
// Forward declaration. For example purposes, assume the definition
// of Object is in some header named "object.h"
class Object;
class Thing {
public:
// assume no constructors or destructors are specified here,
// or the constructors/destructors are defined as:
//
// Thing() = default;
// ~Thing() = default;
//
// ... Some interface member functions would be defined here
private:
std::shared_ptr<Object> obj;
};
If this header is included in a cpp file, (which we'll call "main.cpp"),
this will result in a compilation error, because even though no
destructor is specified, the destructor will still need to be generated by
the compiler because std::shared_ptr's destructor is *not* trivial (in
other words, it does something other than nothing), as std::shared_ptr's
destructor needs to do two things:
1. Decrement the shared reference count of the object being pointed to,
and if the reference count decrements to zero,
2. Free the Object instance's memory (aka deallocate the memory it's
pointing to).
And so the compiler generates the code for the destructor doing this inside main.cpp.
Now, keep in mind, the Object forward declaration is not a complete type. All it
does is tell the compiler "a type named Object exists" and allows us to
use the name in certain situations to avoid a header dependency. So the
compiler needs to generate destruction code for Object, but the compiler
doesn't know *how* to destruct it. A forward declaration doesn't tell
the compiler anything about Object's constructor or destructor. So, the
compiler will issue an error in this case because it's undefined
behavior to try and deallocate (or construct) an incomplete type and
std::shared_ptr and std::unique_ptr make sure this isn't the case
internally.
Now, if we had defaulted the destructor in "thing.cpp", where we also
include "object.h", this would never be an issue, as the destructor
would only have its code generated in one place, and it would be in a
place where the full class definition of Object would be visible to the
compiler.
---------------------- End example ----------------------------
Given these service classes are more than certainly going to change in
the future, this defaults the constructors and destructors into the
relevant cpp files to make the construction and destruction of all of
the services consistent and unlikely to run into cases where forward
declarations are indirectly causing compilation errors. It also has the
plus of avoiding the need to rebuild several services if destruction
logic changes, since it would only be necessary to recompile the single
cpp file.
|
|
|
|
|
