diff options
| author | lat9nq <22451773+lat9nq@users.noreply.github.com> | 2021-06-02 15:05:45 -0400 |
|---|---|---|
| committer | lat9nq <22451773+lat9nq@users.noreply.github.com> | 2021-06-02 19:50:20 -0400 |
| commit | c41451af75520a19b050347bb9c267b69773ff0a (patch) | |
| tree | ba77ef44510bcc5e31bc686328f3f9d152bbafb4 /src/yuzu/configuration/configure_per_game.h | |
| parent | 377cd301b30aaee015d6981387284ab5cbd7cc3e (diff) | |
yuzu qt: Revert some usages of string_view
Causes a heap-use-after free reported by AddressSanitizer. This makes
use of std::filesystem::path, but due to that we have to use their
string() function which may not work for all characters.
Diffstat (limited to 'src/yuzu/configuration/configure_per_game.h')
| -rw-r--r-- | src/yuzu/configuration/configure_per_game.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/yuzu/configuration/configure_per_game.h b/src/yuzu/configuration/configure_per_game.h index dc6b68763..a2d0211a3 100644 --- a/src/yuzu/configuration/configure_per_game.h +++ b/src/yuzu/configuration/configure_per_game.h @@ -28,7 +28,8 @@ class ConfigurePerGame : public QDialog { Q_OBJECT public: - explicit ConfigurePerGame(QWidget* parent, u64 title_id, std::string_view file_name); + // Cannot use std::filesystem::path due to https://bugreports.qt.io/browse/QTBUG-73263 + explicit ConfigurePerGame(QWidget* parent, u64 title_id, const std::string& file_name); ~ConfigurePerGame() override; /// Save all button configurations to settings file |