diff options
| author | Lioncash <mathew1800@gmail.com> | 2018-07-25 17:37:41 -0400 |
|---|---|---|
| committer | Lioncash <mathew1800@gmail.com> | 2018-07-25 17:37:43 -0400 |
| commit | f9951352f6e3b931a1046a3a85a5b356ebd9bf5b (patch) | |
| tree | 8988e909b4754a20dc2a7dfdddd11b0afc862d2a /src/core/hle/service/nvdrv/nvdrv.cpp | |
| parent | a2cd07d0940e8bcd84d08dbf8f1d6663dc61ab6f (diff) | |
service/nvdrv: Take std::string in Open() by const reference
Avoids copies from being made, since the string is only ever used for
lookup, the data is never transfered anywhere.
Ideally, we'd use a std::string_view here, but devices is a
std::unordered_map, not a std::map, so we can't use heterogenous lookup
here.
Diffstat (limited to 'src/core/hle/service/nvdrv/nvdrv.cpp')
| -rw-r--r-- | src/core/hle/service/nvdrv/nvdrv.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/hle/service/nvdrv/nvdrv.cpp b/src/core/hle/service/nvdrv/nvdrv.cpp index c5d3e2fff..1555ea806 100644 --- a/src/core/hle/service/nvdrv/nvdrv.cpp +++ b/src/core/hle/service/nvdrv/nvdrv.cpp @@ -42,7 +42,7 @@ Module::Module() { devices["/dev/nvhost-nvdec"] = std::make_shared<Devices::nvhost_nvdec>(); } -u32 Module::Open(std::string device_name) { +u32 Module::Open(const std::string& device_name) { ASSERT_MSG(devices.find(device_name) != devices.end(), "Trying to open unknown device {}", device_name); |
