diff options
| author | Liam <byteslice@airmail.cc> | 2023-02-22 21:40:53 -0500 |
|---|---|---|
| committer | Liam <byteslice@airmail.cc> | 2023-03-01 10:42:45 -0500 |
| commit | 9f9b64cda2079a1aebf2c4a12fc20c24891c23c9 (patch) | |
| tree | c9697c325ae6f1271b627ab7c93c5c84c2f9a13a /src/core/hle/kernel/k_condition_variable.cpp | |
| parent | 4165ac06806017cfcb8da547ae84dee554e465c3 (diff) | |
kernel: document previous location of interrupt disables in arbiter/condvar
Diffstat (limited to 'src/core/hle/kernel/k_condition_variable.cpp')
| -rw-r--r-- | src/core/hle/kernel/k_condition_variable.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/core/hle/kernel/k_condition_variable.cpp b/src/core/hle/kernel/k_condition_variable.cpp index 3f0be1c3f..50a805296 100644 --- a/src/core/hle/kernel/k_condition_variable.cpp +++ b/src/core/hle/kernel/k_condition_variable.cpp @@ -198,7 +198,9 @@ void KConditionVariable::SignalImpl(KThread* thread) { u32 prev_tag{}; bool can_access{}; { - // TODO(bunnei): We should disable interrupts here via KScopedInterruptDisable. + // NOTE: If scheduler lock is not held here, interrupt disable is required. + // KScopedInterruptDisable di; + // TODO(bunnei): We should call CanAccessAtomic(..) here. can_access = true; if (can_access) [[likely]] { |