diff options
| author | GPUCode <geoster3d@gmail.com> | 2023-11-19 11:21:53 +0200 |
|---|---|---|
| committer | t895 <clombardo169@gmail.com> | 2023-11-25 00:47:35 -0500 |
| commit | 6de2edcca1624982e99a72741d4fa289dc9d7551 (patch) | |
| tree | 8c355b39a6f71e333ccc2f929816ce96e40d3f2c /src/core/arm/nce/arm_nce.cpp | |
| parent | 8fab363237083a8130a7b2a023cd9c5dd83f8f4f (diff) | |
Address some review comments
Diffstat (limited to 'src/core/arm/nce/arm_nce.cpp')
| -rw-r--r-- | src/core/arm/nce/arm_nce.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/core/arm/nce/arm_nce.cpp b/src/core/arm/nce/arm_nce.cpp index 511248a0d..fd82f3b0e 100644 --- a/src/core/arm/nce/arm_nce.cpp +++ b/src/core/arm/nce/arm_nce.cpp @@ -4,7 +4,6 @@ #include <cinttypes> #include <memory> -#include "common/scope_exit.h" #include "common/signal_chain.h" #include "core/arm/nce/arm_nce.h" #include "core/arm/nce/patch.h" @@ -32,7 +31,7 @@ static_assert(offsetof(NativeExecutionParameters, magic) == TpidrEl0TlsMagic); fpsimd_context* GetFloatingPointState(mcontext_t& host_ctx) { _aarch64_ctx* header = reinterpret_cast<_aarch64_ctx*>(&host_ctx.__reserved); while (header->magic != FPSIMD_MAGIC) { - header = reinterpret_cast<_aarch64_ctx*>((char*)header + header->size); + header = reinterpret_cast<_aarch64_ctx*>(reinterpret_cast<char*>(header) + header->size); } return reinterpret_cast<fpsimd_context*>(header); } @@ -124,7 +123,7 @@ bool ARM_NCE::HandleGuestFault(GuestContext* guest_ctx, void* raw_info, void* ra // Forcibly mark the context as locked. We are still running. // We may race with SignalInterrupt here: - // - If we lose the race, then SignalInterrupt will send us a signal which are masking, + // - If we lose the race, then SignalInterrupt will send us a signal we are masking, // and it will do nothing when it is unmasked, as we have already left guest code. // - If we win the race, then SignalInterrupt will wait for us to unlock first. auto& thread_params = guest_ctx->parent->running_thread->GetNativeExecutionParameters(); |
