diff options
| author | bunnei <bunneidev@gmail.com> | 2021-03-05 22:10:03 -0800 |
|---|---|---|
| committer | bunnei <bunneidev@gmail.com> | 2021-03-05 22:10:03 -0800 |
| commit | 68ffac250ae2d1c2d5d961304d2c61f6755ab033 (patch) | |
| tree | 4888d0fd2474dc90ad84a17ba71010a325beb984 /src/common/fiber.h | |
| parent | 4cf5b860bddbce9a5dd121ab388bdf369a877e02 (diff) | |
common: fiber: Use weak_ptr when yielding.
- Avoids a memory leak, as taking a strong reference of the fiber here causes a circular reference.
- Supersedes #6006 with a more narrow fix.
Diffstat (limited to 'src/common/fiber.h')
| -rw-r--r-- | src/common/fiber.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/fiber.h b/src/common/fiber.h index f7f587f8c..d96be6019 100644 --- a/src/common/fiber.h +++ b/src/common/fiber.h @@ -41,7 +41,7 @@ public: /// Yields control from Fiber 'from' to Fiber 'to' /// Fiber 'from' must be the currently running fiber. - static void YieldTo(std::shared_ptr<Fiber> from, std::shared_ptr<Fiber> to); + static void YieldTo(std::weak_ptr<Fiber> weak_from, std::shared_ptr<Fiber> to); [[nodiscard]] static std::shared_ptr<Fiber> ThreadToFiber(); void SetRewindPoint(std::function<void(void*)>&& rewind_func, void* rewind_param); |
