[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

15 files changed, 39 insertions, 39 deletions

diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/Block.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/Block.cs
index d81daa90..6d4b1637 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/Block.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/Block.cs
@@ -4,7 +4,7 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class Block : IOperation
     {
-        private IEnumerable<IOperation> _operations;
+        private readonly IEnumerable<IOperation> _operations;
 
         public Block(IEnumerable<IOperation> operations)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/ForBlock.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/ForBlock.cs
index ef95fa2b..1e8cafa8 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/ForBlock.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/ForBlock.cs
@@ -4,9 +4,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class ForBlock : IOperation
     {
-        private ulong _count;
-        private Register _register;
-        private IEnumerable<IOperation> _operations;
+        private readonly ulong _count;
+        private readonly Register _register;
+        private readonly IEnumerable<IOperation> _operations;
 
         public ForBlock(ulong count, Register register, IEnumerable<IOperation> operations)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/IfBlock.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/IfBlock.cs
index b7c5684e..a6b31f25 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/IfBlock.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/IfBlock.cs
@@ -5,9 +5,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class IfBlock : IOperation
     {
-        private ICondition _condition;
-        private IEnumerable<IOperation> _operationsThen;
-        private IEnumerable<IOperation> _operationsElse;
+        private readonly ICondition _condition;
+        private readonly IEnumerable<IOperation> _operationsThen;
+        private readonly IEnumerable<IOperation> _operationsElse;
 
         public IfBlock(ICondition condition, IEnumerable<IOperation> operationsThen, IEnumerable<IOperation> operationsElse)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpAdd.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpAdd.cs
index 214518d7..855245e3 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpAdd.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpAdd.cs
@@ -2,9 +2,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpAdd<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _lhs;
-        IOperand _rhs;
+        readonly IOperand _destination;
+        readonly IOperand _lhs;
+        readonly IOperand _rhs;
 
         public OpAdd(IOperand destination, IOperand lhs, IOperand rhs)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpAnd.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpAnd.cs
index 366a82b0..7d1fa10b 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpAnd.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpAnd.cs
@@ -2,9 +2,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpAnd<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _lhs;
-        IOperand _rhs;
+        readonly IOperand _destination;
+        readonly IOperand _lhs;
+        readonly IOperand _rhs;
 
         public OpAnd(IOperand destination, IOperand lhs, IOperand rhs)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpLog.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpLog.cs
index 49f8b41e..4017e5f7 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpLog.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpLog.cs
@@ -4,8 +4,8 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpLog<T> : IOperation where T : unmanaged
     {
-        int _logId;
-        IOperand _source;
+        readonly int _logId;
+        readonly IOperand _source;
 
         public OpLog(int logId, IOperand source)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpLsh.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpLsh.cs
index 34e7c81a..6c846425 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpLsh.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpLsh.cs
@@ -2,9 +2,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpLsh<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _lhs;
-        IOperand _rhs;
+        readonly IOperand _destination;
+        readonly IOperand _lhs;
+        readonly IOperand _rhs;
 
         public OpLsh(IOperand destination, IOperand lhs, IOperand rhs)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpMov.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpMov.cs
index 5fad38f9..af82f18e 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpMov.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpMov.cs
@@ -2,8 +2,8 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpMov<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _source;
+        readonly IOperand _destination;
+        readonly IOperand _source;
 
         public OpMov(IOperand destination, IOperand source)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpMul.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpMul.cs
index 5aa0e34e..a1b080f0 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpMul.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpMul.cs
@@ -2,9 +2,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpMul<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _lhs;
-        IOperand _rhs;
+        readonly IOperand _destination;
+        readonly IOperand _lhs;
+        readonly IOperand _rhs;
 
         public OpMul(IOperand destination, IOperand lhs, IOperand rhs)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpNot.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpNot.cs
index 8a97c3fe..034e2200 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpNot.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpNot.cs
@@ -2,8 +2,8 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpNot<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _source;
+        readonly IOperand _destination;
+        readonly IOperand _source;
 
         public OpNot(IOperand destination, IOperand source)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpOr.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpOr.cs
index d074de1c..0afdc3f4 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpOr.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpOr.cs
@@ -2,9 +2,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpOr<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _lhs;
-        IOperand _rhs;
+        readonly IOperand _destination;
+        readonly IOperand _lhs;
+        readonly IOperand _rhs;
 
         public OpOr(IOperand destination, IOperand lhs, IOperand rhs)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpProcCtrl.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpProcCtrl.cs
index 1b89f450..5de225a1 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpProcCtrl.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpProcCtrl.cs
@@ -2,8 +2,8 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpProcCtrl : IOperation
     {
-        private ITamperedProcess _process;
-        private bool _pause;
+        private readonly ITamperedProcess _process;
+        private readonly bool _pause;
 
         public OpProcCtrl(ITamperedProcess process, bool pause)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpRsh.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpRsh.cs
index b08dd957..e7e0f870 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpRsh.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpRsh.cs
@@ -2,9 +2,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpRsh<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _lhs;
-        IOperand _rhs;
+        readonly IOperand _destination;
+        readonly IOperand _lhs;
+        readonly IOperand _rhs;
 
         public OpRsh(IOperand destination, IOperand lhs, IOperand rhs)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpSub.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpSub.cs
index b9c67d04..d860d66f 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpSub.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpSub.cs
@@ -2,9 +2,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpSub<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _lhs;
-        IOperand _rhs;
+        readonly IOperand _destination;
+        readonly IOperand _lhs;
+        readonly IOperand _rhs;
 
         public OpSub(IOperand destination, IOperand lhs, IOperand rhs)
         {
diff --git a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpXor.cs b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpXor.cs
index 3bbb76a1..07ba6b33 100644
--- a/src/Ryujinx.HLE/HOS/Tamper/Operations/OpXor.cs
+++ b/src/Ryujinx.HLE/HOS/Tamper/Operations/OpXor.cs
@@ -2,9 +2,9 @@ namespace Ryujinx.HLE.HOS.Tamper.Operations
 {
     class OpXor<T> : IOperation where T : unmanaged
     {
-        IOperand _destination;
-        IOperand _lhs;
-        IOperand _rhs;
+        readonly IOperand _destination;
+        readonly IOperand _lhs;
+        readonly IOperand _rhs;
 
         public OpXor(IOperand destination, IOperand lhs, IOperand rhs)
         {