[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

7 files changed, 17 insertions, 18 deletions

diff --git a/src/Ryujinx.HLE/HOS/SystemState/AppletStateMgr.cs b/src/Ryujinx.HLE/HOS/SystemState/AppletStateMgr.cs
index 5704ef4b..a2837e20 100644
--- a/src/Ryujinx.HLE/HOS/SystemState/AppletStateMgr.cs
+++ b/src/Ryujinx.HLE/HOS/SystemState/AppletStateMgr.cs
@@ -18,7 +18,7 @@ namespace Ryujinx.HLE.HOS.SystemState
 
         public AppletStateMgr(Horizon system)
         {
-            Messages     = new ConcurrentQueue<AppletMessage>();
+            Messages = new ConcurrentQueue<AppletMessage>();
             MessageEvent = new KEvent(system.KernelContext);
 
             AppletResourceUserIds = new IdDictionary();
@@ -39,4 +39,4 @@ namespace Ryujinx.HLE.HOS.SystemState
             MessageEvent.ReadableEvent.Signal();
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/SystemState/ColorSet.cs b/src/Ryujinx.HLE/HOS/SystemState/ColorSet.cs
index 4d7a7e2f..b1924206 100644
--- a/src/Ryujinx.HLE/HOS/SystemState/ColorSet.cs
+++ b/src/Ryujinx.HLE/HOS/SystemState/ColorSet.cs
@@ -3,6 +3,6 @@ namespace Ryujinx.HLE.HOS.SystemState
     public enum ColorSet
     {
         BasicWhite = 0,
-        BasicBlack = 1
+        BasicBlack = 1,
     }
 }
diff --git a/src/Ryujinx.HLE/HOS/SystemState/KeyboardLayout.cs b/src/Ryujinx.HLE/HOS/SystemState/KeyboardLayout.cs
index ba35ea6b..e3cb68a2 100644
--- a/src/Ryujinx.HLE/HOS/SystemState/KeyboardLayout.cs
+++ b/src/Ryujinx.HLE/HOS/SystemState/KeyboardLayout.cs
@@ -20,6 +20,6 @@ namespace Ryujinx.HLE.HOS.SystemState
         ChineseTraditional,
 
         Min = Default,
-        Max = ChineseTraditional
+        Max = ChineseTraditional,
     }
 }
diff --git a/src/Ryujinx.HLE/HOS/SystemState/RegionCode.cs b/src/Ryujinx.HLE/HOS/SystemState/RegionCode.cs
index dd6ed8fa..11122723 100644
--- a/src/Ryujinx.HLE/HOS/SystemState/RegionCode.cs
+++ b/src/Ryujinx.HLE/HOS/SystemState/RegionCode.cs
@@ -12,6 +12,6 @@ namespace Ryujinx.HLE.HOS.SystemState
         Taiwan,
 
         Min = Japan,
-        Max = Taiwan
+        Max = Taiwan,
     }
 }
diff --git a/src/Ryujinx.HLE/HOS/SystemState/SystemLanguage.cs b/src/Ryujinx.HLE/HOS/SystemState/SystemLanguage.cs
index 3f755105..f5b7fc0f 100644
--- a/src/Ryujinx.HLE/HOS/SystemState/SystemLanguage.cs
+++ b/src/Ryujinx.HLE/HOS/SystemState/SystemLanguage.cs
@@ -19,6 +19,6 @@ namespace Ryujinx.HLE.HOS.SystemState
         LatinAmericanSpanish,
         SimplifiedChinese,
         TraditionalChinese,
-        BrazilianPortuguese
+        BrazilianPortuguese,
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/SystemState/SystemStateMgr.cs b/src/Ryujinx.HLE/HOS/SystemState/SystemStateMgr.cs
index 6627700f..c650fe03 100644
--- a/src/Ryujinx.HLE/HOS/SystemState/SystemStateMgr.cs
+++ b/src/Ryujinx.HLE/HOS/SystemState/SystemStateMgr.cs
@@ -4,8 +4,7 @@ namespace Ryujinx.HLE.HOS.SystemState
 {
     public class SystemStateMgr
     {
-        internal static string[] LanguageCodes = new string[]
-        {
+        internal static string[] LanguageCodes = {
             "ja",
             "en-US",
             "fr",
@@ -23,7 +22,7 @@ namespace Ryujinx.HLE.HOS.SystemState
             "es-419",
             "zh-Hans",
             "zh-Hant",
-            "pt-BR"
+            "pt-BR",
         };
 
         internal long DesiredKeyboardLayout { get; private set; }
@@ -46,21 +45,21 @@ namespace Ryujinx.HLE.HOS.SystemState
         {
             // TODO: Let user specify fields.
             DesiredKeyboardLayout = (long)KeyboardLayout.Default;
-            DeviceNickName        = "Ryujinx's Switch";
+            DeviceNickName = "Ryujinx's Switch";
         }
 
         public void SetLanguage(SystemLanguage language)
         {
             DesiredSystemLanguage = language;
-            DesiredLanguageCode   = GetLanguageCode((int)DesiredSystemLanguage);
+            DesiredLanguageCode = GetLanguageCode((int)DesiredSystemLanguage);
 
             DesiredTitleLanguage = language switch
             {
                 SystemLanguage.Taiwanese or
                 SystemLanguage.TraditionalChinese => TitleLanguage.TraditionalChinese,
                 SystemLanguage.Chinese or
-                SystemLanguage.SimplifiedChinese  => TitleLanguage.SimplifiedChinese,
-                _                                 => Enum.Parse<TitleLanguage>(Enum.GetName<SystemLanguage>(language)),
+                SystemLanguage.SimplifiedChinese => TitleLanguage.SimplifiedChinese,
+                _ => Enum.Parse<TitleLanguage>(Enum.GetName<SystemLanguage>(language)),
             };
         }
 
@@ -76,8 +75,8 @@ namespace Ryujinx.HLE.HOS.SystemState
                 throw new ArgumentOutOfRangeException(nameof(index));
             }
 
-            long code  = 0;
-            int  shift = 0;
+            long code = 0;
+            int shift = 0;
 
             foreach (char chr in LanguageCodes[index])
             {
@@ -87,4 +86,4 @@ namespace Ryujinx.HLE.HOS.SystemState
             return code;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/SystemState/TitleLanguage.cs b/src/Ryujinx.HLE/HOS/SystemState/TitleLanguage.cs
index c612259b..5a0b9f8c 100644
--- a/src/Ryujinx.HLE/HOS/SystemState/TitleLanguage.cs
+++ b/src/Ryujinx.HLE/HOS/SystemState/TitleLanguage.cs
@@ -17,6 +17,6 @@
         Korean,
         TraditionalChinese,
         SimplifiedChinese,
-        BrazilianPortuguese
+        BrazilianPortuguese,
     }
 }