[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

6 files changed, 93 insertions, 99 deletions

diff --git a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/EventFileDescriptor.cs b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/EventFileDescriptor.cs
index d7b53158..937d2fd7 100644
--- a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/EventFileDescriptor.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/EventFileDescriptor.cs
@@ -150,4 +150,4 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             }
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/EventFileDescriptorPollManager.cs b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/EventFileDescriptorPollManager.cs
index e0ab68c6..9039d49a 100644
--- a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/EventFileDescriptorPollManager.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/EventFileDescriptorPollManager.cs
@@ -13,10 +13,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
         {
             get
             {
-                if (_instance == null)
-                {
-                    _instance = new EventFileDescriptorPollManager();
-                }
+                _instance ??= new EventFileDescriptorPollManager();
 
                 return _instance;
             }
@@ -31,7 +28,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
         {
             updatedCount = 0;
 
-            List<ManualResetEvent> waiters = new List<ManualResetEvent>();
+            List<ManualResetEvent> waiters = new();
 
             for (int i = 0; i < events.Count; i++)
             {
@@ -119,4 +116,4 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             return LinuxError.EOPNOTSUPP;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/ManagedSocket.cs b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/ManagedSocket.cs
index 75efc49a..dfc2a672 100644
--- a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/ManagedSocket.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/ManagedSocket.cs
@@ -462,7 +462,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
 
             if (!CanSupportMMsgHdr(message))
             {
-                Logger.Warning?.Print(LogClass.ServiceBsd, $"Unsupported BsdMMsgHdr");
+                Logger.Warning?.Print(LogClass.ServiceBsd, "Unsupported BsdMMsgHdr");
 
                 return LinuxError.EOPNOTSUPP;
             }
@@ -500,7 +500,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
 
             if (!CanSupportMMsgHdr(message))
             {
-                Logger.Warning?.Print(LogClass.ServiceBsd, $"Unsupported BsdMMsgHdr");
+                Logger.Warning?.Print(LogClass.ServiceBsd, "Unsupported BsdMMsgHdr");
 
                 return LinuxError.EOPNOTSUPP;
             }
@@ -527,4 +527,4 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             }
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/ManagedSocketPollManager.cs b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/ManagedSocketPollManager.cs
index 1b305dfb..10d9882c 100644
--- a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/ManagedSocketPollManager.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/ManagedSocketPollManager.cs
@@ -13,10 +13,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
         {
             get
             {
-                if (_instance == null)
-                {
-                    _instance = new ManagedSocketPollManager();
-                }
+                _instance ??= new ManagedSocketPollManager();
 
                 return _instance;
             }
@@ -29,9 +26,9 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
 
         public LinuxError Poll(List<PollEvent> events, int timeoutMilliseconds, out int updatedCount)
         {
-            List<Socket> readEvents = new List<Socket>();
-            List<Socket> writeEvents = new List<Socket>();
-            List<Socket> errorEvents = new List<Socket>();
+            List<Socket> readEvents = new();
+            List<Socket> writeEvents = new();
+            List<Socket> errorEvents = new();
 
             updatedCount = 0;
 
@@ -174,4 +171,4 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             return LinuxError.SUCCESS;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/WSAError.cs b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/WSAError.cs
index 0f24a57f..5f3495df 100644
--- a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/WSAError.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/WSAError.cs
@@ -9,77 +9,77 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
         * All Windows Sockets error constants are biased by WSABASEERR from
         * the "normal"
         */
-        WSABASEERR                 = 10000,
+        WSABASEERR = 10000,
 
         /*
         * Windows Sockets definitions of regular Microsoft C error constants
         */
-        WSAEINTR                   = (WSABASEERR + 4),
-        WSAEBADF                   = (WSABASEERR + 9),
-        WSAEACCES                  = (WSABASEERR + 13),
-        WSAEFAULT                  = (WSABASEERR + 14),
-        WSAEINVAL                  = (WSABASEERR + 22),
-        WSAEMFILE                  = (WSABASEERR + 24),
+        WSAEINTR = (WSABASEERR + 4),
+        WSAEBADF = (WSABASEERR + 9),
+        WSAEACCES = (WSABASEERR + 13),
+        WSAEFAULT = (WSABASEERR + 14),
+        WSAEINVAL = (WSABASEERR + 22),
+        WSAEMFILE = (WSABASEERR + 24),
 
         /*
          * Windows Sockets definitions of regular Berkeley error constants
          */
-        WSAEWOULDBLOCK             = (WSABASEERR + 35),
-        WSAEINPROGRESS             = (WSABASEERR + 36),
-        WSAEALREADY                = (WSABASEERR + 37),
-        WSAENOTSOCK                = (WSABASEERR + 38),
-        WSAEDESTADDRREQ            = (WSABASEERR + 39),
-        WSAEMSGSIZE                = (WSABASEERR + 40),
-        WSAEPROTOTYPE              = (WSABASEERR + 41),
-        WSAENOPROTOOPT             = (WSABASEERR + 42),
-        WSAEPROTONOSUPPORT         = (WSABASEERR + 43),
-        WSAESOCKTNOSUPPORT         = (WSABASEERR + 44),
-        WSAEOPNOTSUPP              = (WSABASEERR + 45),
-        WSAEPFNOSUPPORT            = (WSABASEERR + 46),
-        WSAEAFNOSUPPORT            = (WSABASEERR + 47),
-        WSAEADDRINUSE              = (WSABASEERR + 48),
-        WSAEADDRNOTAVAIL           = (WSABASEERR + 49),
-        WSAENETDOWN                = (WSABASEERR + 50),
-        WSAENETUNREACH             = (WSABASEERR + 51),
-        WSAENETRESET               = (WSABASEERR + 52),
-        WSAECONNABORTED            = (WSABASEERR + 53),
-        WSAECONNRESET              = (WSABASEERR + 54),
-        WSAENOBUFS                 = (WSABASEERR + 55),
-        WSAEISCONN                 = (WSABASEERR + 56),
-        WSAENOTCONN                = (WSABASEERR + 57),
-        WSAESHUTDOWN               = (WSABASEERR + 58),
-        WSAETOOMANYREFS            = (WSABASEERR + 59),
-        WSAETIMEDOUT               = (WSABASEERR + 60),
-        WSAECONNREFUSED            = (WSABASEERR + 61),
-        WSAELOOP                   = (WSABASEERR + 62),
-        WSAENAMETOOLONG            = (WSABASEERR + 63),
-        WSAEHOSTDOWN               = (WSABASEERR + 64),
-        WSAEHOSTUNREACH            = (WSABASEERR + 65),
-        WSAENOTEMPTY               = (WSABASEERR + 66),
-        WSAEPROCLIM                = (WSABASEERR + 67),
-        WSAEUSERS                  = (WSABASEERR + 68),
-        WSAEDQUOT                  = (WSABASEERR + 69),
-        WSAESTALE                  = (WSABASEERR + 70),
-        WSAEREMOTE                 = (WSABASEERR + 71),
+        WSAEWOULDBLOCK = (WSABASEERR + 35),
+        WSAEINPROGRESS = (WSABASEERR + 36),
+        WSAEALREADY = (WSABASEERR + 37),
+        WSAENOTSOCK = (WSABASEERR + 38),
+        WSAEDESTADDRREQ = (WSABASEERR + 39),
+        WSAEMSGSIZE = (WSABASEERR + 40),
+        WSAEPROTOTYPE = (WSABASEERR + 41),
+        WSAENOPROTOOPT = (WSABASEERR + 42),
+        WSAEPROTONOSUPPORT = (WSABASEERR + 43),
+        WSAESOCKTNOSUPPORT = (WSABASEERR + 44),
+        WSAEOPNOTSUPP = (WSABASEERR + 45),
+        WSAEPFNOSUPPORT = (WSABASEERR + 46),
+        WSAEAFNOSUPPORT = (WSABASEERR + 47),
+        WSAEADDRINUSE = (WSABASEERR + 48),
+        WSAEADDRNOTAVAIL = (WSABASEERR + 49),
+        WSAENETDOWN = (WSABASEERR + 50),
+        WSAENETUNREACH = (WSABASEERR + 51),
+        WSAENETRESET = (WSABASEERR + 52),
+        WSAECONNABORTED = (WSABASEERR + 53),
+        WSAECONNRESET = (WSABASEERR + 54),
+        WSAENOBUFS = (WSABASEERR + 55),
+        WSAEISCONN = (WSABASEERR + 56),
+        WSAENOTCONN = (WSABASEERR + 57),
+        WSAESHUTDOWN = (WSABASEERR + 58),
+        WSAETOOMANYREFS = (WSABASEERR + 59),
+        WSAETIMEDOUT = (WSABASEERR + 60),
+        WSAECONNREFUSED = (WSABASEERR + 61),
+        WSAELOOP = (WSABASEERR + 62),
+        WSAENAMETOOLONG = (WSABASEERR + 63),
+        WSAEHOSTDOWN = (WSABASEERR + 64),
+        WSAEHOSTUNREACH = (WSABASEERR + 65),
+        WSAENOTEMPTY = (WSABASEERR + 66),
+        WSAEPROCLIM = (WSABASEERR + 67),
+        WSAEUSERS = (WSABASEERR + 68),
+        WSAEDQUOT = (WSABASEERR + 69),
+        WSAESTALE = (WSABASEERR + 70),
+        WSAEREMOTE = (WSABASEERR + 71),
 
         /*
          * Extended Windows Sockets error constant definitions
          */
-        WSASYSNOTREADY             = (WSABASEERR + 91),
-        WSAVERNOTSUPPORTED         = (WSABASEERR + 92),
-        WSANOTINITIALISED          = (WSABASEERR + 93),
-        WSAEDISCON                 = (WSABASEERR + 101),
-        WSAENOMORE                 = (WSABASEERR + 102),
-        WSAECANCELLED              = (WSABASEERR + 103),
-        WSAEINVALIDPROCTABLE       = (WSABASEERR + 104),
-        WSAEINVALIDPROVIDER        = (WSABASEERR + 105),
-        WSAEPROVIDERFAILEDINIT     = (WSABASEERR + 106),
-        WSASYSCALLFAILURE          = (WSABASEERR + 107),
-        WSASERVICE_NOT_FOUND       = (WSABASEERR + 108),
-        WSATYPE_NOT_FOUND          = (WSABASEERR + 109),
-        WSA_E_NO_MORE              = (WSABASEERR + 110),
-        WSA_E_CANCELLED            = (WSABASEERR + 111),
-        WSAEREFUSED                = (WSABASEERR + 112),
+        WSASYSNOTREADY = (WSABASEERR + 91),
+        WSAVERNOTSUPPORTED = (WSABASEERR + 92),
+        WSANOTINITIALISED = (WSABASEERR + 93),
+        WSAEDISCON = (WSABASEERR + 101),
+        WSAENOMORE = (WSABASEERR + 102),
+        WSAECANCELLED = (WSABASEERR + 103),
+        WSAEINVALIDPROCTABLE = (WSABASEERR + 104),
+        WSAEINVALIDPROVIDER = (WSABASEERR + 105),
+        WSAEPROVIDERFAILEDINIT = (WSABASEERR + 106),
+        WSASYSCALLFAILURE = (WSABASEERR + 107),
+        WSASERVICE_NOT_FOUND = (WSABASEERR + 108),
+        WSATYPE_NOT_FOUND = (WSABASEERR + 109),
+        WSA_E_NO_MORE = (WSABASEERR + 110),
+        WSA_E_CANCELLED = (WSABASEERR + 111),
+        WSAEREFUSED = (WSABASEERR + 112),
 
         /*
          * Error return codes from gethostbyname() and gethostbyaddr()
@@ -93,42 +93,42 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
          */
 
         /* Authoritative Answer: Host not found */
-        WSAHOST_NOT_FOUND          = (WSABASEERR + 1001),
+        WSAHOST_NOT_FOUND = (WSABASEERR + 1001),
 
         /* Non-Authoritative: Host not found, or SERVERFAIL */
-        WSATRY_AGAIN               = (WSABASEERR + 1002),
+        WSATRY_AGAIN = (WSABASEERR + 1002),
 
         /* Non-recoverable errors, FORMERR, REFUSED, NOTIMP */
-        WSANO_RECOVERY             = (WSABASEERR + 1003),
+        WSANO_RECOVERY = (WSABASEERR + 1003),
 
         /* Valid name, no data record of requested type */
-        WSANO_DATA                 = (WSABASEERR + 1004),
+        WSANO_DATA = (WSABASEERR + 1004),
 
         /*
          * Define QOS related error return codes
          *
          */
-        WSA_QOS_RECEIVERS          = (WSABASEERR + 1005),
+        WSA_QOS_RECEIVERS = (WSABASEERR + 1005),
         /* at least one Reserve has arrived */
-        WSA_QOS_SENDERS            = (WSABASEERR + 1006),
+        WSA_QOS_SENDERS = (WSABASEERR + 1006),
         /* at least one Path has arrived */
-        WSA_QOS_NO_SENDERS         = (WSABASEERR + 1007),
+        WSA_QOS_NO_SENDERS = (WSABASEERR + 1007),
         /* there are no senders */
-        WSA_QOS_NO_RECEIVERS       = (WSABASEERR + 1008),
+        WSA_QOS_NO_RECEIVERS = (WSABASEERR + 1008),
         /* there are no receivers */
-        WSA_QOS_REQUEST_CONFIRMED  = (WSABASEERR + 1009),
+        WSA_QOS_REQUEST_CONFIRMED = (WSABASEERR + 1009),
         /* Reserve has been confirmed */
-        WSA_QOS_ADMISSION_FAILURE  = (WSABASEERR + 1010),
+        WSA_QOS_ADMISSION_FAILURE = (WSABASEERR + 1010),
         /* error due to lack of resources */
-        WSA_QOS_POLICY_FAILURE     = (WSABASEERR + 1011),
+        WSA_QOS_POLICY_FAILURE = (WSABASEERR + 1011),
         /* rejected for administrative reasons - bad credentials */
-        WSA_QOS_BAD_STYLE          = (WSABASEERR + 1012),
+        WSA_QOS_BAD_STYLE = (WSABASEERR + 1012),
         /* unknown or conflicting style */
-        WSA_QOS_BAD_OBJECT         = (WSABASEERR + 1013),
+        WSA_QOS_BAD_OBJECT = (WSABASEERR + 1013),
         /* problem with some part of the filterspec or providerspecific
          * buffer in general */
         WSA_QOS_TRAFFIC_CTRL_ERROR = (WSABASEERR + 1014),
         /* problem with some part of the flowspec */
-        WSA_QOS_GENERIC_ERROR      = (WSABASEERR + 1015)
+        WSA_QOS_GENERIC_ERROR = (WSABASEERR + 1015),
     }
 }
diff --git a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/WinSockHelper.cs b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/WinSockHelper.cs
index 5668d30b..9df18023 100644
--- a/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/WinSockHelper.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Sockets/Bsd/Impl/WinSockHelper.cs
@@ -1,5 +1,5 @@
 using Ryujinx.HLE.HOS.Services.Sockets.Bsd.Types;
-using System;
+using System;
 using System.Collections.Generic;
 using System.Net.Sockets;
 
@@ -88,7 +88,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             // WSAEFAULT
             { WsaError.WSAEFAULT,          LinuxError.EFAULT },
             // NOERROR
-            { 0, 0 }
+            { 0, 0 },
         };
 
         private static readonly Dictionary<int, LinuxError> _errorMapMacOs = new()
@@ -136,7 +136,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             { 59, LinuxError.ETOOMANYREFS },
             { 92, LinuxError.EILSEQ },
             { 89, LinuxError.ECANCELED },
-            { 84, LinuxError.EOVERFLOW }
+            { 84, LinuxError.EOVERFLOW },
         };
 
         private static readonly Dictionary<BsdSocketOption, SocketOptionName> _soSocketOptionMap = new()
@@ -157,7 +157,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             { BsdSocketOption.SoSndTimeo,    SocketOptionName.SendTimeout },
             { BsdSocketOption.SoRcvTimeo,    SocketOptionName.ReceiveTimeout },
             { BsdSocketOption.SoError,       SocketOptionName.Error },
-            { BsdSocketOption.SoType,        SocketOptionName.Type }
+            { BsdSocketOption.SoType,        SocketOptionName.Type },
         };
 
         private static readonly Dictionary<BsdSocketOption, SocketOptionName> _ipSocketOptionMap = new()
@@ -172,7 +172,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             { BsdSocketOption.IpDropMembership,       SocketOptionName.DropMembership },
             { BsdSocketOption.IpDontFrag,             SocketOptionName.DontFragment },
             { BsdSocketOption.IpAddSourceMembership,  SocketOptionName.AddSourceMembership },
-            { BsdSocketOption.IpDropSourceMembership, SocketOptionName.DropSourceMembership }
+            { BsdSocketOption.IpDropSourceMembership, SocketOptionName.DropSourceMembership },
         };
 
         private static readonly Dictionary<BsdSocketOption, SocketOptionName> _tcpSocketOptionMap = new()
@@ -180,7 +180,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             { BsdSocketOption.TcpNoDelay,   SocketOptionName.NoDelay },
             { BsdSocketOption.TcpKeepIdle,  SocketOptionName.TcpKeepAliveTime },
             { BsdSocketOption.TcpKeepIntvl, SocketOptionName.TcpKeepAliveInterval },
-            { BsdSocketOption.TcpKeepCnt,   SocketOptionName.TcpKeepAliveRetryCount }
+            { BsdSocketOption.TcpKeepCnt,   SocketOptionName.TcpKeepAliveRetryCount },
         };
 
         public static LinuxError ConvertError(WsaError errorCode)
@@ -210,7 +210,7 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
                 SocketOptionLevel.Socket => _soSocketOptionMap,
                 SocketOptionLevel.IP => _ipSocketOptionMap,
                 SocketOptionLevel.Tcp => _tcpSocketOptionMap,
-                _ => null
+                _ => null,
             };
 
             if (table == null)
@@ -222,4 +222,4 @@ namespace Ryujinx.HLE.HOS.Services.Sockets.Bsd.Impl
             return table.TryGetValue(option, out name);
         }
     }
-}
\ No newline at end of file
+}