[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

8 files changed, 20 insertions, 20 deletions

diff --git a/src/Ryujinx.HLE/HOS/Services/Ldn/IMonitorServiceCreator.cs b/src/Ryujinx.HLE/HOS/Services/Ldn/IMonitorServiceCreator.cs
index 09dfa78f..a7e99241 100644
--- a/src/Ryujinx.HLE/HOS/Services/Ldn/IMonitorServiceCreator.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Ldn/IMonitorServiceCreator.cs
@@ -5,4 +5,4 @@
     {
         public IMonitorServiceCreator(ServiceCtx context) { }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Ldn/ISystemServiceCreator.cs b/src/Ryujinx.HLE/HOS/Services/Ldn/ISystemServiceCreator.cs
index b4dac449..9acfef5c 100644
--- a/src/Ryujinx.HLE/HOS/Services/Ldn/ISystemServiceCreator.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Ldn/ISystemServiceCreator.cs
@@ -5,4 +5,4 @@
     {
         public ISystemServiceCreator(ServiceCtx context) { }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Ldn/IUserServiceCreator.cs b/src/Ryujinx.HLE/HOS/Services/Ldn/IUserServiceCreator.cs
index 4f3094ae..317b1dbe 100644
--- a/src/Ryujinx.HLE/HOS/Services/Ldn/IUserServiceCreator.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Ldn/IUserServiceCreator.cs
@@ -16,4 +16,4 @@ namespace Ryujinx.HLE.HOS.Services.Ldn
             return ResultCode.Success;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Ldn/Lp2p/IServiceCreator.cs b/src/Ryujinx.HLE/HOS/Services/Ldn/Lp2p/IServiceCreator.cs
index 9c9ee3be..f2fd482d 100644
--- a/src/Ryujinx.HLE/HOS/Services/Ldn/Lp2p/IServiceCreator.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Ldn/Lp2p/IServiceCreator.cs
@@ -6,4 +6,4 @@
     {
         public IServiceCreator(ServiceCtx context) { }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Ldn/NetworkInterface.cs b/src/Ryujinx.HLE/HOS/Services/Ldn/NetworkInterface.cs
index 274b6132..26696cbe 100644
--- a/src/Ryujinx.HLE/HOS/Services/Ldn/NetworkInterface.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Ldn/NetworkInterface.cs
@@ -7,15 +7,15 @@ namespace Ryujinx.HLE.HOS.Services.Ldn
 {
     internal class NetworkInterface
     {
-        public ResultCode NifmState        { get; set; }
-        public KEvent     StateChangeEvent { get; private set; }
+        public ResultCode NifmState { get; set; }
+        public KEvent StateChangeEvent { get; private set; }
 
         private NetworkState _state;
 
         public NetworkInterface(Horizon system)
         {
             // TODO(Ac_K): Determine where the internal state is set.
-            NifmState        = ResultCode.Success;
+            NifmState = ResultCode.Success;
             StateChangeEvent = new KEvent(system.KernelContext);
 
             _state = NetworkState.None;
@@ -56,4 +56,4 @@ namespace Ryujinx.HLE.HOS.Services.Ldn
             return ResultCode.Success;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Ldn/ResultCode.cs b/src/Ryujinx.HLE/HOS/Services/Ldn/ResultCode.cs
index 87674f7c..a9f2cbc3 100644
--- a/src/Ryujinx.HLE/HOS/Services/Ldn/ResultCode.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Ldn/ResultCode.cs
@@ -2,15 +2,15 @@ namespace Ryujinx.HLE.HOS.Services.Ldn
 {
     enum ResultCode
     {
-        ModuleId       = 203,
+        ModuleId = 203,
         ErrorCodeShift = 9,
 
         Success = 0,
 
-        DeviceDisabled  = (22 << ErrorCodeShift) | ModuleId,
-        InvalidState    = (32 << ErrorCodeShift) | ModuleId,
-        Unknown1        = (48 << ErrorCodeShift) | ModuleId,
+        DeviceDisabled = (22 << ErrorCodeShift) | ModuleId,
+        InvalidState = (32 << ErrorCodeShift) | ModuleId,
+        Unknown1 = (48 << ErrorCodeShift) | ModuleId,
         InvalidArgument = (96 << ErrorCodeShift) | ModuleId,
-        InvalidObject   = (97 << ErrorCodeShift) | ModuleId,
+        InvalidObject = (97 << ErrorCodeShift) | ModuleId,
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Ldn/Types/NetworkState.cs b/src/Ryujinx.HLE/HOS/Services/Ldn/Types/NetworkState.cs
index 6ac20483..61fd831d 100644
--- a/src/Ryujinx.HLE/HOS/Services/Ldn/Types/NetworkState.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Ldn/Types/NetworkState.cs
@@ -8,6 +8,6 @@
         AccessPointCreated,
         Station,
         StationConnected,
-        Error
+        Error,
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Ldn/UserServiceCreator/IUserLocalCommunicationService.cs b/src/Ryujinx.HLE/HOS/Services/Ldn/UserServiceCreator/IUserLocalCommunicationService.cs
index f425ddf7..d390a3e6 100644
--- a/src/Ryujinx.HLE/HOS/Services/Ldn/UserServiceCreator/IUserLocalCommunicationService.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Ldn/UserServiceCreator/IUserLocalCommunicationService.cs
@@ -11,7 +11,7 @@ namespace Ryujinx.HLE.HOS.Services.Ldn.UserServiceCreator
         // TODO(Ac_K): Determine what the hardcoded unknown value is.
         private const int UnknownValue = 90;
 
-        private NetworkInterface _networkInterface;
+        private readonly NetworkInterface _networkInterface;
 
         private int _stateChangeEventHandle = 0;
 
@@ -79,10 +79,10 @@ namespace Ryujinx.HLE.HOS.Services.Ldn.UserServiceCreator
         public ResultCode Initialize(ServiceCtx context)
         {
             // TODO(Ac_K): Determine what addresses are.
-            IPAddress unknownAddress1 = new IPAddress(context.RequestData.ReadUInt32());
-            IPAddress unknownAddress2 = new IPAddress(context.RequestData.ReadUInt32());
+            IPAddress unknownAddress1 = new(context.RequestData.ReadUInt32());
+            IPAddress unknownAddress2 = new(context.RequestData.ReadUInt32());
 
             return _networkInterface.Initialize(UnknownValue, version: 1, unknownAddress1, unknownAddress2);
         }
     }
-}
\ No newline at end of file
+}