[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

9 files changed, 67 insertions, 67 deletions

diff --git a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/IIrSensorServer.cs b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/IIrSensorServer.cs
index 130fcf68..a13e77e7 100644
--- a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/IIrSensorServer.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/IIrSensorServer.cs
@@ -65,8 +65,8 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         // StopImageProcessor(pid, nn::irsensor::IrCameraHandle, nn::applet::AppletResourceUserId)
         public ResultCode StopImageProcessor(ServiceCtx context)
         {
-            IrCameraHandle irCameraHandle       = context.RequestData.ReadStruct<IrCameraHandle>();
-            ulong          appletResourceUserId = context.RequestData.ReadUInt64();
+            IrCameraHandle irCameraHandle = context.RequestData.ReadStruct<IrCameraHandle>();
+            ulong appletResourceUserId = context.RequestData.ReadUInt64();
 
             CheckCameraHandle(irCameraHandle);
 
@@ -79,9 +79,9 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         // RunMomentProcessor(pid, nn::irsensor::IrCameraHandle, nn::applet::AppletResourceUserId, PackedMomentProcessorConfig)
         public ResultCode RunMomentProcessor(ServiceCtx context)
         {
-            IrCameraHandle irCameraHandle              = context.RequestData.ReadStruct<IrCameraHandle>();
-            ulong          appletResourceUserId        = context.RequestData.ReadUInt64();
-            var            packedMomentProcessorConfig = context.RequestData.ReadStruct<PackedMomentProcessorConfig>();
+            IrCameraHandle irCameraHandle = context.RequestData.ReadStruct<IrCameraHandle>();
+            ulong appletResourceUserId = context.RequestData.ReadUInt64();
+            var packedMomentProcessorConfig = context.RequestData.ReadStruct<PackedMomentProcessorConfig>();
 
             CheckCameraHandle(irCameraHandle);
 
@@ -94,9 +94,9 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         // RunClusteringProcessor(pid, nn::irsensor::IrCameraHandle, nn::applet::AppletResourceUserId, PackedClusteringProcessorConfig)
         public ResultCode RunClusteringProcessor(ServiceCtx context)
         {
-            IrCameraHandle irCameraHandle                  = context.RequestData.ReadStruct<IrCameraHandle>();
-            ulong          appletResourceUserId            = context.RequestData.ReadUInt64();
-            var            packedClusteringProcessorConfig = context.RequestData.ReadStruct<PackedClusteringProcessorConfig>();
+            IrCameraHandle irCameraHandle = context.RequestData.ReadStruct<IrCameraHandle>();
+            ulong appletResourceUserId = context.RequestData.ReadUInt64();
+            var packedClusteringProcessorConfig = context.RequestData.ReadStruct<PackedClusteringProcessorConfig>();
 
             CheckCameraHandle(irCameraHandle);
 
@@ -109,9 +109,9 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         // RunImageTransferProcessor(pid, nn::irsensor::IrCameraHandle, nn::applet::AppletResourceUserId, PackedImageTransferProcessorConfig, u64 TransferMemorySize, TransferMemoryHandle)
         public ResultCode RunImageTransferProcessor(ServiceCtx context)
         {
-            IrCameraHandle irCameraHandle                     = context.RequestData.ReadStruct<IrCameraHandle>();
-            ulong          appletResourceUserId               = context.RequestData.ReadUInt64();
-            var            packedImageTransferProcessorConfig = context.RequestData.ReadStruct<PackedImageTransferProcessorConfig>();
+            IrCameraHandle irCameraHandle = context.RequestData.ReadStruct<IrCameraHandle>();
+            ulong appletResourceUserId = context.RequestData.ReadUInt64();
+            var packedImageTransferProcessorConfig = context.RequestData.ReadStruct<PackedImageTransferProcessorConfig>();
 
             CheckCameraHandle(irCameraHandle);
 
@@ -126,8 +126,8 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         // GetImageTransferProcessorState(pid, nn::irsensor::IrCameraHandle, nn::applet::AppletResourceUserId)
         public ResultCode GetImageTransferProcessorState(ServiceCtx context)
         {
-            IrCameraHandle irCameraHandle       = context.RequestData.ReadStruct<IrCameraHandle>();
-            ulong          appletResourceUserId = context.RequestData.ReadUInt64();
+            IrCameraHandle irCameraHandle = context.RequestData.ReadStruct<IrCameraHandle>();
+            ulong appletResourceUserId = context.RequestData.ReadUInt64();
 
             // ulong imageTransferBufferAddress = context.Request.ReceiveBuff[0].Position;
             ulong imageTransferBufferSize = context.Request.ReceiveBuff[0].Size;
@@ -144,8 +144,8 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
             // TODO: Uses the buffer to copy the JoyCon IR data (by using a JoyCon driver) and update the following struct.
             context.ResponseData.WriteStruct(new ImageTransferProcessorState()
             {
-                SamplingNumber    = 0,
-                AmbientNoiseLevel = 0
+                SamplingNumber = 0,
+                AmbientNoiseLevel = 0,
             });
 
             return ResultCode.Success;
@@ -155,9 +155,9 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         // RunTeraPluginProcessor(pid, nn::irsensor::IrCameraHandle, nn::applet::AppletResourceUserId, PackedTeraPluginProcessorConfig)
         public ResultCode RunTeraPluginProcessor(ServiceCtx context)
         {
-            IrCameraHandle irCameraHandle                  = context.RequestData.ReadStruct<IrCameraHandle>();
-            ulong          appletResourceUserId            = context.RequestData.ReadUInt64();
-            var            packedTeraPluginProcessorConfig = context.RequestData.ReadStruct<PackedTeraPluginProcessorConfig>();
+            IrCameraHandle irCameraHandle = context.RequestData.ReadStruct<IrCameraHandle>();
+            ulong appletResourceUserId = context.RequestData.ReadUInt64();
+            var packedTeraPluginProcessorConfig = context.RequestData.ReadStruct<PackedTeraPluginProcessorConfig>();
 
             CheckCameraHandle(irCameraHandle);
 
@@ -172,7 +172,7 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         {
             NpadIdType npadIdType = (NpadIdType)context.RequestData.ReadUInt32();
 
-            if (npadIdType >  NpadIdType.Player8 &&
+            if (npadIdType > NpadIdType.Player8 &&
                 npadIdType != NpadIdType.Unknown &&
                 npadIdType != NpadIdType.Handheld)
             {
@@ -193,10 +193,10 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         // CheckFirmwareVersion(nn::irsensor::IrCameraHandle, nn::irsensor::PackedMcuVersion, nn::applet::AppletResourceUserId, pid)
         public ResultCode CheckFirmwareVersion(ServiceCtx context)
         {
-            int   irCameraHandle        = context.RequestData.ReadInt32();
+            int irCameraHandle = context.RequestData.ReadInt32();
             short packedMcuVersionMajor = context.RequestData.ReadInt16();
             short packedMcuVersionMinor = context.RequestData.ReadInt16();
-            long  appletResourceUserId  = context.RequestData.ReadInt64();
+            long appletResourceUserId = context.RequestData.ReadInt64();
 
             Logger.Stub?.PrintStub(LogClass.ServiceIrs, new { appletResourceUserId, irCameraHandle, packedMcuVersionMajor, packedMcuVersionMinor });
 
@@ -207,7 +207,7 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         // StopImageProcessorAsync(nn::irsensor::IrCameraHandle, nn::applet::AppletResourceUserId, pid)
         public ResultCode StopImageProcessorAsync(ServiceCtx context)
         {
-            int  irCameraHandle       = context.RequestData.ReadInt32();
+            int irCameraHandle = context.RequestData.ReadInt32();
             long appletResourceUserId = context.RequestData.ReadInt64();
 
             Logger.Stub?.PrintStub(LogClass.ServiceIrs, new { appletResourceUserId, irCameraHandle });
@@ -220,7 +220,7 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs
         public ResultCode ActivateIrsensorWithFunctionLevel(ServiceCtx context)
         {
             long appletResourceUserId = context.RequestData.ReadInt64();
-            long packedFunctionLevel  = context.RequestData.ReadInt64();
+            long packedFunctionLevel = context.RequestData.ReadInt64();
 
             Logger.Stub?.PrintStub(LogClass.ServiceIrs, new { appletResourceUserId, packedFunctionLevel });
 
diff --git a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/IIrSensorSystemServer.cs b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/IIrSensorSystemServer.cs
index 99fcd541..ad78d4f1 100644
--- a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/IIrSensorSystemServer.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/IIrSensorSystemServer.cs
@@ -5,4 +5,4 @@
     {
         public IIrSensorSystemServer(ServiceCtx context) { }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/ResultCode.cs b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/ResultCode.cs
index 3afc03c2..322f9349 100644
--- a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/ResultCode.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/ResultCode.cs
@@ -2,14 +2,14 @@
 {
     public enum ResultCode
     {
-        ModuleId       = 205,
+        ModuleId = 205,
         ErrorCodeShift = 9,
 
         Success = 0,
 
         InvalidCameraHandle = (204 << ErrorCodeShift) | ModuleId,
-        InvalidBufferSize   = (207 << ErrorCodeShift) | ModuleId,
+        InvalidBufferSize = (207 << ErrorCodeShift) | ModuleId,
         HandlePointerIsNull = (212 << ErrorCodeShift) | ModuleId,
-        NpadIdOutOfRange    = (709 << ErrorCodeShift) | ModuleId
+        NpadIdOutOfRange = (709 << ErrorCodeShift) | ModuleId,
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/ImageTransferProcessorState.cs b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/ImageTransferProcessorState.cs
index 647aef64..7f28667c 100644
--- a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/ImageTransferProcessorState.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/ImageTransferProcessorState.cs
@@ -6,7 +6,7 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs.Types
     struct ImageTransferProcessorState
     {
         public ulong SamplingNumber;
-        public uint  AmbientNoiseLevel;
-        public uint  Reserved;
+        public uint AmbientNoiseLevel;
+        public uint Reserved;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/IrCameraHandle.cs b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/IrCameraHandle.cs
index 8ed7201e..282f9279 100644
--- a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/IrCameraHandle.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/IrCameraHandle.cs
@@ -5,8 +5,8 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs.Types
     [StructLayout(LayoutKind.Sequential, Size = 0x4)]
     struct IrCameraHandle
     {
-        public byte   PlayerNumber;
-        public byte   DeviceType;
+        public byte PlayerNumber;
+        public byte DeviceType;
         public ushort Reserved;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedClusteringProcessorConfig.cs b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedClusteringProcessorConfig.cs
index 735f7822..a65a1ba6 100644
--- a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedClusteringProcessorConfig.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedClusteringProcessorConfig.cs
@@ -5,21 +5,21 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs.Types
     [StructLayout(LayoutKind.Sequential, Size = 0x28)]
     struct PackedClusteringProcessorConfig
     {
-        public long   ExposureTime;
-        public byte   LightTarget;
-        public byte   Gain;
-        public byte   IsNegativeImageUsed;
-        public byte   Reserved1;
-        public uint   Reserved2;
+        public long ExposureTime;
+        public byte LightTarget;
+        public byte Gain;
+        public byte IsNegativeImageUsed;
+        public byte Reserved1;
+        public uint Reserved2;
         public ushort WindowOfInterestX;
         public ushort WindowOfInterestY;
         public ushort WindowOfInterestWidth;
         public ushort WindowOfInterestHeight;
-        public uint   RequiredMcuVersion;
-        public uint   ObjectPixelCountMin;
-        public uint   ObjectPixelCountMax;
-        public byte   ObjectIntensityMin;
-        public byte   IsExternalLightFilterEnabled;
+        public uint RequiredMcuVersion;
+        public uint ObjectPixelCountMin;
+        public uint ObjectPixelCountMax;
+        public byte ObjectIntensityMin;
+        public byte IsExternalLightFilterEnabled;
         public ushort Reserved3;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedImageTransferProcessorConfig.cs b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedImageTransferProcessorConfig.cs
index 094413e0..c97de27a 100644
--- a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedImageTransferProcessorConfig.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedImageTransferProcessorConfig.cs
@@ -5,15 +5,15 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs.Types
     [StructLayout(LayoutKind.Sequential, Size = 0x18)]
     struct PackedImageTransferProcessorConfig
     {
-        public long   ExposureTime;
-        public byte   LightTarget;
-        public byte   Gain;
-        public byte   IsNegativeImageUsed;
-        public byte   Reserved1;
-        public uint   Reserved2;
-        public uint   RequiredMcuVersion;
-        public byte   Format;
-        public byte   Reserved3;
+        public long ExposureTime;
+        public byte LightTarget;
+        public byte Gain;
+        public byte IsNegativeImageUsed;
+        public byte Reserved1;
+        public uint Reserved2;
+        public uint RequiredMcuVersion;
+        public byte Format;
+        public byte Reserved3;
         public ushort Reserved4;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedMomentProcessorConfig.cs b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedMomentProcessorConfig.cs
index a1b70b40..bbee2815 100644
--- a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedMomentProcessorConfig.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedMomentProcessorConfig.cs
@@ -5,19 +5,19 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs.Types
     [StructLayout(LayoutKind.Sequential, Size = 0x20)]
     struct PackedMomentProcessorConfig
     {
-        public long   ExposureTime;
-        public byte   LightTarget;
-        public byte   Gain;
-        public byte   IsNegativeImageUsed;
-        public byte   Reserved1;
-        public uint   Reserved2;
+        public long ExposureTime;
+        public byte LightTarget;
+        public byte Gain;
+        public byte IsNegativeImageUsed;
+        public byte Reserved1;
+        public uint Reserved2;
         public ushort WindowOfInterestX;
         public ushort WindowOfInterestY;
         public ushort WindowOfInterestWidth;
         public ushort WindowOfInterestHeight;
-        public uint   RequiredMcuVersion;
-        public byte   Preprocess;
-        public byte   PreprocessIntensityThreshold;
+        public uint RequiredMcuVersion;
+        public byte Preprocess;
+        public byte PreprocessIntensityThreshold;
         public ushort Reserved3;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedTeraPluginProcessorConfig.cs b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedTeraPluginProcessorConfig.cs
index 808b0b72..4fada04a 100644
--- a/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedTeraPluginProcessorConfig.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Hid/Irs/Types/PackedTeraPluginProcessorConfig.cs
@@ -11,4 +11,4 @@ namespace Ryujinx.HLE.HOS.Services.Hid.Irs.Types
         public byte Unknown2;
         public byte Unknown3;
     }
-}
\ No newline at end of file
+}