[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

5 files changed, 14 insertions, 14 deletions

diff --git a/src/Ryujinx.HLE/HOS/Services/Fatal/IPrivateService.cs b/src/Ryujinx.HLE/HOS/Services/Fatal/IPrivateService.cs
index eb2c9553..4cb3a2c1 100644
--- a/src/Ryujinx.HLE/HOS/Services/Fatal/IPrivateService.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Fatal/IPrivateService.cs
@@ -5,4 +5,4 @@
     {
         public IPrivateService(ServiceCtx context) { }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Fatal/IService.cs b/src/Ryujinx.HLE/HOS/Services/Fatal/IService.cs
index aaa5c873..a62d633e 100644
--- a/src/Ryujinx.HLE/HOS/Services/Fatal/IService.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Fatal/IService.cs
@@ -16,7 +16,7 @@ namespace Ryujinx.HLE.HOS.Services.Fatal
         public ResultCode ThrowFatal(ServiceCtx context)
         {
             ResultCode resultCode = (ResultCode)context.RequestData.ReadUInt64();
-            ulong      pid        = context.Request.HandleDesc.PId;
+            ulong pid = context.Request.HandleDesc.PId;
 
             return ThrowFatalWithCpuContextImpl(context, resultCode, pid, FatalPolicy.ErrorReportAndErrorScreen, null);
         }
@@ -25,9 +25,9 @@ namespace Ryujinx.HLE.HOS.Services.Fatal
         // ThrowFatalWithPolicy(u64 result_code, u32 fatal_policy, u64 pid)
         public ResultCode ThrowFatalWithPolicy(ServiceCtx context)
         {
-            ResultCode  resultCode  = (ResultCode)context.RequestData.ReadUInt64();
+            ResultCode resultCode = (ResultCode)context.RequestData.ReadUInt64();
             FatalPolicy fatalPolicy = (FatalPolicy)context.RequestData.ReadUInt32();
-            ulong       pid         = context.Request.HandleDesc.PId;
+            ulong pid = context.Request.HandleDesc.PId;
 
             return ThrowFatalWithCpuContextImpl(context, resultCode, pid, fatalPolicy, null);
         }
@@ -36,12 +36,12 @@ namespace Ryujinx.HLE.HOS.Services.Fatal
         // ThrowFatalWithCpuContext(u64 result_code, u32 fatal_policy, u64 pid, buffer<bytes, 0x15> cpu_context)
         public ResultCode ThrowFatalWithCpuContext(ServiceCtx context)
         {
-            ResultCode  resultCode  = (ResultCode)context.RequestData.ReadUInt64();
+            ResultCode resultCode = (ResultCode)context.RequestData.ReadUInt64();
             FatalPolicy fatalPolicy = (FatalPolicy)context.RequestData.ReadUInt32();
-            ulong       pid         = context.Request.HandleDesc.PId;
+            ulong pid = context.Request.HandleDesc.PId;
 
             ulong cpuContextPosition = context.Request.SendBuff[0].Position;
-            ulong cpuContextSize     = context.Request.SendBuff[0].Size;
+            ulong cpuContextSize = context.Request.SendBuff[0].Size;
 
             ReadOnlySpan<byte> cpuContextData = context.Memory.GetSpan(cpuContextPosition, (int)cpuContextSize);
 
@@ -50,7 +50,7 @@ namespace Ryujinx.HLE.HOS.Services.Fatal
 
         private ResultCode ThrowFatalWithCpuContextImpl(ServiceCtx context, ResultCode resultCode, ulong pid, FatalPolicy fatalPolicy, ReadOnlySpan<byte> cpuContext)
         {
-            StringBuilder errorReport = new StringBuilder();
+            StringBuilder errorReport = new();
 
             errorReport.AppendLine();
             errorReport.AppendLine("ErrorReport log:");
@@ -144,4 +144,4 @@ namespace Ryujinx.HLE.HOS.Services.Fatal
             return ResultCode.Success;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Fatal/Types/CpuContext32.cs b/src/Ryujinx.HLE/HOS/Services/Fatal/Types/CpuContext32.cs
index 5c0b116b..5eb1406a 100644
--- a/src/Ryujinx.HLE/HOS/Services/Fatal/Types/CpuContext32.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Fatal/Types/CpuContext32.cs
@@ -22,4 +22,4 @@ namespace Ryujinx.HLE.HOS.Services.Fatal.Types
         public uint StartAddress;
         public uint RegisterSetFlags;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Fatal/Types/CpuContext64.cs b/src/Ryujinx.HLE/HOS/Services/Fatal/Types/CpuContext64.cs
index 24829a78..58fd3c4a 100644
--- a/src/Ryujinx.HLE/HOS/Services/Fatal/Types/CpuContext64.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Fatal/Types/CpuContext64.cs
@@ -19,6 +19,6 @@ namespace Ryujinx.HLE.HOS.Services.Fatal.Types
         public Array32<ulong> StackTrace;
         public ulong StartAddress;
         public ulong RegisterSetFlags;
-        public uint  StackTraceSize;
+        public uint StackTraceSize;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Fatal/Types/FatalPolicy.cs b/src/Ryujinx.HLE/HOS/Services/Fatal/Types/FatalPolicy.cs
index fe55cf12..f536d17d 100644
--- a/src/Ryujinx.HLE/HOS/Services/Fatal/Types/FatalPolicy.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Fatal/Types/FatalPolicy.cs
@@ -4,6 +4,6 @@
     {
         ErrorReportAndErrorScreen,
         ErrorReport,
-        ErrorScreen
+        ErrorScreen,
     }
-}
\ No newline at end of file
+}