[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

4 files changed, 18 insertions, 19 deletions

diff --git a/src/Ryujinx.HLE/HOS/Services/Arp/ApplicationLaunchProperty.cs b/src/Ryujinx.HLE/HOS/Services/Arp/ApplicationLaunchProperty.cs
index 3e4eca0a..9c2b9d19 100644
--- a/src/Ryujinx.HLE/HOS/Services/Arp/ApplicationLaunchProperty.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Arp/ApplicationLaunchProperty.cs
@@ -5,10 +5,10 @@ namespace Ryujinx.HLE.HOS.Services.Arp
     class ApplicationLaunchProperty
     {
         public ulong TitleId;
-        public int   Version;
-        public byte  BaseGameStorageId;
-        public byte  UpdateGameStorageId;
-#pragma warning disable CS0649
+        public int Version;
+        public byte BaseGameStorageId;
+        public byte UpdateGameStorageId;
+#pragma warning disable CS0649 // Field is never assigned to
         public short Padding;
 #pragma warning restore CS0649
 
@@ -18,10 +18,10 @@ namespace Ryujinx.HLE.HOS.Services.Arp
             {
                 return new ApplicationLaunchProperty
                 {
-                    TitleId             = 0x00,
-                    Version             = 0x00,
-                    BaseGameStorageId   = (byte)StorageId.BuiltInSystem,
-                    UpdateGameStorageId = (byte)StorageId.None
+                    TitleId = 0x00,
+                    Version = 0x00,
+                    BaseGameStorageId = (byte)StorageId.BuiltInSystem,
+                    UpdateGameStorageId = (byte)StorageId.None,
                 };
             }
         }
@@ -33,11 +33,11 @@ namespace Ryujinx.HLE.HOS.Services.Arp
 
             return new ApplicationLaunchProperty
             {
-                TitleId             = context.Device.Processes.ActiveApplication.ProgramId,
-                Version             = 0x00,
-                BaseGameStorageId   = (byte)StorageId.BuiltInSystem,
-                UpdateGameStorageId = (byte)StorageId.None
+                TitleId = context.Device.Processes.ActiveApplication.ProgramId,
+                Version = 0x00,
+                BaseGameStorageId = (byte)StorageId.BuiltInSystem,
+                UpdateGameStorageId = (byte)StorageId.None,
             };
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Arp/IReader.cs b/src/Ryujinx.HLE/HOS/Services/Arp/IReader.cs
index 35a2de0c..90cba861 100644
--- a/src/Ryujinx.HLE/HOS/Services/Arp/IReader.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Arp/IReader.cs
@@ -5,4 +5,4 @@
     {
         public IReader(ServiceCtx context) { }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Arp/IWriter.cs b/src/Ryujinx.HLE/HOS/Services/Arp/IWriter.cs
index 8d13f0fb..7c3992c7 100644
--- a/src/Ryujinx.HLE/HOS/Services/Arp/IWriter.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Arp/IWriter.cs
@@ -5,4 +5,4 @@
     {
         public IWriter(ServiceCtx context) { }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.HLE/HOS/Services/Arp/LibHacIReader.cs b/src/Ryujinx.HLE/HOS/Services/Arp/LibHacIReader.cs
index d7686871..fdddb79e 100644
--- a/src/Ryujinx.HLE/HOS/Services/Arp/LibHacIReader.cs
+++ b/src/Ryujinx.HLE/HOS/Services/Arp/LibHacIReader.cs
@@ -3,7 +3,6 @@ using LibHac.Common;
 using LibHac.Ncm;
 using LibHac.Ns;
 using System;
-
 using ApplicationId = LibHac.ApplicationId;
 
 namespace Ryujinx.HLE.HOS.Services.Arp
@@ -17,7 +16,7 @@ namespace Ryujinx.HLE.HOS.Services.Arp
             launchProperty = new LibHac.Arp.ApplicationLaunchProperty
             {
                 StorageId = StorageId.BuiltInUser,
-                ApplicationId = ApplicationId
+                ApplicationId = ApplicationId,
             };
 
             return Result.Success;
@@ -30,7 +29,7 @@ namespace Ryujinx.HLE.HOS.Services.Arp
             launchProperty = new LibHac.Arp.ApplicationLaunchProperty
             {
                 StorageId = StorageId.BuiltInUser,
-                ApplicationId = applicationId
+                ApplicationId = applicationId,
             };
 
             return Result.Success;
@@ -73,4 +72,4 @@ namespace Ryujinx.HLE.HOS.Services.Arp
             return Result.Success;
         }
     }
-}
\ No newline at end of file
+}