[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

1 files changed, 14 insertions, 12 deletions

diff --git a/src/Ryujinx.HLE/HOS/Kernel/Memory/KPageHeap.cs b/src/Ryujinx.HLE/HOS/Kernel/Memory/KPageHeap.cs
index c3586ed7..635dcced 100644
--- a/src/Ryujinx.HLE/HOS/Kernel/Memory/KPageHeap.cs
+++ b/src/Ryujinx.HLE/HOS/Kernel/Memory/KPageHeap.cs
@@ -7,7 +7,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Memory
     {
         private class Block
         {
-            private KPageBitmap _bitmap = new KPageBitmap();
+            private readonly KPageBitmap _bitmap = new();
             private ulong _heapAddress;
             private ulong _endOffset;
 
@@ -29,8 +29,8 @@ namespace Ryujinx.HLE.HOS.Kernel.Memory
                     ? 1UL << nextBlockShift
                     : 1UL << blockShift;
 
-                address    = BitUtils.AlignDown(address,    align);
-                endAddress = BitUtils.AlignUp  (endAddress, align);
+                address = BitUtils.AlignDown(address, align);
+                endAddress = BitUtils.AlignUp(endAddress, align);
 
                 _heapAddress = address;
                 _endOffset = (endAddress - address) / (1UL << blockShift);
@@ -84,11 +84,13 @@ namespace Ryujinx.HLE.HOS.Kernel.Memory
             }
         }
 
-        private static readonly int[] _memoryBlockPageShifts = new int[] { 12, 16, 21, 22, 25, 29, 30 };
+        private static readonly int[] _memoryBlockPageShifts = { 12, 16, 21, 22, 25, 29, 30 };
 
+#pragma warning disable IDE0052 // Remove unread private member
         private readonly ulong _heapAddress;
         private readonly ulong _heapSize;
         private ulong _usedSize;
+#pragma warning restore IDE0052
         private readonly int _blocksCount;
         private readonly Block[] _blocks;
 
@@ -175,19 +177,19 @@ namespace Ryujinx.HLE.HOS.Kernel.Memory
 
             int bigIndex = _blocksCount - 1;
 
-            ulong start       = address;
-            ulong end         = address + pagesCount * KPageTableBase.PageSize;
+            ulong start = address;
+            ulong end = address + pagesCount * KPageTableBase.PageSize;
             ulong beforeStart = start;
-            ulong beforeEnd   = start;
-            ulong afterStart  = end;
-            ulong afterEnd    = end;
+            ulong beforeEnd = start;
+            ulong afterStart = end;
+            ulong afterEnd = end;
 
             while (bigIndex >= 0)
             {
                 ulong blockSize = _blocks[bigIndex].Size;
 
-                ulong bigStart = BitUtils.AlignUp  (start, blockSize);
-                ulong bigEnd   = BitUtils.AlignDown(end,   blockSize);
+                ulong bigStart = BitUtils.AlignUp(start, blockSize);
+                ulong bigEnd = BitUtils.AlignDown(end, blockSize);
 
                 if (bigStart < bigEnd)
                 {
@@ -196,7 +198,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Memory
                         FreeBlock(block, bigIndex);
                     }
 
-                    beforeEnd  = bigStart;
+                    beforeEnd = bigStart;
                     afterStart = bigEnd;
 
                     break;