aboutsummaryrefslogtreecommitdiff
path: root/src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Declarations.cs
diff options
context:
space:
mode:
authorgdkchan <gab.dark.100@gmail.com>2024-04-07 18:25:55 -0300
committerGitHub <noreply@github.com>2024-04-07 18:25:55 -0300
commit3e6e0e4afaa3c3ffb118cb17b61feb16966a7eeb (patch)
treea4652499c089b0853e39c382cad82a9db4d6ad08 /src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Declarations.cs
parent808803d97a0c06809bf000687c252f960048fcf0 (diff)
Add support for large sampler arrays on Vulkan (#6489)
* Add support for large sampler arrays on Vulkan * Shader cache version bump * Format whitespace * Move DescriptorSetManager to PipelineLayoutCacheEntry to allow different pool sizes per layout * Handle array textures with different types on the same buffer * Somewhat better caching system * Avoid useless buffer data modification checks * Move redundant bindings update checking to the backend * Fix an issue where texture arrays would get the same bindings across stages on Vulkan * Backport some fixes from part 2 * Fix typo * PR feedback * Format whitespace * Add some missing XML docs
Diffstat (limited to 'src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Declarations.cs')
-rw-r--r--src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Declarations.cs46
1 files changed, 16 insertions, 30 deletions
diff --git a/src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Declarations.cs b/src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Declarations.cs
index 500de71f..763487da 100644
--- a/src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Declarations.cs
+++ b/src/Ryujinx.Graphics.Shader/CodeGen/Glsl/Declarations.cs
@@ -339,24 +339,17 @@ namespace Ryujinx.Graphics.Shader.CodeGen.Glsl
private static void DeclareSamplers(CodeGenContext context, IEnumerable<TextureDefinition> definitions)
{
- int arraySize = 0;
-
foreach (var definition in definitions)
{
- string indexExpr = string.Empty;
+ string arrayDecl = string.Empty;
- if (definition.Type.HasFlag(SamplerType.Indexed))
+ if (definition.ArrayLength > 1)
{
- if (arraySize == 0)
- {
- arraySize = ResourceManager.SamplerArraySize;
- }
- else if (--arraySize != 0)
- {
- continue;
- }
-
- indexExpr = $"[{NumberFormatter.FormatInt(arraySize)}]";
+ arrayDecl = $"[{NumberFormatter.FormatInt(definition.ArrayLength)}]";
+ }
+ else if (definition.ArrayLength == 0)
+ {
+ arrayDecl = "[]";
}
string samplerTypeName = definition.Type.ToGlslSamplerType();
@@ -368,30 +361,23 @@ namespace Ryujinx.Graphics.Shader.CodeGen.Glsl
layout = $", set = {definition.Set}";
}
- context.AppendLine($"layout (binding = {definition.Binding}{layout}) uniform {samplerTypeName} {definition.Name}{indexExpr};");
+ context.AppendLine($"layout (binding = {definition.Binding}{layout}) uniform {samplerTypeName} {definition.Name}{arrayDecl};");
}
}
private static void DeclareImages(CodeGenContext context, IEnumerable<TextureDefinition> definitions)
{
- int arraySize = 0;
-
foreach (var definition in definitions)
{
- string indexExpr = string.Empty;
+ string arrayDecl = string.Empty;
- if (definition.Type.HasFlag(SamplerType.Indexed))
+ if (definition.ArrayLength > 1)
{
- if (arraySize == 0)
- {
- arraySize = ResourceManager.SamplerArraySize;
- }
- else if (--arraySize != 0)
- {
- continue;
- }
-
- indexExpr = $"[{NumberFormatter.FormatInt(arraySize)}]";
+ arrayDecl = $"[{NumberFormatter.FormatInt(definition.ArrayLength)}]";
+ }
+ else if (definition.ArrayLength == 0)
+ {
+ arrayDecl = "[]";
}
string imageTypeName = definition.Type.ToGlslImageType(definition.Format.GetComponentType());
@@ -413,7 +399,7 @@ namespace Ryujinx.Graphics.Shader.CodeGen.Glsl
layout = $", set = {definition.Set}{layout}";
}
- context.AppendLine($"layout (binding = {definition.Binding}{layout}) uniform {imageTypeName} {definition.Name}{indexExpr};");
+ context.AppendLine($"layout (binding = {definition.Binding}{layout}) uniform {imageTypeName} {definition.Name}{arrayDecl};");
}
}