diff options
| author | jhorv <38920027+jhorv@users.noreply.github.com> | 2024-04-14 16:06:14 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-14 17:06:14 -0300 |
| commit | 268c9aecf8e9181bb7114cf1dd826f00b2237714 (patch) | |
| tree | 7e14ab6cde7c7edaf99bd2151abfb73d5b00f103 /src/Ryujinx.Graphics.GAL/ITexture.cs | |
| parent | e916662b0f17b93d8987d481784cd45073335990 (diff) | |
Texture loading: reduce memory allocations (#6623)
* rebase
* add methods Ryyjinx.Common EmbeddedResources and SteamUtils
* GAL changes - change SetData() methods and ThreadedTexture commands to use IMemoryOwner<byte> instead of SpanOrArray<byte>
* Ryujinx.Graphics.Texture: change texture conversion methods to return IMemoryOwner<byte> and allocate from ByteMemoryPool
* Ryujinx.Graphics.OpenGL: update ITexture and Texture-like types with SetData() methods to take IMemoryOwner<byte> instead of SpanOrArray<byte>
* Ryujinx.Graphics.Vulkan: update ITexture and Texture-like types with SetData() methods to take IMemoryOwner<byte> instead of SpanOrArray<byte>
* Ryujinx.Graphics.Gpu: update ITexture and Texture-like types with SetData() methods to take IMemoryOwner<byte> instead of SpanOrArray<byte>
* Remove now-unused SpanOrArray<T>
* post-rebase cleanup
* PixelConverter: remove unsafe modifier on safe methods, and remove one unnecessary cast
* use ByteMemoryPool.Rent() in GetWritableRegion() impls
* fix formatting, rename `ReadRentedMemory()` to `ReadFileToRentedMemory()``
* Texture.ConvertToHostCompatibleFormat(): dispose of `result` in Astc decode branch
Diffstat (limited to 'src/Ryujinx.Graphics.GAL/ITexture.cs')
| -rw-r--r-- | src/Ryujinx.Graphics.GAL/ITexture.cs | 32 |
1 files changed, 28 insertions, 4 deletions
diff --git a/src/Ryujinx.Graphics.GAL/ITexture.cs b/src/Ryujinx.Graphics.GAL/ITexture.cs index 5a4623a6..2d9c6b79 100644 --- a/src/Ryujinx.Graphics.GAL/ITexture.cs +++ b/src/Ryujinx.Graphics.GAL/ITexture.cs @@ -1,4 +1,4 @@ -using Ryujinx.Common.Memory; +using System.Buffers; namespace Ryujinx.Graphics.GAL { @@ -17,10 +17,34 @@ namespace Ryujinx.Graphics.GAL PinnedSpan<byte> GetData(); PinnedSpan<byte> GetData(int layer, int level); - void SetData(SpanOrArray<byte> data); - void SetData(SpanOrArray<byte> data, int layer, int level); - void SetData(SpanOrArray<byte> data, int layer, int level, Rectangle<int> region); + /// <summary> + /// Sets the texture data. The data passed as a <see cref="IMemoryOwner{Byte}" /> will be disposed when + /// the operation completes. + /// </summary> + /// <param name="data">Texture data bytes</param> + void SetData(IMemoryOwner<byte> data); + + /// <summary> + /// Sets the texture data. The data passed as a <see cref="IMemoryOwner{Byte}" /> will be disposed when + /// the operation completes. + /// </summary> + /// <param name="data">Texture data bytes</param> + /// <param name="layer">Target layer</param> + /// <param name="level">Target level</param> + void SetData(IMemoryOwner<byte> data, int layer, int level); + + /// <summary> + /// Sets the texture data. The data passed as a <see cref="IMemoryOwner{Byte}" /> will be disposed when + /// the operation completes. + /// </summary> + /// <param name="data">Texture data bytes</param> + /// <param name="layer">Target layer</param> + /// <param name="level">Target level</param> + /// <param name="region">Target sub-region of the texture to update</param> + void SetData(IMemoryOwner<byte> data, int layer, int level, Rectangle<int> region); + void SetStorage(BufferRange buffer); + void Release(); } } |
