[Ryujinx.Audio] Address dotnet-format issues (#5362)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Format if-blocks correctly

* Run dotnet format whitespace after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Add comments to disabled warnings

* Remove a few unused parameters

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Address IDE0251 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* Fix naming rule violations, remove redundant code and fix build issues

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Add trailing commas

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Address review feedback

---------

Co-authored-by: Ac_K <Acoustik666@gmail.com>

3 files changed, 11 insertions, 11 deletions

diff --git a/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerBufferState.cs b/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerBufferState.cs
index a45fa8e5..a3c442a4 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerBufferState.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerBufferState.cs
@@ -11,4 +11,4 @@ namespace Ryujinx.Audio.Renderer.Server.Upsampler
         public bool Initialized;
         public int Phase;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerManager.cs b/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerManager.cs
index 0fee0000..dbc2c9b3 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerManager.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerManager.cs
@@ -11,22 +11,22 @@ namespace Ryujinx.Audio.Renderer.Server.Upsampler
         /// <summary>
         /// Work buffer for upsampler.
         /// </summary>
-        private Memory<float> _upSamplerWorkBuffer;
+        private readonly Memory<float> _upSamplerWorkBuffer;
 
         /// <summary>
         /// Global lock of the object.
         /// </summary>
-        private readonly object Lock = new();
+        private readonly object _lock = new();
 
         /// <summary>
         /// The upsamplers instances.
         /// </summary>
-        private UpsamplerState[] _upsamplers;
+        private readonly UpsamplerState[] _upsamplers;
 
         /// <summary>
         /// The count of upsamplers.
         /// </summary>
-        private uint _count;
+        private readonly uint _count;
 
         /// <summary>
         /// Create a new <see cref="UpsamplerManager"/>.
@@ -49,7 +49,7 @@ namespace Ryujinx.Audio.Renderer.Server.Upsampler
         {
             int workBufferOffset = 0;
 
-            lock (Lock)
+            lock (_lock)
             {
                 for (int i = 0; i < _count; i++)
                 {
@@ -73,7 +73,7 @@ namespace Ryujinx.Audio.Renderer.Server.Upsampler
         /// <param name="index">The index of the <see cref="UpsamplerState"/> to free.</param>
         public void Free(int index)
         {
-            lock (Lock)
+            lock (_lock)
             {
                 Debug.Assert(_upsamplers[index] != null);
 
@@ -81,4 +81,4 @@ namespace Ryujinx.Audio.Renderer.Server.Upsampler
             }
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerState.cs b/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerState.cs
index e508f35b..39a58c91 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerState.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Upsampler/UpsamplerState.cs
@@ -20,12 +20,12 @@ namespace Ryujinx.Audio.Renderer.Server.Upsampler
         /// <summary>
         /// The index of the <see cref="UpsamplerState"/>. (used to free it)
         /// </summary>
-        private int _index;
+        private readonly int _index;
 
         /// <summary>
         /// The <see cref="UpsamplerManager"/>.
         /// </summary>
-        private UpsamplerManager _manager;
+        private readonly UpsamplerManager _manager;
 
         /// <summary>
         /// The source sample count.
@@ -65,4 +65,4 @@ namespace Ryujinx.Audio.Renderer.Server.Upsampler
             _manager.Free(_index);
         }
     }
-}
\ No newline at end of file
+}