[Ryujinx.Audio] Address dotnet-format issues (#5362)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Format if-blocks correctly

* Run dotnet format whitespace after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Add comments to disabled warnings

* Remove a few unused parameters

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Address IDE0251 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* Fix naming rule violations, remove redundant code and fix build issues

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Add trailing commas

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Address review feedback

---------

Co-authored-by: Ac_K <Acoustik666@gmail.com>

11 files changed, 25 insertions, 35 deletions

diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/AuxiliaryBufferEffect.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/AuxiliaryBufferEffect.cs
index 16406527..57ca266f 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/AuxiliaryBufferEffect.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/AuxiliaryBufferEffect.cs
@@ -58,7 +58,7 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             {
                 ulong bufferSize = (ulong)Unsafe.SizeOf<int>() * Parameter.BufferStorageSize + (ulong)Unsafe.SizeOf<AuxiliaryBufferHeader>();
 
-                bool sendBufferUnmapped = !mapper.TryAttachBuffer(out updateErrorInfo, ref WorkBuffers[0], Parameter.SendBufferInfoAddress, bufferSize);
+                bool sendBufferUnmapped = !mapper.TryAttachBuffer(out _, ref WorkBuffers[0], Parameter.SendBufferInfoAddress, bufferSize);
                 bool returnBufferUnmapped = !mapper.TryAttachBuffer(out updateErrorInfo, ref WorkBuffers[1], Parameter.ReturnBufferInfoAddress, bufferSize);
 
                 BufferUnmapped = sendBufferUnmapped && returnBufferUnmapped;
@@ -82,4 +82,4 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             UpdateUsageStateForCommandGeneration();
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/BaseEffect.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/BaseEffect.cs
index 825b3bf7..a9716db2 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/BaseEffect.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/BaseEffect.cs
@@ -244,29 +244,19 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
         /// <returns>The <see cref="PerformanceDetailType"/> associated to the <see cref="Type"/> of this effect.</returns>
         public PerformanceDetailType GetPerformanceDetailType()
         {
-            switch (Type)
+            return Type switch
             {
-                case EffectType.BiquadFilter:
-                    return PerformanceDetailType.BiquadFilter;
-                case EffectType.AuxiliaryBuffer:
-                    return PerformanceDetailType.Aux;
-                case EffectType.Delay:
-                    return PerformanceDetailType.Delay;
-                case EffectType.Reverb:
-                    return PerformanceDetailType.Reverb;
-                case EffectType.Reverb3d:
-                    return PerformanceDetailType.Reverb3d;
-                case EffectType.BufferMix:
-                    return PerformanceDetailType.Mix;
-                case EffectType.Limiter:
-                    return PerformanceDetailType.Limiter;
-                case EffectType.CaptureBuffer:
-                    return PerformanceDetailType.CaptureBuffer;
-                case EffectType.Compressor:
-                    return PerformanceDetailType.Compressor;
-                default:
-                    throw new NotImplementedException($"{Type}");
-            }
+                EffectType.BiquadFilter => PerformanceDetailType.BiquadFilter,
+                EffectType.AuxiliaryBuffer => PerformanceDetailType.Aux,
+                EffectType.Delay => PerformanceDetailType.Delay,
+                EffectType.Reverb => PerformanceDetailType.Reverb,
+                EffectType.Reverb3d => PerformanceDetailType.Reverb3d,
+                EffectType.BufferMix => PerformanceDetailType.Mix,
+                EffectType.Limiter => PerformanceDetailType.Limiter,
+                EffectType.CaptureBuffer => PerformanceDetailType.CaptureBuffer,
+                EffectType.Compressor => PerformanceDetailType.Compressor,
+                _ => throw new NotImplementedException($"{Type}"),
+            };
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/BiquadFilterEffect.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/BiquadFilterEffect.cs
index de91046d..b987f7c8 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/BiquadFilterEffect.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/BiquadFilterEffect.cs
@@ -64,4 +64,4 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             Parameter.Status = UsageState.Enabled;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/BufferMixEffect.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/BufferMixEffect.cs
index 82c0a055..d6cb9cfa 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/BufferMixEffect.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/BufferMixEffect.cs
@@ -46,4 +46,4 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             UpdateUsageStateForCommandGeneration();
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/CaptureBufferEffect.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/CaptureBufferEffect.cs
index c445798d..5be4b4ed 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/CaptureBufferEffect.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/CaptureBufferEffect.cs
@@ -79,4 +79,4 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             UpdateUsageStateForCommandGeneration();
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/DelayEffect.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/DelayEffect.cs
index 3f5d70bc..43cabb7d 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/DelayEffect.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/DelayEffect.cs
@@ -90,4 +90,4 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             Parameter.Status = UsageState.Enabled;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/EffectContext.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/EffectContext.cs
index bfb6528b..619f3110 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/EffectContext.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/EffectContext.cs
@@ -120,4 +120,4 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             }
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/LimiterEffect.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/LimiterEffect.cs
index 6e17ef3d..3e2f7326 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/LimiterEffect.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/LimiterEffect.cs
@@ -92,4 +92,4 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             destState = srcState;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/Reverb3dEffect.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/Reverb3dEffect.cs
index 473fddb8..f9d7f494 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/Reverb3dEffect.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/Reverb3dEffect.cs
@@ -89,4 +89,4 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             Parameter.ParameterStatus = UsageState.Enabled;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/ReverbEffect.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/ReverbEffect.cs
index e1543fd1..6fdf8fc2 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/ReverbEffect.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/ReverbEffect.cs
@@ -92,4 +92,4 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
             Parameter.Status = UsageState.Enabled;
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Server/Effect/UsageState.cs b/src/Ryujinx.Audio/Renderer/Server/Effect/UsageState.cs
index 8648aa2c..da717224 100644
--- a/src/Ryujinx.Audio/Renderer/Server/Effect/UsageState.cs
+++ b/src/Ryujinx.Audio/Renderer/Server/Effect/UsageState.cs
@@ -23,6 +23,6 @@ namespace Ryujinx.Audio.Renderer.Server.Effect
         /// <summary>
         /// The effect is disabled.
         /// </summary>
-        Disabled
+        Disabled,
     }
-}
\ No newline at end of file
+}