[Ryujinx.Audio] Address dotnet-format issues (#5362)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Format if-blocks correctly

* Run dotnet format whitespace after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Add comments to disabled warnings

* Remove a few unused parameters

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Address IDE0251 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* Fix naming rule violations, remove redundant code and fix build issues

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Add trailing commas

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Address review feedback

---------

Co-authored-by: Ac_K <Acoustik666@gmail.com>

9 files changed, 21 insertions, 21 deletions

diff --git a/src/Ryujinx.Audio/Renderer/Parameter/Effect/AuxiliaryBufferParameter.cs b/src/Ryujinx.Audio/Renderer/Parameter/Effect/AuxiliaryBufferParameter.cs
index 36f28677..65f265a3 100644
--- a/src/Ryujinx.Audio/Renderer/Parameter/Effect/AuxiliaryBufferParameter.cs
+++ b/src/Ryujinx.Audio/Renderer/Parameter/Effect/AuxiliaryBufferParameter.cs
@@ -81,4 +81,4 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// <remarks>This is unused.</remarks>
         public uint MixBufferSampleCount;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Parameter/Effect/BiquadFilterEffectParameter.cs b/src/Ryujinx.Audio/Renderer/Parameter/Effect/BiquadFilterEffectParameter.cs
index 73e0e9bb..b12a941a 100644
--- a/src/Ryujinx.Audio/Renderer/Parameter/Effect/BiquadFilterEffectParameter.cs
+++ b/src/Ryujinx.Audio/Renderer/Parameter/Effect/BiquadFilterEffectParameter.cs
@@ -41,4 +41,4 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// </summary>
         public UsageState Status;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Parameter/Effect/BufferMixerParameter.cs b/src/Ryujinx.Audio/Renderer/Parameter/Effect/BufferMixerParameter.cs
index b03559eb..49b70e50 100644
--- a/src/Ryujinx.Audio/Renderer/Parameter/Effect/BufferMixerParameter.cs
+++ b/src/Ryujinx.Audio/Renderer/Parameter/Effect/BufferMixerParameter.cs
@@ -29,4 +29,4 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// </summary>
         public uint MixesCount;
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Parameter/Effect/CompressorParameter.cs b/src/Ryujinx.Audio/Renderer/Parameter/Effect/CompressorParameter.cs
index 0be37608..1a936b0d 100644
--- a/src/Ryujinx.Audio/Renderer/Parameter/Effect/CompressorParameter.cs
+++ b/src/Ryujinx.Audio/Renderer/Parameter/Effect/CompressorParameter.cs
@@ -98,7 +98,7 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// Check if the <see cref="ChannelCount"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCount"/> is valid.</returns>
-        public bool IsChannelCountValid()
+        public readonly bool IsChannelCountValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCount);
         }
@@ -107,7 +107,7 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// Check if the <see cref="ChannelCountMax"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCountMax"/> is valid.</returns>
-        public bool IsChannelCountMaxValid()
+        public readonly bool IsChannelCountMaxValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCountMax);
         }
diff --git a/src/Ryujinx.Audio/Renderer/Parameter/Effect/DelayParameter.cs b/src/Ryujinx.Audio/Renderer/Parameter/Effect/DelayParameter.cs
index 72332c17..99c97d9d 100644
--- a/src/Ryujinx.Audio/Renderer/Parameter/Effect/DelayParameter.cs
+++ b/src/Ryujinx.Audio/Renderer/Parameter/Effect/DelayParameter.cs
@@ -84,7 +84,7 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// Check if the <see cref="ChannelCount"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCount"/> is valid.</returns>
-        public bool IsChannelCountValid()
+        public readonly bool IsChannelCountValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCount);
         }
@@ -93,9 +93,9 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// Check if the <see cref="ChannelCountMax"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCountMax"/> is valid.</returns>
-        public bool IsChannelCountMaxValid()
+        public readonly bool IsChannelCountMaxValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCountMax);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Parameter/Effect/LimiterParameter.cs b/src/Ryujinx.Audio/Renderer/Parameter/Effect/LimiterParameter.cs
index 0bce94a2..23ccb8c8 100644
--- a/src/Ryujinx.Audio/Renderer/Parameter/Effect/LimiterParameter.cs
+++ b/src/Ryujinx.Audio/Renderer/Parameter/Effect/LimiterParameter.cs
@@ -115,13 +115,13 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// <summary>
         /// Reserved/padding.
         /// </summary>
-        private byte _reserved;
+        private readonly byte _reserved;
 
         /// <summary>
         /// Check if the <see cref="ChannelCount"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCount"/> is valid.</returns>
-        public bool IsChannelCountValid()
+        public readonly bool IsChannelCountValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCount);
         }
@@ -130,9 +130,9 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// Check if the <see cref="ChannelCountMax"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCountMax"/> is valid.</returns>
-        public bool IsChannelCountMaxValid()
+        public readonly bool IsChannelCountMaxValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCountMax);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Parameter/Effect/LimiterStatistics.cs b/src/Ryujinx.Audio/Renderer/Parameter/Effect/LimiterStatistics.cs
index f353f18d..97e2f39f 100644
--- a/src/Ryujinx.Audio/Renderer/Parameter/Effect/LimiterStatistics.cs
+++ b/src/Ryujinx.Audio/Renderer/Parameter/Effect/LimiterStatistics.cs
@@ -24,8 +24,8 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// </summary>
         public void Reset()
         {
-            InputMax.AsSpan().Fill(0.0f);
+            InputMax.AsSpan().Clear();
             CompressionGainMin.AsSpan().Fill(1.0f);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Parameter/Effect/Reverb3dParameter.cs b/src/Ryujinx.Audio/Renderer/Parameter/Effect/Reverb3dParameter.cs
index c78ce595..d2cd7870 100644
--- a/src/Ryujinx.Audio/Renderer/Parameter/Effect/Reverb3dParameter.cs
+++ b/src/Ryujinx.Audio/Renderer/Parameter/Effect/Reverb3dParameter.cs
@@ -33,7 +33,7 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// <summary>
         /// Reserved/unused.
         /// </summary>
-        private uint _reserved;
+        private readonly uint _reserved;
 
         /// <summary>
         /// The target sample rate.
@@ -110,7 +110,7 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// Check if the <see cref="ChannelCount"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCount"/> is valid.</returns>
-        public bool IsChannelCountValid()
+        public readonly bool IsChannelCountValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCount);
         }
@@ -119,9 +119,9 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// Check if the <see cref="ChannelCountMax"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCountMax"/> is valid.</returns>
-        public bool IsChannelCountMaxValid()
+        public readonly bool IsChannelCountMaxValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCountMax);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Parameter/Effect/ReverbParameter.cs b/src/Ryujinx.Audio/Renderer/Parameter/Effect/ReverbParameter.cs
index baf049fb..51ab156d 100644
--- a/src/Ryujinx.Audio/Renderer/Parameter/Effect/ReverbParameter.cs
+++ b/src/Ryujinx.Audio/Renderer/Parameter/Effect/ReverbParameter.cs
@@ -102,7 +102,7 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// Check if the <see cref="ChannelCount"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCount"/> is valid.</returns>
-        public bool IsChannelCountValid()
+        public readonly bool IsChannelCountValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCount);
         }
@@ -111,9 +111,9 @@ namespace Ryujinx.Audio.Renderer.Parameter.Effect
         /// Check if the <see cref="ChannelCountMax"/> is valid.
         /// </summary>
         /// <returns>Returns true if the <see cref="ChannelCountMax"/> is valid.</returns>
-        public bool IsChannelCountMaxValid()
+        public readonly bool IsChannelCountMaxValid()
         {
             return EffectInParameterVersion1.IsChannelCountValid(ChannelCountMax);
         }
     }
-}
\ No newline at end of file
+}