[Ryujinx.Audio] Address dotnet-format issues (#5362)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Format if-blocks correctly

* Run dotnet format whitespace after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Add comments to disabled warnings

* Remove a few unused parameters

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Address IDE0251 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* Fix naming rule violations, remove redundant code and fix build issues

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Add trailing commas

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Address review feedback

---------

Co-authored-by: Ac_K <Acoustik666@gmail.com>

1 files changed, 20 insertions, 20 deletions

diff --git a/src/Ryujinx.Audio/Renderer/Dsp/UpsamplerHelper.cs b/src/Ryujinx.Audio/Renderer/Dsp/UpsamplerHelper.cs
index 54a63ace..5732cdb2 100644
--- a/src/Ryujinx.Audio/Renderer/Dsp/UpsamplerHelper.cs
+++ b/src/Ryujinx.Audio/Renderer/Dsp/UpsamplerHelper.cs
@@ -13,11 +13,11 @@ namespace Ryujinx.Audio.Renderer.Dsp
         private const int FilterBankLength = 20;
         // Bank0 = [0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0];
         private const int Bank0CenterIndex = 9;
-        private static readonly Array20<float> Bank1 = PrecomputeFilterBank(1.0f / 6.0f);
-        private static readonly Array20<float> Bank2 = PrecomputeFilterBank(2.0f / 6.0f);
-        private static readonly Array20<float> Bank3 = PrecomputeFilterBank(3.0f / 6.0f);
-        private static readonly Array20<float> Bank4 = PrecomputeFilterBank(4.0f / 6.0f);
-        private static readonly Array20<float> Bank5 = PrecomputeFilterBank(5.0f / 6.0f);
+        private static readonly Array20<float> _bank1 = PrecomputeFilterBank(1.0f / 6.0f);
+        private static readonly Array20<float> _bank2 = PrecomputeFilterBank(2.0f / 6.0f);
+        private static readonly Array20<float> _bank3 = PrecomputeFilterBank(3.0f / 6.0f);
+        private static readonly Array20<float> _bank4 = PrecomputeFilterBank(4.0f / 6.0f);
+        private static readonly Array20<float> _bank5 = PrecomputeFilterBank(5.0f / 6.0f);
 
         private static Array20<float> PrecomputeFilterBank(float offset)
         {
@@ -39,7 +39,7 @@ namespace Ryujinx.Audio.Renderer.Dsp
                 return A0 + A1 * MathF.Cos(2 * MathF.PI * x) + A2 * MathF.Cos(4 * MathF.PI * x);
             }
 
-            Array20<float> result = new Array20<float>();
+            Array20<float> result = new();
 
             for (int i = 0; i < FilterBankLength; i++)
             {
@@ -58,10 +58,10 @@ namespace Ryujinx.Audio.Renderer.Dsp
             {
                 state.Scale = inputSampleCount switch
                 {
-                    40  => 6.0f,
-                    80  => 3.0f,
+                    40 => 6.0f,
+                    80 => 3.0f,
                     160 => 1.5f,
-                    _   => throw new ArgumentOutOfRangeException()
+                    _ => throw new ArgumentOutOfRangeException(nameof(inputSampleCount), inputSampleCount, null),
                 };
                 state.Initialized = true;
             }
@@ -105,7 +105,7 @@ namespace Ryujinx.Audio.Renderer.Dsp
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
             void NextInput(ref UpsamplerBufferState state, float input)
             {
-                state.History.AsSpan().Slice(1).CopyTo(state.History.AsSpan());
+                state.History.AsSpan()[1..].CopyTo(state.History.AsSpan());
                 state.History[HistoryLength - 1] = input;
             }
 
@@ -123,19 +123,19 @@ namespace Ryujinx.Audio.Renderer.Dsp
                                 outputBuffer[i] = state.History[Bank0CenterIndex];
                                 break;
                             case 1:
-                                outputBuffer[i] = DoFilterBank(ref state, Bank1);
+                                outputBuffer[i] = DoFilterBank(ref state, _bank1);
                                 break;
                             case 2:
-                                outputBuffer[i] = DoFilterBank(ref state, Bank2);
+                                outputBuffer[i] = DoFilterBank(ref state, _bank2);
                                 break;
                             case 3:
-                                outputBuffer[i] = DoFilterBank(ref state, Bank3);
+                                outputBuffer[i] = DoFilterBank(ref state, _bank3);
                                 break;
                             case 4:
-                                outputBuffer[i] = DoFilterBank(ref state, Bank4);
+                                outputBuffer[i] = DoFilterBank(ref state, _bank4);
                                 break;
                             case 5:
-                                outputBuffer[i] = DoFilterBank(ref state, Bank5);
+                                outputBuffer[i] = DoFilterBank(ref state, _bank5);
                                 break;
                         }
 
@@ -152,10 +152,10 @@ namespace Ryujinx.Audio.Renderer.Dsp
                                 outputBuffer[i] = state.History[Bank0CenterIndex];
                                 break;
                             case 1:
-                                outputBuffer[i] = DoFilterBank(ref state, Bank2);
+                                outputBuffer[i] = DoFilterBank(ref state, _bank2);
                                 break;
                             case 2:
-                                outputBuffer[i] = DoFilterBank(ref state, Bank4);
+                                outputBuffer[i] = DoFilterBank(ref state, _bank4);
                                 break;
                         }
 
@@ -173,11 +173,11 @@ namespace Ryujinx.Audio.Renderer.Dsp
                                 outputBuffer[i] = state.History[Bank0CenterIndex];
                                 break;
                             case 1:
-                                outputBuffer[i] = DoFilterBank(ref state, Bank4);
+                                outputBuffer[i] = DoFilterBank(ref state, _bank4);
                                 break;
                             case 2:
                                 NextInput(ref state, inputBuffer[inputBufferIndex++]);
-                                outputBuffer[i] = DoFilterBank(ref state, Bank2);
+                                outputBuffer[i] = DoFilterBank(ref state, _bank2);
                                 break;
                         }
 
@@ -185,7 +185,7 @@ namespace Ryujinx.Audio.Renderer.Dsp
                     }
                     break;
                 default:
-                    throw new ArgumentOutOfRangeException();
+                    throw new ArgumentOutOfRangeException(nameof(state), state.Scale, null);
             }
         }
     }