[Ryujinx.Audio] Address dotnet-format issues (#5362)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Format if-blocks correctly

* Run dotnet format whitespace after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Add comments to disabled warnings

* Remove a few unused parameters

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Address IDE0251 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* Fix naming rule violations, remove redundant code and fix build issues

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Add trailing commas

* Apply suggestions from code review

Co-authored-by: Ac_K <Acoustik666@gmail.com>

* Address review feedback

---------

Co-authored-by: Ac_K <Acoustik666@gmail.com>

5 files changed, 10 insertions, 12 deletions

diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Effect/DecayDelay.cs b/src/Ryujinx.Audio/Renderer/Dsp/Effect/DecayDelay.cs
index 37e066bf..7253fdc9 100644
--- a/src/Ryujinx.Audio/Renderer/Dsp/Effect/DecayDelay.cs
+++ b/src/Ryujinx.Audio/Renderer/Dsp/Effect/DecayDelay.cs
@@ -49,4 +49,4 @@ namespace Ryujinx.Audio.Renderer.Dsp.Effect
             return _delayLine.Tap(sampleIndex);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Effect/DelayLine.cs b/src/Ryujinx.Audio/Renderer/Dsp/Effect/DelayLine.cs
index 56890ebe..8a3590a2 100644
--- a/src/Ryujinx.Audio/Renderer/Dsp/Effect/DelayLine.cs
+++ b/src/Ryujinx.Audio/Renderer/Dsp/Effect/DelayLine.cs
@@ -4,8 +4,8 @@ namespace Ryujinx.Audio.Renderer.Dsp.Effect
 {
     public class DelayLine : IDelayLine
     {
-        private float[] _workBuffer;
-        private uint _sampleRate;
+        private readonly float[] _workBuffer;
+        private readonly uint _sampleRate;
         private uint _currentSampleIndex;
         private uint _lastSampleIndex;
 
@@ -75,4 +75,4 @@ namespace Ryujinx.Audio.Renderer.Dsp.Effect
             return TapUnsafe(sampleIndex, -1);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Effect/DelayLineReverb3d.cs b/src/Ryujinx.Audio/Renderer/Dsp/Effect/DelayLineReverb3d.cs
index a2ac9d26..ed8e7cfe 100644
--- a/src/Ryujinx.Audio/Renderer/Dsp/Effect/DelayLineReverb3d.cs
+++ b/src/Ryujinx.Audio/Renderer/Dsp/Effect/DelayLineReverb3d.cs
@@ -4,8 +4,8 @@ namespace Ryujinx.Audio.Renderer.Dsp.Effect
 {
     public class DelayLine3d : IDelayLine
     {
-        private float[] _workBuffer;
-        private uint _sampleRate;
+        private readonly float[] _workBuffer;
+        private readonly uint _sampleRate;
         private uint _currentSampleIndex;
         private uint _lastSampleIndex;
 
@@ -73,4 +73,4 @@ namespace Ryujinx.Audio.Renderer.Dsp.Effect
             return TapUnsafe(sampleIndex, -1);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Effect/ExponentialMovingAverage.cs b/src/Ryujinx.Audio/Renderer/Dsp/Effect/ExponentialMovingAverage.cs
index 78e46bf9..253400a5 100644
--- a/src/Ryujinx.Audio/Renderer/Dsp/Effect/ExponentialMovingAverage.cs
+++ b/src/Ryujinx.Audio/Renderer/Dsp/Effect/ExponentialMovingAverage.cs
@@ -1,6 +1,4 @@
-using System.Runtime.CompilerServices;
-
-namespace Ryujinx.Audio.Renderer.Dsp.Effect
+namespace Ryujinx.Audio.Renderer.Dsp.Effect
 {
     public struct ExponentialMovingAverage
     {
@@ -11,7 +9,7 @@ namespace Ryujinx.Audio.Renderer.Dsp.Effect
             _mean = mean;
         }
 
-        public float Read()
+        public readonly float Read()
         {
             return _mean;
         }
diff --git a/src/Ryujinx.Audio/Renderer/Dsp/Effect/IDelayLine.cs b/src/Ryujinx.Audio/Renderer/Dsp/Effect/IDelayLine.cs
index fd902525..b408e294 100644
--- a/src/Ryujinx.Audio/Renderer/Dsp/Effect/IDelayLine.cs
+++ b/src/Ryujinx.Audio/Renderer/Dsp/Effect/IDelayLine.cs
@@ -34,4 +34,4 @@ namespace Ryujinx.Audio.Renderer.Dsp.Effect
             return (uint)MathF.Round(sampleRate * delayTime);
         }
     }
-}
\ No newline at end of file
+}