[ARMeilleure] Address dotnet-format issues (#5357)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address or silence dotnet format CA2208 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Silence CA1806 and CA1834 issues

* Address dotnet format CA1401 warnings

* Fix new dotnet-format issues after rebase

* Address review comments

* Address dotnet format CA2208 warnings properly

* Fix formatting for switch expressions

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for OpCodeTable.cs

* Enable formatting for a few cases again

* Format if-blocks correctly

* Enable formatting for a few more cases again

* Fix inline comment alignment

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Remove a few unused parameters

* Adjust namespaces

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Remove unnecessary formatting exclusion

* Add unsafe dotnet format changes

* Change visibility of JitSupportDarwin to internal

1 files changed, 57 insertions, 56 deletions

diff --git a/src/ARMeilleure/Translation/Cache/JitUnwindWindows.cs b/src/ARMeilleure/Translation/Cache/JitUnwindWindows.cs
index 77727bf1..91fd19c2 100644
--- a/src/ARMeilleure/Translation/Cache/JitUnwindWindows.cs
+++ b/src/ARMeilleure/Translation/Cache/JitUnwindWindows.cs
@@ -29,15 +29,15 @@ namespace ARMeilleure.Translation.Cache
 
         private enum UnwindOp
         {
-            PushNonvol    = 0,
-            AllocLarge    = 1,
-            AllocSmall    = 2,
-            SetFpreg      = 3,
-            SaveNonvol    = 4,
+            PushNonvol = 0,
+            AllocLarge = 1,
+            AllocSmall = 2,
+            SetFpreg = 3,
+            SaveNonvol = 4,
             SaveNonvolFar = 5,
-            SaveXmm128    = 8,
+            SaveXmm128 = 8,
             SaveXmm128Far = 9,
-            PushMachframe = 10
+            PushMachframe = 10,
         }
 
         private unsafe delegate RuntimeFunction* GetRuntimeFunctionCallback(ulong controlPc, IntPtr context);
@@ -111,72 +111,73 @@ namespace ARMeilleure.Translation.Cache
                 switch (entry.PseudoOp)
                 {
                     case UnwindPseudoOp.SaveXmm128:
-                    {
-                        int stackOffset = entry.StackOffsetOrAllocSize;
-
-                        Debug.Assert(stackOffset % 16 == 0);
-
-                        if (stackOffset <= 0xFFFF0)
-                        {
-                            _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.SaveXmm128, entry.PrologOffset, entry.RegIndex);
-                            _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(stackOffset / 16);
-                        }
-                        else
                         {
-                            _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.SaveXmm128Far, entry.PrologOffset, entry.RegIndex);
-                            _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(stackOffset >> 0);
-                            _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(stackOffset >> 16);
+                            int stackOffset = entry.StackOffsetOrAllocSize;
+
+                            Debug.Assert(stackOffset % 16 == 0);
+
+                            if (stackOffset <= 0xFFFF0)
+                            {
+                                _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.SaveXmm128, entry.PrologOffset, entry.RegIndex);
+                                _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(stackOffset / 16);
+                            }
+                            else
+                            {
+                                _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.SaveXmm128Far, entry.PrologOffset, entry.RegIndex);
+                                _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(stackOffset >> 0);
+                                _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(stackOffset >> 16);
+                            }
+
+                            break;
                         }
 
-                        break;
-                    }
-
                     case UnwindPseudoOp.AllocStack:
-                    {
-                        int allocSize = entry.StackOffsetOrAllocSize;
-
-                        Debug.Assert(allocSize % 8 == 0);
-
-                        if (allocSize <= 128)
                         {
-                            _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.AllocSmall, entry.PrologOffset, (allocSize / 8) - 1);
-                        }
-                        else if (allocSize <= 0x7FFF8)
-                        {
-                            _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.AllocLarge, entry.PrologOffset, 0);
-                            _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(allocSize / 8);
-                        }
-                        else
-                        {
-                            _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.AllocLarge, entry.PrologOffset, 1);
-                            _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(allocSize >> 0);
-                            _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(allocSize >> 16);
+                            int allocSize = entry.StackOffsetOrAllocSize;
+
+                            Debug.Assert(allocSize % 8 == 0);
+
+                            if (allocSize <= 128)
+                            {
+                                _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.AllocSmall, entry.PrologOffset, (allocSize / 8) - 1);
+                            }
+                            else if (allocSize <= 0x7FFF8)
+                            {
+                                _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.AllocLarge, entry.PrologOffset, 0);
+                                _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(allocSize / 8);
+                            }
+                            else
+                            {
+                                _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.AllocLarge, entry.PrologOffset, 1);
+                                _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(allocSize >> 0);
+                                _unwindInfo->UnwindCodes[codeIndex++] = (ushort)(allocSize >> 16);
+                            }
+
+                            break;
                         }
 
-                        break;
-                    }
-
                     case UnwindPseudoOp.PushReg:
-                    {
-                        _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.PushNonvol, entry.PrologOffset, entry.RegIndex);
+                        {
+                            _unwindInfo->UnwindCodes[codeIndex++] = PackUnwindOp(UnwindOp.PushNonvol, entry.PrologOffset, entry.RegIndex);
 
-                        break;
-                    }
+                            break;
+                        }
 
-                    default: throw new NotImplementedException($"({nameof(entry.PseudoOp)} = {entry.PseudoOp})");
+                    default:
+                        throw new NotImplementedException($"({nameof(entry.PseudoOp)} = {entry.PseudoOp})");
                 }
             }
 
             Debug.Assert(codeIndex <= MaxUnwindCodesArraySize);
 
-            _unwindInfo->VersionAndFlags    = 1; // Flags: The function has no handler.
-            _unwindInfo->SizeOfProlog       = (byte)unwindInfo.PrologSize;
+            _unwindInfo->VersionAndFlags = 1; // Flags: The function has no handler.
+            _unwindInfo->SizeOfProlog = (byte)unwindInfo.PrologSize;
             _unwindInfo->CountOfUnwindCodes = (byte)codeIndex;
-            _unwindInfo->FrameRegister      = 0;
+            _unwindInfo->FrameRegister = 0;
 
             _runtimeFunction->BeginAddress = (uint)funcEntry.Offset;
-            _runtimeFunction->EndAddress   = (uint)(funcEntry.Offset + funcEntry.Size);
-            _runtimeFunction->UnwindData   = (uint)_sizeOfRuntimeFunction;
+            _runtimeFunction->EndAddress = (uint)(funcEntry.Offset + funcEntry.Size);
+            _runtimeFunction->UnwindData = (uint)_sizeOfRuntimeFunction;
 
             return _runtimeFunction;
         }
@@ -186,4 +187,4 @@ namespace ARMeilleure.Translation.Cache
             return (ushort)(prologOffset | ((int)op << 8) | (opInfo << 12));
         }
     }
-}
\ No newline at end of file
+}