Adjust naming conventions and general refactoring in HLE Project (#490)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Remove unneeded property setters

1 files changed, 31 insertions, 31 deletions

diff --git a/Ryujinx.HLE/Loaders/Npdm/ACID.cs b/Ryujinx.HLE/Loaders/Npdm/ACID.cs
index 9206ee7b..3ff87357 100644
--- a/Ryujinx.HLE/Loaders/Npdm/ACID.cs
+++ b/Ryujinx.HLE/Loaders/Npdm/ACID.cs
@@ -3,59 +3,59 @@ using System.IO;
 
 namespace Ryujinx.HLE.Loaders.Npdm
 {
-    class ACID
+    class Acid
     {
-        private const int ACIDMagic = 'A' << 0 | 'C' << 8 | 'I' << 16 | 'D' << 24;
+        private const int AcidMagic = 'A' << 0 | 'C' << 8 | 'I' << 16 | 'D' << 24;
 
-        public byte[] RSA2048Signature { get; private set; }
-        public byte[] RSA2048Modulus   { get; private set; }
-        public int    Unknown1         { get; private set; }
-        public int    Flags            { get; private set; }
+        public byte[] Rsa2048Signature { get; }
+        public byte[] Rsa2048Modulus   { get; }
+        public int    Unknown1         { get; }
+        public int    Flags            { get; }
 
-        public long TitleIdRangeMin { get; private set; }
-        public long TitleIdRangeMax { get; private set; }
+        public long TitleIdRangeMin { get; }
+        public long TitleIdRangeMax { get; }
 
-        public FsAccessControl      FsAccessControl      { get; private set; }
-        public ServiceAccessControl ServiceAccessControl { get; private set; }
-        public KernelAccessControl  KernelAccessControl  { get; private set; }
+        public FsAccessControl      FsAccessControl      { get; }
+        public ServiceAccessControl ServiceAccessControl { get; }
+        public KernelAccessControl  KernelAccessControl  { get; }
 
-        public ACID(Stream Stream, int Offset)
+        public Acid(Stream stream, int offset)
         {
-            Stream.Seek(Offset, SeekOrigin.Begin);
+            stream.Seek(offset, SeekOrigin.Begin);
 
-            BinaryReader Reader = new BinaryReader(Stream);
+            BinaryReader reader = new BinaryReader(stream);
 
-            RSA2048Signature = Reader.ReadBytes(0x100);
-            RSA2048Modulus   = Reader.ReadBytes(0x100);
+            Rsa2048Signature = reader.ReadBytes(0x100);
+            Rsa2048Modulus   = reader.ReadBytes(0x100);
 
-            if (Reader.ReadInt32() != ACIDMagic)
+            if (reader.ReadInt32() != AcidMagic)
             {
                 throw new InvalidNpdmException("ACID Stream doesn't contain ACID section!");
             }
 
             //Size field used with the above signature (?).
-            Unknown1 = Reader.ReadInt32();
+            Unknown1 = reader.ReadInt32();
 
-            Reader.ReadInt32();
+            reader.ReadInt32();
 
             //Bit0 must be 1 on retail, on devunit 0 is also allowed. Bit1 is unknown.
-            Flags = Reader.ReadInt32();
+            Flags = reader.ReadInt32();
 
-            TitleIdRangeMin = Reader.ReadInt64();
-            TitleIdRangeMax = Reader.ReadInt64();
+            TitleIdRangeMin = reader.ReadInt64();
+            TitleIdRangeMax = reader.ReadInt64();
 
-            int FsAccessControlOffset      = Reader.ReadInt32();
-            int FsAccessControlSize        = Reader.ReadInt32();
-            int ServiceAccessControlOffset = Reader.ReadInt32();
-            int ServiceAccessControlSize   = Reader.ReadInt32();
-            int KernelAccessControlOffset  = Reader.ReadInt32();
-            int KernelAccessControlSize    = Reader.ReadInt32();
+            int fsAccessControlOffset      = reader.ReadInt32();
+            int fsAccessControlSize        = reader.ReadInt32();
+            int serviceAccessControlOffset = reader.ReadInt32();
+            int serviceAccessControlSize   = reader.ReadInt32();
+            int kernelAccessControlOffset  = reader.ReadInt32();
+            int kernelAccessControlSize    = reader.ReadInt32();
 
-            FsAccessControl = new FsAccessControl(Stream, Offset + FsAccessControlOffset, FsAccessControlSize);
+            FsAccessControl = new FsAccessControl(stream, offset + fsAccessControlOffset, fsAccessControlSize);
 
-            ServiceAccessControl = new ServiceAccessControl(Stream, Offset + ServiceAccessControlOffset, ServiceAccessControlSize);
+            ServiceAccessControl = new ServiceAccessControl(stream, offset + serviceAccessControlOffset, serviceAccessControlSize);
 
-            KernelAccessControl = new KernelAccessControl(Stream, Offset + KernelAccessControlOffset, KernelAccessControlSize);
+            KernelAccessControl = new KernelAccessControl(stream, offset + kernelAccessControlOffset, kernelAccessControlSize);
         }
     }
 }