Adjust naming conventions and general refactoring in HLE Project (#490)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Remove unneeded property setters

1 files changed, 25 insertions, 25 deletions

diff --git a/Ryujinx.HLE/Loaders/Npdm/ACI0.cs b/Ryujinx.HLE/Loaders/Npdm/ACI0.cs
index 4bec93e4..28e11a48 100644
--- a/Ryujinx.HLE/Loaders/Npdm/ACI0.cs
+++ b/Ryujinx.HLE/Loaders/Npdm/ACI0.cs
@@ -3,51 +3,51 @@ using System.IO;
 
 namespace Ryujinx.HLE.Loaders.Npdm
 {
-    class ACI0
+    class Aci0
     {
-        private const int ACI0Magic = 'A' << 0 | 'C' << 8 | 'I' << 16 | '0' << 24;
+        private const int Aci0Magic = 'A' << 0 | 'C' << 8 | 'I' << 16 | '0' << 24;
 
-        public long TitleId { get; private set; }
+        public long TitleId { get; }
 
-        public int   FsVersion            { get; private set; }
-        public ulong FsPermissionsBitmask { get; private set; }
+        public int   FsVersion            { get; }
+        public ulong FsPermissionsBitmask { get; }
 
-        public ServiceAccessControl ServiceAccessControl { get; private set; }
-        public KernelAccessControl  KernelAccessControl  { get; private set; }
+        public ServiceAccessControl ServiceAccessControl { get; }
+        public KernelAccessControl  KernelAccessControl  { get; }
 
-        public ACI0(Stream Stream, int Offset)
+        public Aci0(Stream stream, int offset)
         {
-            Stream.Seek(Offset, SeekOrigin.Begin);
+            stream.Seek(offset, SeekOrigin.Begin);
 
-            BinaryReader Reader = new BinaryReader(Stream);
+            BinaryReader reader = new BinaryReader(stream);
 
-            if (Reader.ReadInt32() != ACI0Magic)
+            if (reader.ReadInt32() != Aci0Magic)
             {
                 throw new InvalidNpdmException("ACI0 Stream doesn't contain ACI0 section!");
             }
 
-            Stream.Seek(0xc, SeekOrigin.Current);
+            stream.Seek(0xc, SeekOrigin.Current);
 
-            TitleId = Reader.ReadInt64();
+            TitleId = reader.ReadInt64();
 
             //Reserved.
-            Stream.Seek(8, SeekOrigin.Current);
+            stream.Seek(8, SeekOrigin.Current);
 
-            int FsAccessHeaderOffset       = Reader.ReadInt32();
-            int FsAccessHeaderSize         = Reader.ReadInt32();
-            int ServiceAccessControlOffset = Reader.ReadInt32();
-            int ServiceAccessControlSize   = Reader.ReadInt32();
-            int KernelAccessControlOffset  = Reader.ReadInt32();
-            int KernelAccessControlSize    = Reader.ReadInt32();
+            int fsAccessHeaderOffset       = reader.ReadInt32();
+            int fsAccessHeaderSize         = reader.ReadInt32();
+            int serviceAccessControlOffset = reader.ReadInt32();
+            int serviceAccessControlSize   = reader.ReadInt32();
+            int kernelAccessControlOffset  = reader.ReadInt32();
+            int kernelAccessControlSize    = reader.ReadInt32();
 
-            FsAccessHeader FsAccessHeader = new FsAccessHeader(Stream, Offset + FsAccessHeaderOffset, FsAccessHeaderSize);
+            FsAccessHeader fsAccessHeader = new FsAccessHeader(stream, offset + fsAccessHeaderOffset, fsAccessHeaderSize);
 
-            FsVersion            = FsAccessHeader.Version;
-            FsPermissionsBitmask = FsAccessHeader.PermissionsBitmask;
+            FsVersion            = fsAccessHeader.Version;
+            FsPermissionsBitmask = fsAccessHeader.PermissionsBitmask;
 
-            ServiceAccessControl = new ServiceAccessControl(Stream, Offset + ServiceAccessControlOffset, ServiceAccessControlSize);
+            ServiceAccessControl = new ServiceAccessControl(stream, offset + serviceAccessControlOffset, serviceAccessControlSize);
 
-            KernelAccessControl = new KernelAccessControl(Stream, Offset + KernelAccessControlOffset, KernelAccessControlSize);
+            KernelAccessControl = new KernelAccessControl(stream, offset + kernelAccessControlOffset, kernelAccessControlSize);
         }
     }
 }