Adjust naming conventions and general refactoring in HLE Project (#490)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Remove unneeded property setters

1 files changed, 35 insertions, 35 deletions

diff --git a/Ryujinx.HLE/HOS/Services/Vi/GbpBuffer.cs b/Ryujinx.HLE/HOS/Services/Vi/GbpBuffer.cs
index 4f00c3de..4a247d1b 100644
--- a/Ryujinx.HLE/HOS/Services/Vi/GbpBuffer.cs
+++ b/Ryujinx.HLE/HOS/Services/Vi/GbpBuffer.cs
@@ -4,57 +4,57 @@ namespace Ryujinx.HLE.HOS.Services.Android
 {
     struct GbpBuffer
     {
-        public int Magic  { get; private set; }
-        public int Width  { get; private set; }
-        public int Height { get; private set; }
-        public int Stride { get; private set; }
-        public int Format { get; private set; }
-        public int Usage  { get; private set; }
+        public int Magic  { get; }
+        public int Width  { get; }
+        public int Height { get; }
+        public int Stride { get; }
+        public int Format { get; }
+        public int Usage  { get; }
 
-        public int Pid      { get; private set; }
-        public int RefCount { get; private set; }
+        public int Pid      { get; }
+        public int RefCount { get; }
 
-        public int FdsCount  { get; private set; }
-        public int IntsCount { get; private set; }
+        public int FdsCount  { get; }
+        public int IntsCount { get; }
 
-        public byte[] RawData { get; private set; }
+        public byte[] RawData { get; }
 
         public int Size => RawData.Length + 10 * 4;
 
-        public GbpBuffer(BinaryReader Reader)
+        public GbpBuffer(BinaryReader reader)
         {
-            Magic  = Reader.ReadInt32();
-            Width  = Reader.ReadInt32();
-            Height = Reader.ReadInt32();
-            Stride = Reader.ReadInt32();
-            Format = Reader.ReadInt32();
-            Usage  = Reader.ReadInt32();
+            Magic  = reader.ReadInt32();
+            Width  = reader.ReadInt32();
+            Height = reader.ReadInt32();
+            Stride = reader.ReadInt32();
+            Format = reader.ReadInt32();
+            Usage  = reader.ReadInt32();
 
-            Pid      = Reader.ReadInt32();
-            RefCount = Reader.ReadInt32();
+            Pid      = reader.ReadInt32();
+            RefCount = reader.ReadInt32();
 
-            FdsCount  = Reader.ReadInt32();
-            IntsCount = Reader.ReadInt32();
+            FdsCount  = reader.ReadInt32();
+            IntsCount = reader.ReadInt32();
 
-            RawData = Reader.ReadBytes((FdsCount + IntsCount) * 4);
+            RawData = reader.ReadBytes((FdsCount + IntsCount) * 4);
         }
 
-        public void Write(BinaryWriter Writer)
+        public void Write(BinaryWriter writer)
         {
-            Writer.Write(Magic);
-            Writer.Write(Width);
-            Writer.Write(Height);
-            Writer.Write(Stride);
-            Writer.Write(Format);
-            Writer.Write(Usage);
+            writer.Write(Magic);
+            writer.Write(Width);
+            writer.Write(Height);
+            writer.Write(Stride);
+            writer.Write(Format);
+            writer.Write(Usage);
 
-            Writer.Write(Pid);
-            Writer.Write(RefCount);
+            writer.Write(Pid);
+            writer.Write(RefCount);
 
-            Writer.Write(FdsCount);
-            Writer.Write(IntsCount);
+            writer.Write(FdsCount);
+            writer.Write(IntsCount);
 
-            Writer.Write(RawData);
+            writer.Write(RawData);
         }
     }
 }
\ No newline at end of file