Implement a new physical memory manager and replace DeviceMemory (#856)

* Implement a new physical memory manager and replace DeviceMemory

* Proper generic constraints

* Fix debug build

* Add memory tests

* New CPU memory manager and general code cleanup

* Remove host memory management from CPU project, use Ryujinx.Memory instead

* Fix tests

* Document exceptions on MemoryBlock

* Fix leak on unix memory allocation

* Proper disposal of some objects on tests

* Fix JitCache not being set as initialized

* GetRef without checks for 8-bits and 16-bits CAS

* Add MemoryBlock destructor

* Throw in separate method to improve codegen

* Address PR feedback

* QueryModified improvements

* Fix memory write tracking not marking all pages as modified in some cases

* Simplify MarkRegionAsModified

* Remove XML doc for ghost param

* Add back optimization to avoid useless buffer updates

* Add Ryujinx.Cpu project, move MemoryManager there and remove MemoryBlockWrapper

* Some nits

* Do not perform address translation when size is 0

* Address PR feedback and format NativeInterface class

* Remove ghost parameter description

* Update Ryujinx.Cpu to .NET Core 3.1

* Address PR feedback

* Fix build

* Return a well defined value for GetPhysicalAddress with invalid VA, and do not return unmapped ranges as modified

* Typo

6 files changed, 44 insertions, 28 deletions

diff --git a/Ryujinx.HLE/HOS/Services/Time/IStaticServiceForPsc.cs b/Ryujinx.HLE/HOS/Services/Time/IStaticServiceForPsc.cs
index f5cecdbb..8de3f726 100644
--- a/Ryujinx.HLE/HOS/Services/Time/IStaticServiceForPsc.cs
+++ b/Ryujinx.HLE/HOS/Services/Time/IStaticServiceForPsc.cs
@@ -401,7 +401,11 @@ namespace Ryujinx.HLE.HOS.Services.Time
         {
             Debug.Assert(ipcDesc.Size == Marshal.SizeOf<ClockSnapshot>());
 
-            using (BinaryReader bufferReader = new BinaryReader(new MemoryStream(context.Memory.ReadBytes(ipcDesc.Position, ipcDesc.Size))))
+            byte[] temp = new byte[ipcDesc.Size];
+
+            context.Memory.Read((ulong)ipcDesc.Position, temp);
+
+            using (BinaryReader bufferReader = new BinaryReader(new MemoryStream(temp)))
             {
                 return bufferReader.ReadStruct<ClockSnapshot>();
             }
@@ -418,7 +422,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
                 bufferWriter.WriteStruct(clockSnapshot);
             }
 
-            context.Memory.WriteBytes(ipcDesc.Position, memory.ToArray());
+            context.Memory.Write((ulong)ipcDesc.Position, memory.ToArray());
             memory.Dispose();
         }
     }
diff --git a/Ryujinx.HLE/HOS/Services/Time/ITimeServiceManager.cs b/Ryujinx.HLE/HOS/Services/Time/ITimeServiceManager.cs
index a897b3f7..64b21381 100644
--- a/Ryujinx.HLE/HOS/Services/Time/ITimeServiceManager.cs
+++ b/Ryujinx.HLE/HOS/Services/Time/ITimeServiceManager.cs
@@ -123,7 +123,11 @@ namespace Ryujinx.HLE.HOS.Services.Time
 
             (long bufferPosition, long bufferSize) = context.Request.GetBufferType0x21();
 
-            using (MemoryStream timeZoneBinaryStream = new MemoryStream(context.Memory.ReadBytes(bufferPosition, bufferSize)))
+            byte[] temp = new byte[bufferSize];
+
+            context.Memory.Read((ulong)bufferPosition, temp);
+
+            using (MemoryStream timeZoneBinaryStream = new MemoryStream(temp))
             {
                 _timeManager.SetupTimeZoneManager(locationName, timeZoneUpdateTimePoint, totalLocationNameCount, timeZoneRuleVersion, timeZoneBinaryStream);
             }
diff --git a/Ryujinx.HLE/HOS/Services/Time/StaticService/ITimeZoneServiceForGlue.cs b/Ryujinx.HLE/HOS/Services/Time/StaticService/ITimeZoneServiceForGlue.cs
index 7acb0257..bbe80fbe 100644
--- a/Ryujinx.HLE/HOS/Services/Time/StaticService/ITimeZoneServiceForGlue.cs
+++ b/Ryujinx.HLE/HOS/Services/Time/StaticService/ITimeZoneServiceForGlue.cs
@@ -1,6 +1,5 @@
-using ARMeilleure.Memory;
-using Ryujinx.Common;
 using Ryujinx.Common.Logging;
+using Ryujinx.Cpu;
 using Ryujinx.HLE.HOS.Services.Time.TimeZone;
 using System;
 using System.Text;
@@ -71,7 +70,7 @@ namespace Ryujinx.HLE.HOS.Services.Time.StaticService
                         return ResultCode.LocationNameTooLong;
                     }
 
-                    context.Memory.WriteBytes(bufferPosition + offset, Encoding.ASCII.GetBytes(locationName));
+                    context.Memory.Write((ulong)bufferPosition + offset, Encoding.ASCII.GetBytes(locationName));
                     MemoryHelper.FillWithZeros(context.Memory, bufferPosition + offset + locationName.Length, padding);
 
                     offset += 0x24;
diff --git a/Ryujinx.HLE/HOS/Services/Time/StaticService/ITimeZoneServiceForPsc.cs b/Ryujinx.HLE/HOS/Services/Time/StaticService/ITimeZoneServiceForPsc.cs
index ed31fe7c..4f0e6e9c 100644
--- a/Ryujinx.HLE/HOS/Services/Time/StaticService/ITimeZoneServiceForPsc.cs
+++ b/Ryujinx.HLE/HOS/Services/Time/StaticService/ITimeZoneServiceForPsc.cs
@@ -1,6 +1,6 @@
-using ARMeilleure.Memory;
-using Ryujinx.Common;
+using Ryujinx.Common;
 using Ryujinx.Common.Logging;
+using Ryujinx.Cpu;
 using Ryujinx.HLE.HOS.Services.Time.Clock;
 using Ryujinx.HLE.HOS.Services.Time.TimeZone;
 using Ryujinx.HLE.Utilities;
@@ -129,7 +129,11 @@ namespace Ryujinx.HLE.HOS.Services.Time.StaticService
 
             ResultCode result;
 
-            using (MemoryStream timeZoneBinaryStream = new MemoryStream(context.Memory.ReadBytes(bufferPosition, bufferSize)))
+            byte[] temp = new byte[bufferSize];
+
+            context.Memory.Read((ulong)bufferPosition, temp);
+
+            using (MemoryStream timeZoneBinaryStream = new MemoryStream(temp))
             {
                 result = _timeZoneManager.SetDeviceLocationNameWithTimeZoneRule(locationName, timeZoneBinaryStream);
             }
@@ -156,7 +160,11 @@ namespace Ryujinx.HLE.HOS.Services.Time.StaticService
 
             ResultCode result;
 
-            using (MemoryStream timeZoneBinaryStream = new MemoryStream(context.Memory.ReadBytes(bufferPosition, bufferSize)))
+            byte[] temp = new byte[bufferSize];
+
+            context.Memory.Read((ulong)bufferPosition, temp);
+
+            using (MemoryStream timeZoneBinaryStream = new MemoryStream(temp))
             {
                 result = _timeZoneManager.ParseTimeZoneRuleBinary(out TimeZoneRule timeZoneRule, timeZoneBinaryStream);
 
@@ -246,7 +254,7 @@ namespace Ryujinx.HLE.HOS.Services.Time.StaticService
                 long outBufferPosition = context.Request.RecvListBuff[0].Position;
                 long outBufferSize     = context.Request.RecvListBuff[0].Size;
 
-                context.Memory.WriteInt64(outBufferPosition, posixTime);
+                context.Memory.Write((ulong)outBufferPosition, posixTime);
                 context.ResponseData.Write(1);
             }
 
@@ -266,7 +274,7 @@ namespace Ryujinx.HLE.HOS.Services.Time.StaticService
                 long outBufferPosition = context.Request.RecvListBuff[0].Position;
                 long outBufferSize     = context.Request.RecvListBuff[0].Size;
 
-                context.Memory.WriteInt64(outBufferPosition, posixTime);
+                context.Memory.Write((ulong)outBufferPosition, posixTime);
 
                 // There could be only one result on one calendar as leap seconds aren't supported.
                 context.ResponseData.Write(1);
diff --git a/Ryujinx.HLE/HOS/Services/Time/TimeManager.cs b/Ryujinx.HLE/HOS/Services/Time/TimeManager.cs
index 03ed6fba..7b17b18d 100644
--- a/Ryujinx.HLE/HOS/Services/Time/TimeManager.cs
+++ b/Ryujinx.HLE/HOS/Services/Time/TimeManager.cs
@@ -55,7 +55,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
             EphemeralClockContextWriter = new EphemeralNetworkSystemClockContextWriter();
         }
 
-        public void Initialize(Switch device, Horizon system, KSharedMemory sharedMemory, long timeSharedMemoryAddress, int timeSharedMemorySize)
+        public void Initialize(Switch device, Horizon system, KSharedMemory sharedMemory, ulong timeSharedMemoryAddress, int timeSharedMemorySize)
         {
             SharedMemory.Initialize(device, sharedMemory, timeSharedMemoryAddress, timeSharedMemorySize);
 
diff --git a/Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs b/Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs
index f714c662..e3683076 100644
--- a/Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs
+++ b/Ryujinx.HLE/HOS/Services/Time/TimeSharedMemory.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Threading;
 using Ryujinx.HLE.HOS.Kernel.Memory;
@@ -13,7 +14,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
     {
         private Switch        _device;
         private KSharedMemory _sharedMemory;
-        private long          _timeSharedMemoryAddress;
+        private ulong         _timeSharedMemoryAddress;
         private int           _timeSharedMemorySize;
 
         private const uint SteadyClockContextOffset         = 0x00;
@@ -21,7 +22,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
         private const uint NetworkSystemClockContextOffset  = 0x80;
         private const uint AutomaticCorrectionEnabledOffset = 0xC8;
 
-        public void Initialize(Switch device, KSharedMemory sharedMemory, long timeSharedMemoryAddress, int timeSharedMemorySize)
+        public void Initialize(Switch device, KSharedMemory sharedMemory, ulong timeSharedMemoryAddress, int timeSharedMemorySize)
         {
             _device                  = device;
             _sharedMemory            = sharedMemory;
@@ -29,7 +30,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
             _timeSharedMemorySize    = timeSharedMemorySize;
 
             // Clean the shared memory
-            _device.Memory.FillWithZeros(_timeSharedMemoryAddress, _timeSharedMemorySize);
+            _device.Memory.ZeroFill(_timeSharedMemoryAddress, (ulong)_timeSharedMemorySize);
         }
 
         public KSharedMemory GetSharedMemory()
@@ -86,9 +87,9 @@ namespace Ryujinx.HLE.HOS.Services.Time
             WriteObjectToSharedMemory(NetworkSystemClockContextOffset, 4, context);
         }
 
-        private T ReadObjectFromSharedMemory<T>(long offset, long padding)
+        private T ReadObjectFromSharedMemory<T>(ulong offset, ulong padding) where T : unmanaged
         {
-            long indexOffset  = _timeSharedMemoryAddress + offset;
+            ulong indexOffset = _timeSharedMemoryAddress + offset;
 
             T    result;
             uint index;
@@ -96,31 +97,31 @@ namespace Ryujinx.HLE.HOS.Services.Time
 
             do
             {
-                index = _device.Memory.ReadUInt32(indexOffset);
+                index = _device.Memory.Read<uint>(indexOffset);
 
-                long objectOffset = indexOffset + 4 + padding + (index & 1) * Marshal.SizeOf<T>();
+                ulong objectOffset = indexOffset + 4 + padding + (ulong)((index & 1) * Unsafe.SizeOf<T>());
 
-                result = _device.Memory.ReadStruct<T>(objectOffset);
+                result = _device.Memory.Read<T>(objectOffset);
 
                 Thread.MemoryBarrier();
 
-                possiblyNewIndex = _device.Memory.ReadUInt32(indexOffset);
+                possiblyNewIndex = _device.Memory.Read<uint>(indexOffset);
             } while (index != possiblyNewIndex);
 
             return result;
         }
 
-        private void WriteObjectToSharedMemory<T>(long offset, long padding, T value)
+        private void WriteObjectToSharedMemory<T>(ulong offset, ulong padding, T value) where T : unmanaged
         {
-            long indexOffset  = _timeSharedMemoryAddress + offset;
-            uint newIndex     = _device.Memory.ReadUInt32(indexOffset) + 1;
-            long objectOffset = indexOffset + 4 + padding + (newIndex & 1) * Marshal.SizeOf<T>();
+            ulong indexOffset  = _timeSharedMemoryAddress + offset;
+            uint  newIndex     = _device.Memory.Read<uint>(indexOffset) + 1;
+            ulong objectOffset = indexOffset + 4 + padding + (ulong)((newIndex & 1) * Unsafe.SizeOf<T>());
 
-            _device.Memory.WriteStruct(objectOffset, value);
+            _device.Memory.Write(objectOffset, value);
 
             Thread.MemoryBarrier();
 
-            _device.Memory.WriteUInt32(indexOffset, newIndex);
+            _device.Memory.Write(indexOffset, newIndex);
         }
     }
 }