Adjust naming conventions and general refactoring in HLE Project (#527)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Apply previous refactorings to the merged code

1 files changed, 12 insertions, 12 deletions

diff --git a/Ryujinx.HLE/HOS/Services/Spl/IRandomInterface.cs b/Ryujinx.HLE/HOS/Services/Spl/IRandomInterface.cs
index 6391d981..cae8d8d0 100644
--- a/Ryujinx.HLE/HOS/Services/Spl/IRandomInterface.cs
+++ b/Ryujinx.HLE/HOS/Services/Spl/IRandomInterface.cs
@@ -7,29 +7,29 @@ namespace Ryujinx.HLE.HOS.Services.Spl
 {
     class IRandomInterface : IpcService, IDisposable
     {
-        private Dictionary<int, ServiceProcessRequest> m_Commands;
+        private Dictionary<int, ServiceProcessRequest> _commands;
 
-        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => m_Commands;
+        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => _commands;
 
-        private RNGCryptoServiceProvider Rng;
+        private RNGCryptoServiceProvider _rng;
 
         public IRandomInterface()
         {
-            m_Commands = new Dictionary<int, ServiceProcessRequest>()
+            _commands = new Dictionary<int, ServiceProcessRequest>
             {
                 { 0, GetRandomBytes }
             };
 
-            Rng = new RNGCryptoServiceProvider();
+            _rng = new RNGCryptoServiceProvider();
         }
 
-        public long GetRandomBytes(ServiceCtx Context)
+        public long GetRandomBytes(ServiceCtx context)
         {
-            byte[] RandomBytes = new byte[Context.Request.ReceiveBuff[0].Size];
+            byte[] randomBytes = new byte[context.Request.ReceiveBuff[0].Size];
 
-            Rng.GetBytes(RandomBytes);
+            _rng.GetBytes(randomBytes);
 
-            Context.Memory.WriteBytes(Context.Request.ReceiveBuff[0].Position, RandomBytes);
+            context.Memory.WriteBytes(context.Request.ReceiveBuff[0].Position, randomBytes);
 
             return 0;
         }
@@ -39,11 +39,11 @@ namespace Ryujinx.HLE.HOS.Services.Spl
             Dispose(true);
         }
 
-        protected virtual void Dispose(bool Disposing)
+        protected virtual void Dispose(bool disposing)
         {
-            if (Disposing)
+            if (disposing)
             {
-                Rng.Dispose();
+                _rng.Dispose();
             }
         }
     }