Refactoring result codes (#731)

* refactoring result codes

- Add a main enum who can handle some orphalin result codes and the default `ResultCode.Success` one.
- Add sub-enum by services when it's needed.
- Remove some empty line.
- Recast all service calls to ResultCode.
- Remove some unneeded static declaration.
- Delete unused `NvHelper` class.

* NvResult is back

* Fix

1 files changed, 4 insertions, 4 deletions

diff --git a/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlService.cs b/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlService.cs
index 27401fe5..e9cc72c1 100644
--- a/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlService.cs
+++ b/Ryujinx.HLE/HOS/Services/Pctl/IParentalControlService.cs
@@ -15,7 +15,7 @@ namespace Ryujinx.HLE.HOS.Services.Pctl
 
         [Command(1)] // 4.0.0+
         // Initialize()
-        public long Initialize(ServiceCtx context)
+        public ResultCode Initialize(ServiceCtx context)
         {
             if (_needInitialize && !_initialized)
             {
@@ -26,16 +26,16 @@ namespace Ryujinx.HLE.HOS.Services.Pctl
                 Logger.PrintWarning(LogClass.ServicePctl, "Service is already initialized!");
             }
 
-            return 0;
+            return ResultCode.Success;
         }
 
         [Command(1001)]
         // CheckFreeCommunicationPermission()
-        public long CheckFreeCommunicationPermission(ServiceCtx context)
+        public ResultCode CheckFreeCommunicationPermission(ServiceCtx context)
         {
             Logger.PrintStub(LogClass.ServicePctl);
 
-            return 0;
+            return ResultCode.Success;
         }
     }
 }
\ No newline at end of file