Code style fixes and nits on the HLE project (#355)

* Some style fixes and nits on ITimeZoneService

* Remove some unneeded usings

* Remove the Ryujinx.HLE.OsHle.Handles namespace

* Remove hbmenu automatic load on process exit

* Rename Ns to Device, rename Os to System, rename SystemState to State

* Move Exceptions and Utilities out of OsHle

* Rename OsHle to HOS

* Rename OsHle folder to HOS

* IManagerDisplayService and ISystemDisplayService style fixes

* BsdError shouldn't be public

* Add a empty new line before using static

* Remove unused file

* Some style fixes on NPDM

* Exit gracefully when the application is closed

* Code style fixes on IGeneralService

* Add 0x prefix on values printed as hex

* Small improvements on finalization code

* Move ProcessId and ThreadId out of AThreadState

* Rename VFs to FileSystem

* FsAccessHeader shouldn't be public. Also fix file names casing

* More case changes on NPDM

* Remove unused files

* Move using to the correct place on NPDM

* Use properties on KernelAccessControlMmio

* Address PR feedback

9 files changed, 407 insertions, 0 deletions

diff --git a/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapAlloc.cs b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapAlloc.cs
new file mode 100644
index 00000000..bc61baad
--- /dev/null
+++ b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapAlloc.cs
@@ -0,0 +1,12 @@
+namespace Ryujinx.HLE.HOS.Services.Nv.NvMap
+{
+    struct NvMapAlloc
+    {
+        public int  Handle;
+        public int  HeapMask;
+        public int  Flags;
+        public int  Align;
+        public long Kind;
+        public long Address;
+    }
+}
\ No newline at end of file
diff --git a/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapCreate.cs b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapCreate.cs
new file mode 100644
index 00000000..dd4bff98
--- /dev/null
+++ b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapCreate.cs
@@ -0,0 +1,8 @@
+namespace Ryujinx.HLE.HOS.Services.Nv.NvMap
+{
+    struct NvMapCreate
+    {
+        public int Size;
+        public int Handle;
+    }
+}
\ No newline at end of file
diff --git a/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapFree.cs b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapFree.cs
new file mode 100644
index 00000000..d946987e
--- /dev/null
+++ b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapFree.cs
@@ -0,0 +1,11 @@
+namespace Ryujinx.HLE.HOS.Services.Nv.NvMap
+{
+    struct NvMapFree
+    {
+        public int  Handle;
+        public int  Padding;
+        public long Address;
+        public int  Size;
+        public int  Flags;
+    }
+}
\ No newline at end of file
diff --git a/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapFromId.cs b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapFromId.cs
new file mode 100644
index 00000000..e49257ea
--- /dev/null
+++ b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapFromId.cs
@@ -0,0 +1,8 @@
+namespace Ryujinx.HLE.HOS.Services.Nv.NvMap
+{
+    struct NvMapFromId
+    {
+        public int Id;
+        public int Handle;
+    }
+}
\ No newline at end of file
diff --git a/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapGetId.cs b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapGetId.cs
new file mode 100644
index 00000000..1f4f3290
--- /dev/null
+++ b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapGetId.cs
@@ -0,0 +1,8 @@
+namespace Ryujinx.HLE.HOS.Services.Nv.NvMap
+{
+    struct NvMapGetId
+    {
+        public int Id;
+        public int Handle;
+    }
+}
\ No newline at end of file
diff --git a/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapHandle.cs b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapHandle.cs
new file mode 100644
index 00000000..3f8a1517
--- /dev/null
+++ b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapHandle.cs
@@ -0,0 +1,37 @@
+using System.Threading;
+
+namespace Ryujinx.HLE.HOS.Services.Nv.NvMap
+{
+    class NvMapHandle
+    {
+        public int  Handle;
+        public int  Id;
+        public int  Size;
+        public int  Align;
+        public int  Kind;
+        public long Address;
+        public bool Allocated;
+
+        private long Dupes;
+
+        public NvMapHandle()
+        {
+            Dupes = 1;
+        }
+
+        public NvMapHandle(int Size) : this()
+        {
+            this.Size = Size;
+        }
+
+        public void IncrementRefCount()
+        {
+            Interlocked.Increment(ref Dupes);
+        }
+
+        public long DecrementRefCount()
+        {
+            return Interlocked.Decrement(ref Dupes);
+        }
+    }
+}
\ No newline at end of file
diff --git a/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapHandleParam.cs b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapHandleParam.cs
new file mode 100644
index 00000000..b360343c
--- /dev/null
+++ b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapHandleParam.cs
@@ -0,0 +1,12 @@
+namespace Ryujinx.HLE.HOS.Services.Nv.NvMap
+{
+    enum NvMapHandleParam
+    {
+        Size  = 1,
+        Align = 2,
+        Base  = 3,
+        Heap  = 4,
+        Kind  = 5,
+        Compr = 6
+    }
+}
\ No newline at end of file
diff --git a/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapIoctl.cs b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapIoctl.cs
new file mode 100644
index 00000000..782f7b80
--- /dev/null
+++ b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapIoctl.cs
@@ -0,0 +1,302 @@
+using ChocolArm64.Memory;
+using Ryujinx.HLE.Gpu.Memory;
+using Ryujinx.HLE.Logging;
+using Ryujinx.HLE.Utilities;
+using System.Collections.Concurrent;
+
+namespace Ryujinx.HLE.HOS.Services.Nv.NvMap
+{
+    class NvMapIoctl
+    {
+        private const int FlagNotFreedYet = 1;
+
+        private static ConcurrentDictionary<Process, IdDictionary> Maps;
+
+        static NvMapIoctl()
+        {
+            Maps = new ConcurrentDictionary<Process, IdDictionary>();
+        }
+
+        public static int ProcessIoctl(ServiceCtx Context, int Cmd)
+        {
+            switch (Cmd & 0xffff)
+            {
+                case 0x0101: return Create(Context);
+                case 0x0103: return FromId(Context);
+                case 0x0104: return Alloc (Context);
+                case 0x0105: return Free  (Context);
+                case 0x0109: return Param (Context);
+                case 0x010e: return GetId (Context);
+            }
+
+            Context.Device.Log.PrintWarning(LogClass.ServiceNv, $"Unsupported Ioctl command 0x{Cmd:x8}!");
+
+            return NvResult.NotSupported;
+        }
+
+        private static int Create(ServiceCtx Context)
+        {
+            long InputPosition  = Context.Request.GetBufferType0x21().Position;
+            long OutputPosition = Context.Request.GetBufferType0x22().Position;
+
+            NvMapCreate Args = AMemoryHelper.Read<NvMapCreate>(Context.Memory, InputPosition);
+
+            if (Args.Size == 0)
+            {
+                Context.Device.Log.PrintWarning(LogClass.ServiceNv, $"Invalid size 0x{Args.Size:x8}!");
+
+                return NvResult.InvalidInput;
+            }
+
+            int Size = IntUtils.AlignUp(Args.Size, NvGpuVmm.PageSize);
+
+            Args.Handle = AddNvMap(Context, new NvMapHandle(Size));
+
+            Context.Device.Log.PrintInfo(LogClass.ServiceNv, $"Created map {Args.Handle} with size 0x{Size:x8}!");
+
+            AMemoryHelper.Write(Context.Memory, OutputPosition, Args);
+
+            return NvResult.Success;
+        }
+
+        private static int FromId(ServiceCtx Context)
+        {
+            long InputPosition  = Context.Request.GetBufferType0x21().Position;
+            long OutputPosition = Context.Request.GetBufferType0x22().Position;
+
+            NvMapFromId Args = AMemoryHelper.Read<NvMapFromId>(Context.Memory, InputPosition);
+
+            NvMapHandle Map = GetNvMap(Context, Args.Id);
+
+            if (Map == null)
+            {
+                Context.Device.Log.PrintWarning(LogClass.ServiceNv, $"Invalid handle 0x{Args.Handle:x8}!");
+
+                return NvResult.InvalidInput;
+            }
+
+            Map.IncrementRefCount();
+
+            Args.Handle = Args.Id;
+
+            AMemoryHelper.Write(Context.Memory, OutputPosition, Args);
+
+            return NvResult.Success;
+        }
+
+        private static int Alloc(ServiceCtx Context)
+        {
+            long InputPosition  = Context.Request.GetBufferType0x21().Position;
+            long OutputPosition = Context.Request.GetBufferType0x22().Position;
+
+            NvMapAlloc Args = AMemoryHelper.Read<NvMapAlloc>(Context.Memory, InputPosition);
+
+            NvMapHandle Map = GetNvMap(Context, Args.Handle);
+
+            if (Map == null)
+            {
+                Context.Device.Log.PrintWarning(LogClass.ServiceNv, $"Invalid handle 0x{Args.Handle:x8}!");
+
+                return NvResult.InvalidInput;
+            }
+
+            if ((Args.Align & (Args.Align - 1)) != 0)
+            {
+                Context.Device.Log.PrintWarning(LogClass.ServiceNv, $"Invalid alignment 0x{Args.Align:x8}!");
+
+                return NvResult.InvalidInput;
+            }
+
+            if ((uint)Args.Align < NvGpuVmm.PageSize)
+            {
+                Args.Align = NvGpuVmm.PageSize;
+            }
+
+            int Result = NvResult.Success;
+
+            if (!Map.Allocated)
+            {
+                Map.Allocated = true;
+
+                Map.Align =       Args.Align;
+                Map.Kind  = (byte)Args.Kind;
+
+                int Size = IntUtils.AlignUp(Map.Size, NvGpuVmm.PageSize);
+
+                long Address = Args.Address;
+
+                if (Address == 0)
+                {
+                    //When the address is zero, we need to allocate
+                    //our own backing memory for the NvMap.
+                    //TODO: Is this allocation inside the transfer memory?
+                    if (!Context.Device.Memory.Allocator.TryAllocate((uint)Size, out Address))
+                    {
+                        Result = NvResult.OutOfMemory;
+                    }
+                }
+
+                if (Result == NvResult.Success)
+                {
+                    Map.Size    = Size;
+                    Map.Address = Address;
+                }
+            }
+
+            AMemoryHelper.Write(Context.Memory, OutputPosition, Args);
+
+            return Result;
+        }
+
+        private static int Free(ServiceCtx Context)
+        {
+            long InputPosition  = Context.Request.GetBufferType0x21().Position;
+            long OutputPosition = Context.Request.GetBufferType0x22().Position;
+
+            NvMapFree Args = AMemoryHelper.Read<NvMapFree>(Context.Memory, InputPosition);
+
+            NvMapHandle Map = GetNvMap(Context, Args.Handle);
+
+            if (Map == null)
+            {
+                Context.Device.Log.PrintWarning(LogClass.ServiceNv, $"Invalid handle 0x{Args.Handle:x8}!");
+
+                return NvResult.InvalidInput;
+            }
+
+            if (Map.DecrementRefCount() <= 0)
+            {
+                DeleteNvMap(Context, Args.Handle);
+
+                Context.Device.Log.PrintInfo(LogClass.ServiceNv, $"Deleted map {Args.Handle}!");
+
+                Args.Address = Map.Address;
+                Args.Flags   = 0;
+            }
+            else
+            {
+                Args.Address = 0;
+                Args.Flags   = FlagNotFreedYet;
+            }
+
+            Args.Size = Map.Size;
+
+            AMemoryHelper.Write(Context.Memory, OutputPosition, Args);
+
+            return NvResult.Success;
+        }
+
+        private static int Param(ServiceCtx Context)
+        {
+            long InputPosition  = Context.Request.GetBufferType0x21().Position;
+            long OutputPosition = Context.Request.GetBufferType0x22().Position;
+
+            NvMapParam Args = AMemoryHelper.Read<NvMapParam>(Context.Memory, InputPosition);
+
+            NvMapHandle Map = GetNvMap(Context, Args.Handle);
+
+            if (Map == null)
+            {
+                Context.Device.Log.PrintWarning(LogClass.ServiceNv, $"Invalid handle 0x{Args.Handle:x8}!");
+
+                return NvResult.InvalidInput;
+            }
+
+            switch ((NvMapHandleParam)Args.Param)
+            {
+                case NvMapHandleParam.Size:  Args.Result = Map.Size;   break;
+                case NvMapHandleParam.Align: Args.Result = Map.Align;  break;
+                case NvMapHandleParam.Heap:  Args.Result = 0x40000000; break;
+                case NvMapHandleParam.Kind:  Args.Result = Map.Kind;   break;
+                case NvMapHandleParam.Compr: Args.Result = 0;          break;
+
+                //Note: Base is not supported and returns an error.
+                //Any other value also returns an error.
+                default: return NvResult.InvalidInput;
+            }
+
+            AMemoryHelper.Write(Context.Memory, OutputPosition, Args);
+
+            return NvResult.Success;
+        }
+
+        private static int GetId(ServiceCtx Context)
+        {
+            long InputPosition  = Context.Request.GetBufferType0x21().Position;
+            long OutputPosition = Context.Request.GetBufferType0x22().Position;
+
+            NvMapGetId Args = AMemoryHelper.Read<NvMapGetId>(Context.Memory, InputPosition);
+
+            NvMapHandle Map = GetNvMap(Context, Args.Handle);
+
+            if (Map == null)
+            {
+                Context.Device.Log.PrintWarning(LogClass.ServiceNv, $"Invalid handle 0x{Args.Handle:x8}!");
+
+                return NvResult.InvalidInput;
+            }
+
+            Args.Id = Args.Handle;
+
+            AMemoryHelper.Write(Context.Memory, OutputPosition, Args);
+
+            return NvResult.Success;
+        }
+
+        private static int AddNvMap(ServiceCtx Context, NvMapHandle Map)
+        {
+            IdDictionary Dict = Maps.GetOrAdd(Context.Process, (Key) =>
+            {
+                IdDictionary NewDict = new IdDictionary();
+
+                NewDict.Add(0, new NvMapHandle());
+
+                return NewDict;
+            });
+
+            return Dict.Add(Map);
+        }
+
+        private static bool DeleteNvMap(ServiceCtx Context, int Handle)
+        {
+            if (Maps.TryGetValue(Context.Process, out IdDictionary Dict))
+            {
+                return Dict.Delete(Handle) != null;
+            }
+
+            return false;
+        }
+
+        public static void InitializeNvMap(ServiceCtx Context)
+        {
+            IdDictionary Dict = Maps.GetOrAdd(Context.Process, (Key) =>new IdDictionary());
+
+            Dict.Add(0, new NvMapHandle());
+        }
+
+        public static NvMapHandle GetNvMapWithFb(ServiceCtx Context, int Handle)
+        {
+            if (Maps.TryGetValue(Context.Process, out IdDictionary Dict))
+            {
+                return Dict.GetData<NvMapHandle>(Handle);
+            }
+
+            return null;
+        }
+
+        public static NvMapHandle GetNvMap(ServiceCtx Context, int Handle)
+        {
+            if (Handle != 0 && Maps.TryGetValue(Context.Process, out IdDictionary Dict))
+            {
+                return Dict.GetData<NvMapHandle>(Handle);
+            }
+
+            return null;
+        }
+
+        public static void UnloadProcess(Process Process)
+        {
+            Maps.TryRemove(Process, out _);
+        }
+    }
+}
\ No newline at end of file
diff --git a/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapParam.cs b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapParam.cs
new file mode 100644
index 00000000..b5213efe
--- /dev/null
+++ b/Ryujinx.HLE/HOS/Services/Nv/NvMap/NvMapParam.cs
@@ -0,0 +1,9 @@
+namespace Ryujinx.HLE.HOS.Services.Nv.NvMap
+{
+    struct NvMapParam
+    {
+        public int Handle;
+        public int Param;
+        public int Result;
+    }
+}
\ No newline at end of file