aoc/am: Cleanup aoc service and stub am calls (#2414)

* aoc/am: Cleanup aoc service and stub am calls

This PR implement aoc call `GetAddOnContentListChangedEventWithProcessId` (Closes #2408) and `CreateContentsServiceManager`. Additionnally, a big cleanup (checked by RE on latest firmware) is made on the whole service. I've added `CountAddOnContent`, `ListAddOnContent` and `GetAddonContentBaseId` for games which require version `1.0.0-6.2.0` too.

Am service call `ReportUserIsActive` is stubbed (checked by RE, closes #2413).

Since some logic in the service (aoc) which handle the DLCs has been changed, it could be nice to have some testing to be sure there is no regression.

* Remove wrong check

* Addresses gdkchan feedback

* Fix GetAddOnContentLostErrorCode

* fix null pid in services

* Add missing comment

* remove leftover comment

1 files changed, 0 insertions, 52 deletions

diff --git a/Ryujinx.HLE/HOS/Services/Ns/IPurchaseEventManager.cs b/Ryujinx.HLE/HOS/Services/Ns/IPurchaseEventManager.cs
deleted file mode 100644
index 7ee74370..00000000
--- a/Ryujinx.HLE/HOS/Services/Ns/IPurchaseEventManager.cs
+++ /dev/null
@@ -1,52 +0,0 @@
-using Ryujinx.Common;
-using Ryujinx.Common.Logging;
-using Ryujinx.HLE.HOS.Ipc;
-using Ryujinx.HLE.HOS.Kernel.Common;
-using Ryujinx.HLE.HOS.Kernel.Threading;
-using System;
-
-namespace Ryujinx.HLE.HOS.Services.Ns
-{
-    class IPurchaseEventManager : IpcService
-    {
-        private readonly KEvent _purchasedEvent;
-
-        public IPurchaseEventManager(Horizon system)
-        {
-            _purchasedEvent = new KEvent(system.KernelContext);
-        }
-
-        [CommandHipc(0)]
-        // SetDefaultDeliveryTarget(pid, buffer<bytes, 5> unknown)
-        public ResultCode SetDefaultDeliveryTarget(ServiceCtx context)
-        {
-            ulong   inBufferPosition = context.Request.SendBuff[0].Position;
-            ulong   inBufferSize     = context.Request.SendBuff[0].Size;
-            byte[] buffer           = new byte[inBufferSize];
-
-            context.Memory.Read(inBufferPosition, buffer);
-
-            // NOTE: Service use the pid to call arp:r GetApplicationLaunchProperty and store it in internal field.
-            //       Then it seems to use the buffer content and compare it with a stored linked instrusive list.
-            //       Since we don't support purchase from eShop, we can stub it.
-
-            Logger.Stub?.PrintStub(LogClass.ServiceNs);
-
-            return ResultCode.Success;
-        }
-
-        [CommandHipc(2)]
-        // GetPurchasedEventReadableHandle() -> handle<copy, event>
-        public ResultCode GetPurchasedEventReadableHandle(ServiceCtx context)
-        {
-            if (context.Process.HandleTable.GenerateHandle(_purchasedEvent.ReadableEvent, out int handle) != KernelResult.Success)
-            {
-                throw new InvalidOperationException("Out of handles!");
-            }
-
-            context.Response.HandleDesc = IpcHandleDesc.MakeCopy(handle);
-
-            return ResultCode.Success;
-        }
-    }
-}
\ No newline at end of file