diff options
| author | jduncanator <1518948+jduncanator@users.noreply.github.com> | 2019-01-11 11:11:46 +1100 |
|---|---|---|
| committer | Ac_K <Acoustik666@gmail.com> | 2019-01-11 01:11:46 +0100 |
| commit | 8406ec6272392a3f7f7672d85fdde333b6c70378 (patch) | |
| tree | b8d3f0a1692015c4bd56897cf7146877aa967da0 /Ryujinx.HLE/HOS/Services/Mm | |
| parent | 600799ba87fd59c3a6ef56e55a689a1ebdc410a6 (diff) | |
Refactor Ryujinx.Common and HLE Stub Logging (#537)
* Refactor Ryujinx.Common and HLE Stub Logging
* Resolve review comments
* Rename missed loop variable
* Optimize PrintStub logging function
* Pass the call-sites Thread ID through to the logger
* Remove superfluous lock from ConsoleLog
* Process logged data objects in the logger target
Pass the data object all the way to the output logger targets, to allow them to "serialize" this in whatever appropriate format they're logging in.
* Use existing StringBuilder to build the properties string
* Add a ServiceNotImplemented Exception
Useful for printing debug information about unimplemented service calls
* Resolve Style Nits
* Resolve Merge Issues
* Fix typo and align declarations
Diffstat (limited to 'Ryujinx.HLE/HOS/Services/Mm')
| -rw-r--r-- | Ryujinx.HLE/HOS/Services/Mm/IRequest.cs | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/Ryujinx.HLE/HOS/Services/Mm/IRequest.cs b/Ryujinx.HLE/HOS/Services/Mm/IRequest.cs index 9b051de0..932e5b0d 100644 --- a/Ryujinx.HLE/HOS/Services/Mm/IRequest.cs +++ b/Ryujinx.HLE/HOS/Services/Mm/IRequest.cs @@ -32,8 +32,7 @@ namespace Ryujinx.HLE.HOS.Services.Mm int unknown1 = context.RequestData.ReadInt32(); int unknown2 = context.RequestData.ReadInt32(); - Logger.PrintStub(LogClass.ServiceMm, $"Stubbed. Unknown0: {unknown0} - " + - $"Unknown1: {unknown1} - Unknown2: {unknown2}"); + Logger.PrintStub(LogClass.ServiceMm, new { unknown0, unknown1, unknown2 }); return 0; } @@ -43,7 +42,7 @@ namespace Ryujinx.HLE.HOS.Services.Mm { context.Device.Gpu.UninitializeVideoDecoder(); - Logger.PrintStub(LogClass.ServiceMm, "Stubbed."); + Logger.PrintStub(LogClass.ServiceMm); return 0; } @@ -55,8 +54,7 @@ namespace Ryujinx.HLE.HOS.Services.Mm int unknown1 = context.RequestData.ReadInt32(); int unknown2 = context.RequestData.ReadInt32(); - Logger.PrintStub(LogClass.ServiceMm, $"Stubbed. Unknown0: {unknown0} - " + - $"Unknown1: {unknown1} - Unknown2: {unknown2}"); + Logger.PrintStub(LogClass.ServiceMm, new { unknown0, unknown1, unknown2 }); return 0; } @@ -65,7 +63,7 @@ namespace Ryujinx.HLE.HOS.Services.Mm { int unknown0 = context.RequestData.ReadInt32(); - Logger.PrintStub(LogClass.ServiceMm, $"Stubbed. Unknown0: {unknown0}"); + Logger.PrintStub(LogClass.ServiceMm, new { unknown0 }); context.ResponseData.Write(0); @@ -75,7 +73,7 @@ namespace Ryujinx.HLE.HOS.Services.Mm // Initialize() public long Initialize(ServiceCtx context) { - Logger.PrintStub(LogClass.ServiceMm, "Stubbed."); + Logger.PrintStub(LogClass.ServiceMm); return 0; } @@ -85,7 +83,7 @@ namespace Ryujinx.HLE.HOS.Services.Mm { context.Device.Gpu.UninitializeVideoDecoder(); - Logger.PrintStub(LogClass.ServiceMm, "Stubbed."); + Logger.PrintStub(LogClass.ServiceMm); return 0; } @@ -97,8 +95,7 @@ namespace Ryujinx.HLE.HOS.Services.Mm int unknown1 = context.RequestData.ReadInt32(); int unknown2 = context.RequestData.ReadInt32(); - Logger.PrintStub(LogClass.ServiceMm, $"Stubbed. Unknown0: {unknown0} - " + - $"Unknown1: {unknown1} - Unknown2: {unknown2}"); + Logger.PrintStub(LogClass.ServiceMm, new { unknown0, unknown1, unknown2 }); return 0; } @@ -108,7 +105,7 @@ namespace Ryujinx.HLE.HOS.Services.Mm { int unknown0 = context.RequestData.ReadInt32(); - Logger.PrintStub(LogClass.ServiceMm, $"Stubbed. Unknown0: {unknown0}"); + Logger.PrintStub(LogClass.ServiceMm, new { unknown0 }); context.ResponseData.Write(0); |