hle: Make Ryujinx.HLE project entirely safe (#2789)

* Remove a bit of unsafety around

* Regenerate StructArrayHelpers with a max element value of 256

* hle: remove unsafe marker from all struct that had it

* hle: make SoftwareKeyboardRenderer.TryCopyTo safe

* hle: remove unsafety in NpadDevice and remove AllowUnsafeBlocks from csproj

* Revert "Regenerate StructArrayHelpers with a max element value of 256"

This reverts commit f32a6e5be094f50571970eb1116b65c080781d05.

* Introduce ByteArray of various size and use that instead of ArrayXXX to avoid stackoverflow in .NET runtime type resolution

* Use ByteArray more

* Add some missing spaces on Pack = 1 for various structs

* Fix broken logic for TryCopyTo

* Address gdkchan's comment

* Address gdkchan's comment

1 files changed, 2 insertions, 22 deletions

diff --git a/Ryujinx.HLE/HOS/Services/Hid/HidDevices/NpadDevices.cs b/Ryujinx.HLE/HOS/Services/Hid/HidDevices/NpadDevices.cs
index 55f8070a..ff93204c 100644
--- a/Ryujinx.HLE/HOS/Services/Hid/HidDevices/NpadDevices.cs
+++ b/Ryujinx.HLE/HOS/Services/Hid/HidDevices/NpadDevices.cs
@@ -328,17 +328,7 @@ namespace Ryujinx.HLE.HOS.Services.Hid
 
         private void UpdateUnusedInputIfNotEqual(ref RingLifo<NpadCommonState> currentlyUsed, ref RingLifo<NpadCommonState> possiblyUnused)
         {
-            bool isEquals;
-
-            unsafe
-            {
-                var aPointer = Unsafe.AsPointer(ref currentlyUsed);
-                var bPointer = Unsafe.AsPointer(ref possiblyUnused);
-
-                isEquals = aPointer == bPointer;
-            }
-
-            if (!isEquals)
+            if (!Unsafe.AreSame(ref currentlyUsed, ref possiblyUnused))
             {
                 NpadCommonState newState = new NpadCommonState();
 
@@ -357,17 +347,7 @@ namespace Ryujinx.HLE.HOS.Services.Hid
 
         private void UpdateUnusedSixInputIfNotEqual(ref RingLifo<SixAxisSensorState> currentlyUsed, ref RingLifo<SixAxisSensorState> possiblyUnused)
         {
-            bool isEquals;
-
-            unsafe
-            {
-                var aPointer = Unsafe.AsPointer(ref currentlyUsed);
-                var bPointer = Unsafe.AsPointer(ref possiblyUnused);
-
-                isEquals = aPointer == bPointer;
-            }
-
-            if (!isEquals)
+            if (!Unsafe.AreSame(ref currentlyUsed, ref possiblyUnused))
             {
                 SixAxisSensorState newState = new SixAxisSensorState();