Adjust naming conventions and general refactoring in HLE Project (#527)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Apply previous refactorings to the merged code

2 files changed, 14 insertions, 14 deletions

diff --git a/Ryujinx.HLE/HOS/Services/Apm/IManager.cs b/Ryujinx.HLE/HOS/Services/Apm/IManager.cs
index 50822def..cd86e516 100644
--- a/Ryujinx.HLE/HOS/Services/Apm/IManager.cs
+++ b/Ryujinx.HLE/HOS/Services/Apm/IManager.cs
@@ -5,21 +5,21 @@ namespace Ryujinx.HLE.HOS.Services.Apm
 {
     class IManager : IpcService
     {
-        private Dictionary<int, ServiceProcessRequest> m_Commands;
+        private Dictionary<int, ServiceProcessRequest> _commands;
 
-        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => m_Commands;
+        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => _commands;
 
         public IManager()
         {
-            m_Commands = new Dictionary<int, ServiceProcessRequest>()
+            _commands = new Dictionary<int, ServiceProcessRequest>
             {
                 { 0, OpenSession }
             };
         }
 
-        public long OpenSession(ServiceCtx Context)
+        public long OpenSession(ServiceCtx context)
         {
-            MakeObject(Context, new ISession());
+            MakeObject(context, new ISession());
 
             return 0;
         }
diff --git a/Ryujinx.HLE/HOS/Services/Apm/ISession.cs b/Ryujinx.HLE/HOS/Services/Apm/ISession.cs
index d04bcfc9..cef34383 100644
--- a/Ryujinx.HLE/HOS/Services/Apm/ISession.cs
+++ b/Ryujinx.HLE/HOS/Services/Apm/ISession.cs
@@ -6,32 +6,32 @@ namespace Ryujinx.HLE.HOS.Services.Apm
 {
     class ISession : IpcService
     {
-        private Dictionary<int, ServiceProcessRequest> m_Commands;
+        private Dictionary<int, ServiceProcessRequest> _commands;
 
-        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => m_Commands;
+        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => _commands;
 
         public ISession()
         {
-            m_Commands = new Dictionary<int, ServiceProcessRequest>()
+            _commands = new Dictionary<int, ServiceProcessRequest>
             {
                 { 0, SetPerformanceConfiguration },
                 { 1, GetPerformanceConfiguration }
             };
         }
 
-        public long SetPerformanceConfiguration(ServiceCtx Context)
+        public long SetPerformanceConfiguration(ServiceCtx context)
         {
-            PerformanceMode          PerfMode   = (PerformanceMode)Context.RequestData.ReadInt32();
-            PerformanceConfiguration PerfConfig = (PerformanceConfiguration)Context.RequestData.ReadInt32();
+            PerformanceMode          perfMode   = (PerformanceMode)context.RequestData.ReadInt32();
+            PerformanceConfiguration perfConfig = (PerformanceConfiguration)context.RequestData.ReadInt32();
 
             return 0;
         }
 
-        public long GetPerformanceConfiguration(ServiceCtx Context)
+        public long GetPerformanceConfiguration(ServiceCtx context)
         {
-            PerformanceMode PerfMode = (PerformanceMode)Context.RequestData.ReadInt32();
+            PerformanceMode perfMode = (PerformanceMode)context.RequestData.ReadInt32();
 
-            Context.ResponseData.Write((uint)PerformanceConfiguration.PerformanceConfiguration1);
+            context.ResponseData.Write((uint)PerformanceConfiguration.PerformanceConfiguration1);
 
             Logger.PrintStub(LogClass.ServiceApm, "Stubbed.");