Adjust naming conventions and general refactoring in HLE Project (#490)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Remove unneeded property setters

1 files changed, 11 insertions, 11 deletions

diff --git a/Ryujinx.HLE/HOS/Services/Acc/IManagerForApplication.cs b/Ryujinx.HLE/HOS/Services/Acc/IManagerForApplication.cs
index 9312b2bc..93b4b4a1 100644
--- a/Ryujinx.HLE/HOS/Services/Acc/IManagerForApplication.cs
+++ b/Ryujinx.HLE/HOS/Services/Acc/IManagerForApplication.cs
@@ -7,25 +7,25 @@ namespace Ryujinx.HLE.HOS.Services.Acc
 {
     class IManagerForApplication : IpcService
     {
-        private UInt128 Uuid;
+        private UInt128 _uuid;
 
-        private Dictionary<int, ServiceProcessRequest> m_Commands;
+        private Dictionary<int, ServiceProcessRequest> _commands;
 
-        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => m_Commands;
+        public override IReadOnlyDictionary<int, ServiceProcessRequest> Commands => _commands;
 
-        public IManagerForApplication(UInt128 Uuid)
+        public IManagerForApplication(UInt128 uuid)
         {
-            m_Commands = new Dictionary<int, ServiceProcessRequest>()
+            _commands = new Dictionary<int, ServiceProcessRequest>
             {
                 { 0, CheckAvailability },
                 { 1, GetAccountId      }
             };
 
-            this.Uuid = Uuid;
+            _uuid = uuid;
         }
 
         // CheckAvailability()
-        public long CheckAvailability(ServiceCtx Context)
+        public long CheckAvailability(ServiceCtx context)
         {
             Logger.PrintStub(LogClass.ServiceAcc, "Stubbed.");
 
@@ -33,13 +33,13 @@ namespace Ryujinx.HLE.HOS.Services.Acc
         }
 
         // GetAccountId() -> nn::account::NetworkServiceAccountId
-        public long GetAccountId(ServiceCtx Context)
+        public long GetAccountId(ServiceCtx context)
         {
-            long NetworkServiceAccountId = 0xcafe;
+            long networkServiceAccountId = 0xcafe;
 
-            Logger.PrintStub(LogClass.ServiceAcc, $"Stubbed. NetworkServiceAccountId: {NetworkServiceAccountId}");
+            Logger.PrintStub(LogClass.ServiceAcc, $"Stubbed. NetworkServiceAccountId: {networkServiceAccountId}");
 
-            Context.ResponseData.Write(NetworkServiceAccountId);
+            context.ResponseData.Write(networkServiceAccountId);
 
             return 0;
         }