Adjust naming conventions and general refactoring in HLE Project (#490)

* Rename enum fields

* Naming conventions

* Remove unneeded ".this"

* Remove unneeded semicolons

* Remove unused Usings

* Don't use var

* Remove unneeded enum underlying types

* Explicitly label class visibility

* Remove unneeded @ prefixes

* Remove unneeded commas

* Remove unneeded if expressions

* Method doesn't use unsafe code

* Remove unneeded casts

* Initialized objects don't need an empty constructor

* Remove settings from DotSettings

* Revert "Explicitly label class visibility"

This reverts commit ad5eb5787cc5b27a4631cd46ef5f551c4ae95e51.

* Small changes

* Revert external enum renaming

* Changes from feedback

* Remove unneeded property setters

1 files changed, 24 insertions, 24 deletions

diff --git a/Ryujinx.HLE/HOS/ServiceCtx.cs b/Ryujinx.HLE/HOS/ServiceCtx.cs
index 76c426bc..61fa2a9b 100644
--- a/Ryujinx.HLE/HOS/ServiceCtx.cs
+++ b/Ryujinx.HLE/HOS/ServiceCtx.cs
@@ -7,33 +7,33 @@ namespace Ryujinx.HLE.HOS
 {
     class ServiceCtx
     {
-        public Switch        Device       { get; private set; }
-        public KProcess      Process      { get; private set; }
-        public MemoryManager Memory       { get; private set; }
-        public KSession      Session      { get; private set; }
-        public IpcMessage    Request      { get; private set; }
-        public IpcMessage    Response     { get; private set; }
-        public BinaryReader  RequestData  { get; private set; }
-        public BinaryWriter  ResponseData { get; private set; }
+        public Switch        Device       { get; }
+        public KProcess      Process      { get; }
+        public MemoryManager Memory       { get; }
+        public KSession      Session      { get; }
+        public IpcMessage    Request      { get; }
+        public IpcMessage    Response     { get; }
+        public BinaryReader  RequestData  { get; }
+        public BinaryWriter  ResponseData { get; }
 
         public ServiceCtx(
-            Switch        Device,
-            KProcess      Process,
-            MemoryManager Memory,
-            KSession      Session,
-            IpcMessage    Request,
-            IpcMessage    Response,
-            BinaryReader  RequestData,
-            BinaryWriter  ResponseData)
+            Switch        device,
+            KProcess      process,
+            MemoryManager memory,
+            KSession      session,
+            IpcMessage    request,
+            IpcMessage    response,
+            BinaryReader  requestData,
+            BinaryWriter  responseData)
         {
-            this.Device       = Device;
-            this.Process      = Process;
-            this.Memory       = Memory;
-            this.Session      = Session;
-            this.Request      = Request;
-            this.Response     = Response;
-            this.RequestData  = RequestData;
-            this.ResponseData = ResponseData;
+            Device       = device;
+            Process      = process;
+            Memory       = memory;
+            Session      = session;
+            Request      = request;
+            Response     = response;
+            RequestData  = requestData;
+            ResponseData = responseData;
         }
     }
 }
\ No newline at end of file