diff options
| author | Andrey Sukharev <SukharevAndrey@users.noreply.github.com> | 2022-12-05 16:47:39 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-12-05 14:47:39 +0100 |
| commit | 4da44e09cb2a32f69b4a6b47221117b78e4618dc (patch) | |
| tree | c3648a09202374dabff6fac472fe341bf9e1f0ee /Ryujinx.HLE/HOS/Kernel | |
| parent | ae13f0ab4da5b371bba746c1bd6598baaa44585d (diff) | |
Make structs readonly when applicable (#4002)
* Make all structs readonly when applicable. It should reduce amount of needless defensive copies
* Make structs with trivial boilerplate equality code record structs
* Remove unnecessary readonly modifiers from TextureCreateInfo
* Make BitMap structs readonly too
Diffstat (limited to 'Ryujinx.HLE/HOS/Kernel')
| -rw-r--r-- | Ryujinx.HLE/HOS/Kernel/Common/KernelInit.cs | 2 | ||||
| -rw-r--r-- | Ryujinx.HLE/HOS/Kernel/Common/OnScopeExit.cs | 2 | ||||
| -rw-r--r-- | Ryujinx.HLE/HOS/Kernel/Ipc/KServerSession.cs | 4 | ||||
| -rw-r--r-- | Ryujinx.HLE/HOS/Kernel/Process/ProcessCreationInfo.cs | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/Ryujinx.HLE/HOS/Kernel/Common/KernelInit.cs b/Ryujinx.HLE/HOS/Kernel/Common/KernelInit.cs index 1949df31..9829ae03 100644 --- a/Ryujinx.HLE/HOS/Kernel/Common/KernelInit.cs +++ b/Ryujinx.HLE/HOS/Kernel/Common/KernelInit.cs @@ -5,7 +5,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Common { static class KernelInit { - private struct MemoryRegion + private readonly struct MemoryRegion { public ulong Address { get; } public ulong Size { get; } diff --git a/Ryujinx.HLE/HOS/Kernel/Common/OnScopeExit.cs b/Ryujinx.HLE/HOS/Kernel/Common/OnScopeExit.cs index 098d83d1..d805a4e1 100644 --- a/Ryujinx.HLE/HOS/Kernel/Common/OnScopeExit.cs +++ b/Ryujinx.HLE/HOS/Kernel/Common/OnScopeExit.cs @@ -2,7 +2,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Common { - struct OnScopeExit : IDisposable + readonly struct OnScopeExit : IDisposable { private readonly Action _action; public OnScopeExit(Action action) => _action = action; diff --git a/Ryujinx.HLE/HOS/Kernel/Ipc/KServerSession.cs b/Ryujinx.HLE/HOS/Kernel/Ipc/KServerSession.cs index e28677ff..dc5ad717 100644 --- a/Ryujinx.HLE/HOS/Kernel/Ipc/KServerSession.cs +++ b/Ryujinx.HLE/HOS/Kernel/Ipc/KServerSession.cs @@ -17,7 +17,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Ipc (MemoryState)0xfffce5d4 //This is invalid, shouldn't be accessed. }; - private struct Message + private readonly struct Message { public ulong Address { get; } public ulong Size { get; } @@ -45,7 +45,7 @@ namespace Ryujinx.HLE.HOS.Kernel.Ipc request.CustomCmdBuffSize) { } } - private struct MessageHeader + private readonly struct MessageHeader { public uint Word0 { get; } public uint Word1 { get; } diff --git a/Ryujinx.HLE/HOS/Kernel/Process/ProcessCreationInfo.cs b/Ryujinx.HLE/HOS/Kernel/Process/ProcessCreationInfo.cs index 26c23b3b..c05bb574 100644 --- a/Ryujinx.HLE/HOS/Kernel/Process/ProcessCreationInfo.cs +++ b/Ryujinx.HLE/HOS/Kernel/Process/ProcessCreationInfo.cs @@ -1,6 +1,6 @@ namespace Ryujinx.HLE.HOS.Kernel.Process { - struct ProcessCreationInfo + readonly struct ProcessCreationInfo { public string Name { get; } |