Improve multi-controller support in HID and Controller Applet (#1453)

* Initial commit

Enable proper LED patterns
Toggle Hotkeys only on focus
Ignore Handheld on Docked mode
Remove PrimaryController
Validate NpadIdType
Rewrite NpadDevices to process config in update loop
Cleanup

* Notify in log periodically when no matched controllers

* Remove duplicate StructArrayHelpers in favor of Common.Memory

Fix struct padding CS0169 warns in Touchscreen

* Remove GTK markup from Controller Applet

Use IList instead of List
Explicit list capacity in 1ms loop
Fix formatting

* Restrict ControllerWindow to show valid controller types

Add selected player name to ControllerWindow title

* ControllerWindow: Fix controller type initial value

NpadDevices: Simplify default battery charge

* Address AcK's comments

Use explicit types and fix formatting

* Remove HashSet for SupportedPlayers

Fixes potential exceptions due to race

* Fix ControllerSupportArg struct packing

Also comes with two revisions of struct for 4/8 players max.

1 files changed, 0 insertions, 13 deletions

diff --git a/Ryujinx.HLE/HOS/Applets/Controller/ControllerSupportArg.cs b/Ryujinx.HLE/HOS/Applets/Controller/ControllerSupportArg.cs
deleted file mode 100644
index 908e9049..00000000
--- a/Ryujinx.HLE/HOS/Applets/Controller/ControllerSupportArg.cs
+++ /dev/null
@@ -1,13 +0,0 @@
-namespace Ryujinx.HLE.HOS.Applets
-{
-#pragma warning disable CS0649
-    // (8.0.0+ version)
-    unsafe struct ControllerSupportArg
-    {
-        public ControllerSupportArgHeader Header;
-        public fixed uint IdentificationColor[8];
-        public byte EnableExplainText;
-        public fixed byte ExplainText[8 * 0x81];
-    }
-#pragma warning restore CS0649
-}
\ No newline at end of file