Make structs readonly when applicable (#4002)

* Make all structs readonly when applicable. It should reduce amount of needless defensive copies

* Make structs with trivial boilerplate equality code record structs

* Remove unnecessary readonly modifiers from TextureCreateInfo

* Make BitMap structs readonly too

17 files changed, 18 insertions, 18 deletions

diff --git a/Ryujinx.Graphics.Vulkan/BitMap.cs b/Ryujinx.Graphics.Vulkan/BitMap.cs
index ee3c3c93..efa71fc7 100644
--- a/Ryujinx.Graphics.Vulkan/BitMap.cs
+++ b/Ryujinx.Graphics.Vulkan/BitMap.cs
@@ -1,6 +1,6 @@
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct BitMap
+    readonly struct BitMap
     {
         public const int IntSize = 64;
 
diff --git a/Ryujinx.Graphics.Vulkan/BufferState.cs b/Ryujinx.Graphics.Vulkan/BufferState.cs
index 88858e86..f3a58469 100644
--- a/Ryujinx.Graphics.Vulkan/BufferState.cs
+++ b/Ryujinx.Graphics.Vulkan/BufferState.cs
@@ -2,7 +2,7 @@
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct BufferState : IDisposable
+    readonly struct BufferState : IDisposable
     {
         public static BufferState Null => new BufferState(null, 0, 0);
 
diff --git a/Ryujinx.Graphics.Vulkan/CacheByRange.cs b/Ryujinx.Graphics.Vulkan/CacheByRange.cs
index afd7140e..a9d1b0ef 100644
--- a/Ryujinx.Graphics.Vulkan/CacheByRange.cs
+++ b/Ryujinx.Graphics.Vulkan/CacheByRange.cs
@@ -106,7 +106,7 @@ namespace Ryujinx.Graphics.Vulkan
         }
     }
 
-    struct TopologyConversionIndirectCacheKey : ICacheKey
+    readonly struct TopologyConversionIndirectCacheKey : ICacheKey
     {
         private readonly TopologyConversionCacheKey _baseKey;
         private readonly BufferHolder _indirectDataBuffer;
@@ -178,7 +178,7 @@ namespace Ryujinx.Graphics.Vulkan
         }
     }
 
-    struct Dependency
+    readonly struct Dependency
     {
         private readonly BufferHolder _buffer;
         private readonly int _offset;
diff --git a/Ryujinx.Graphics.Vulkan/CommandBufferScoped.cs b/Ryujinx.Graphics.Vulkan/CommandBufferScoped.cs
index 372950a8..1d9e14bb 100644
--- a/Ryujinx.Graphics.Vulkan/CommandBufferScoped.cs
+++ b/Ryujinx.Graphics.Vulkan/CommandBufferScoped.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct CommandBufferScoped : IDisposable
+    readonly struct CommandBufferScoped : IDisposable
     {
         private readonly CommandBufferPool _pool;
         public CommandBuffer CommandBuffer { get; }
diff --git a/Ryujinx.Graphics.Vulkan/DisposableBuffer.cs b/Ryujinx.Graphics.Vulkan/DisposableBuffer.cs
index 6d227ca2..0f474f97 100644
--- a/Ryujinx.Graphics.Vulkan/DisposableBuffer.cs
+++ b/Ryujinx.Graphics.Vulkan/DisposableBuffer.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct DisposableBuffer : IDisposable
+    readonly struct DisposableBuffer : IDisposable
     {
         private readonly Vk _api;
         private readonly Device _device;
diff --git a/Ryujinx.Graphics.Vulkan/DisposableBufferView.cs b/Ryujinx.Graphics.Vulkan/DisposableBufferView.cs
index 7d3fe6ee..28ddd7dd 100644
--- a/Ryujinx.Graphics.Vulkan/DisposableBufferView.cs
+++ b/Ryujinx.Graphics.Vulkan/DisposableBufferView.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct DisposableBufferView : System.IDisposable
+    readonly struct DisposableBufferView : System.IDisposable
     {
         private readonly Vk _api;
         private readonly Device _device;
diff --git a/Ryujinx.Graphics.Vulkan/DisposableFramebuffer.cs b/Ryujinx.Graphics.Vulkan/DisposableFramebuffer.cs
index 5f219a4a..5b195354 100644
--- a/Ryujinx.Graphics.Vulkan/DisposableFramebuffer.cs
+++ b/Ryujinx.Graphics.Vulkan/DisposableFramebuffer.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct DisposableFramebuffer : IDisposable
+    readonly struct DisposableFramebuffer : IDisposable
     {
         private readonly Vk _api;
         private readonly Device _device;
diff --git a/Ryujinx.Graphics.Vulkan/DisposableImage.cs b/Ryujinx.Graphics.Vulkan/DisposableImage.cs
index 4e9b3bd4..c76091b7 100644
--- a/Ryujinx.Graphics.Vulkan/DisposableImage.cs
+++ b/Ryujinx.Graphics.Vulkan/DisposableImage.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct DisposableImage : IDisposable
+    readonly struct DisposableImage : IDisposable
     {
         private readonly Vk _api;
         private readonly Device _device;
diff --git a/Ryujinx.Graphics.Vulkan/DisposableImageView.cs b/Ryujinx.Graphics.Vulkan/DisposableImageView.cs
index 3509858e..3b3bf6ad 100644
--- a/Ryujinx.Graphics.Vulkan/DisposableImageView.cs
+++ b/Ryujinx.Graphics.Vulkan/DisposableImageView.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct DisposableImageView : IDisposable
+    readonly struct DisposableImageView : IDisposable
     {
         private readonly Vk _api;
         private readonly Device _device;
diff --git a/Ryujinx.Graphics.Vulkan/DisposableMemory.cs b/Ryujinx.Graphics.Vulkan/DisposableMemory.cs
index e0b5f099..638989ac 100644
--- a/Ryujinx.Graphics.Vulkan/DisposableMemory.cs
+++ b/Ryujinx.Graphics.Vulkan/DisposableMemory.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct DisposableMemory : IDisposable
+    readonly struct DisposableMemory : IDisposable
     {
         private readonly Vk _api;
         private readonly Device _device;
diff --git a/Ryujinx.Graphics.Vulkan/DisposablePipeline.cs b/Ryujinx.Graphics.Vulkan/DisposablePipeline.cs
index ff069f7e..6e5cf4db 100644
--- a/Ryujinx.Graphics.Vulkan/DisposablePipeline.cs
+++ b/Ryujinx.Graphics.Vulkan/DisposablePipeline.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct DisposablePipeline : IDisposable
+    readonly struct DisposablePipeline : IDisposable
     {
         private readonly Vk _api;
         private readonly Device _device;
diff --git a/Ryujinx.Graphics.Vulkan/DisposableRenderPass.cs b/Ryujinx.Graphics.Vulkan/DisposableRenderPass.cs
index f561912a..65652f41 100644
--- a/Ryujinx.Graphics.Vulkan/DisposableRenderPass.cs
+++ b/Ryujinx.Graphics.Vulkan/DisposableRenderPass.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct DisposableRenderPass : IDisposable
+    readonly struct DisposableRenderPass : IDisposable
     {
         private readonly Vk _api;
         private readonly Device _device;
diff --git a/Ryujinx.Graphics.Vulkan/DisposableSampler.cs b/Ryujinx.Graphics.Vulkan/DisposableSampler.cs
index 0b93528f..4788b192 100644
--- a/Ryujinx.Graphics.Vulkan/DisposableSampler.cs
+++ b/Ryujinx.Graphics.Vulkan/DisposableSampler.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct DisposableSampler : IDisposable
+    readonly struct DisposableSampler : IDisposable
     {
         private readonly Vk _api;
         private readonly Device _device;
diff --git a/Ryujinx.Graphics.Vulkan/HardwareCapabilities.cs b/Ryujinx.Graphics.Vulkan/HardwareCapabilities.cs
index 7b1beb5f..31acfc9b 100644
--- a/Ryujinx.Graphics.Vulkan/HardwareCapabilities.cs
+++ b/Ryujinx.Graphics.Vulkan/HardwareCapabilities.cs
@@ -2,7 +2,7 @@
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct HardwareCapabilities
+    readonly struct HardwareCapabilities
     {
         public readonly bool SupportsIndexTypeUint8;
         public readonly bool SupportsCustomBorderColor;
diff --git a/Ryujinx.Graphics.Vulkan/MemoryAllocation.cs b/Ryujinx.Graphics.Vulkan/MemoryAllocation.cs
index 04956e36..76de1296 100644
--- a/Ryujinx.Graphics.Vulkan/MemoryAllocation.cs
+++ b/Ryujinx.Graphics.Vulkan/MemoryAllocation.cs
@@ -3,7 +3,7 @@ using System;
 
 namespace Ryujinx.Graphics.Vulkan
 {
-    struct MemoryAllocation : IDisposable
+    readonly struct MemoryAllocation : IDisposable
     {
         private readonly MemoryAllocatorBlockList _owner;
         private readonly MemoryAllocatorBlockList.Block _block;
diff --git a/Ryujinx.Graphics.Vulkan/MemoryAllocatorBlockList.cs b/Ryujinx.Graphics.Vulkan/MemoryAllocatorBlockList.cs
index 1c008d49..66d339b8 100644
--- a/Ryujinx.Graphics.Vulkan/MemoryAllocatorBlockList.cs
+++ b/Ryujinx.Graphics.Vulkan/MemoryAllocatorBlockList.cs
@@ -17,7 +17,7 @@ namespace Ryujinx.Graphics.Vulkan
             public ulong Size { get; }
             public bool Mapped => HostPointer != IntPtr.Zero;
 
-            private struct Range : IComparable<Range>
+            private readonly struct Range : IComparable<Range>
             {
                 public ulong Offset { get; }
                 public ulong Size { get; }
diff --git a/Ryujinx.Graphics.Vulkan/StagingBuffer.cs b/Ryujinx.Graphics.Vulkan/StagingBuffer.cs
index df353453..4e3c1dee 100644
--- a/Ryujinx.Graphics.Vulkan/StagingBuffer.cs
+++ b/Ryujinx.Graphics.Vulkan/StagingBuffer.cs
@@ -14,7 +14,7 @@ namespace Ryujinx.Graphics.Vulkan
         private readonly VulkanRenderer _gd;
         private readonly BufferHolder _buffer;
 
-        private struct PendingCopy
+        private readonly struct PendingCopy
         {
             public FenceHolder Fence { get; }
             public int Size { get; }