diff options
| author | jduncanator <jduncanator@users.noreply.github.com> | 2018-10-29 09:31:13 +1100 |
|---|---|---|
| committer | gdkchan <gab.dark.100@gmail.com> | 2018-10-28 19:31:13 -0300 |
| commit | c1b7340023b42161d55993de2e40baad68915b86 (patch) | |
| tree | 3b88c6c36b1ba4ae9b4f256cffdf4fb0a5c77648 /ChocolArm64/ATranslatorCache.cs | |
| parent | b956bbc32c7f9fdffebfd9a9416e8e0a2a588abd (diff) | |
Timing: Optimize Timestamp Aquisition (#479)
* Timing: Optimize Timestamp Aquisition
Currently, we make use of Environment.TickCount in a number of places. This has some downsides, mainly being that the TickCount is a signed 32-bit integer, and has an effective limit of ~25 days before overflowing and wrapping around. Due to the signed-ness of the value, this also caused issues with negative numbers. This resolves these issues by using a 64-bit tick count obtained from Performance Counters (via the Stopwatch class). This has a beneficial side effect of being significantly more accurate than the TickCount.
* Timing: Rename ElapsedTicks to ElapsedMilliseconds and expose TicksPerX
* Timing: Some style changes
* Timing: Align static variable initialization
Diffstat (limited to 'ChocolArm64/ATranslatorCache.cs')
| -rw-r--r-- | ChocolArm64/ATranslatorCache.cs | 24 |
1 files changed, 10 insertions, 14 deletions
diff --git a/ChocolArm64/ATranslatorCache.cs b/ChocolArm64/ATranslatorCache.cs index 3e3c5ab6..2d6af90b 100644 --- a/ChocolArm64/ATranslatorCache.cs +++ b/ChocolArm64/ATranslatorCache.cs @@ -1,6 +1,7 @@ using System; using System.Collections.Concurrent; using System.Collections.Generic; +using System.Diagnostics; using System.Runtime.CompilerServices; using System.Threading; @@ -27,7 +28,7 @@ namespace ChocolArm64 public int Size { get; private set; } - public int Timestamp { get; private set; } + public long Timestamp { get; private set; } public CacheBucket(ATranslatedSub Subroutine, LinkedListNode<long> Node, int Size) { @@ -41,7 +42,7 @@ namespace ChocolArm64 { this.Node = Node; - Timestamp = Environment.TickCount; + Timestamp = GetTimestamp(); } } @@ -122,7 +123,7 @@ namespace ChocolArm64 private void ClearCacheIfNeeded() { - int Timestamp = Environment.TickCount; + long Timestamp = GetTimestamp(); while (TotalSize > MaxTotalSize) { @@ -137,9 +138,9 @@ namespace ChocolArm64 CacheBucket Bucket = Cache[Node.Value]; - int TimeDelta = RingDelta(Bucket.Timestamp, Timestamp); + long TimeDelta = Bucket.Timestamp - Timestamp; - if ((uint)TimeDelta <= (uint)MinTimeDelta) + if (TimeDelta <= MinTimeDelta) { break; } @@ -154,16 +155,11 @@ namespace ChocolArm64 } } - private static int RingDelta(int Old, int New) + private static long GetTimestamp() { - if ((uint)New < (uint)Old) - { - return New + (~Old + 1); - } - else - { - return New - Old; - } + long timestamp = Stopwatch.GetTimestamp(); + + return timestamp / (Stopwatch.Frequency / 1000); } } }
\ No newline at end of file |
