From 139301c5a12b769d5a13dec55589ed7fb5dc7bdf Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 29 May 2019 00:23:46 -0400 Subject: profile_select: Return int instead of u32 for GetIndex() Qt uses a signed value to represent indices. We should follow this convention where applicable to avoid unnecessary sign-conversion warnings, as well as making it easier to interoperate with other aspects of Qt. While we're at it, we can also make a sign-conversion explicit. --- src/yuzu/applets/profile_select.cpp | 2 +- src/yuzu/applets/profile_select.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/yuzu/applets') diff --git a/src/yuzu/applets/profile_select.cpp b/src/yuzu/applets/profile_select.cpp index 7fbc9deeb..6696cb532 100644 --- a/src/yuzu/applets/profile_select.cpp +++ b/src/yuzu/applets/profile_select.cpp @@ -136,7 +136,7 @@ bool QtProfileSelectionDialog::GetStatus() const { return ok; } -u32 QtProfileSelectionDialog::GetIndex() const { +int QtProfileSelectionDialog::GetIndex() const { return user_index; } diff --git a/src/yuzu/applets/profile_select.h b/src/yuzu/applets/profile_select.h index 1c2922e54..ff02df93b 100644 --- a/src/yuzu/applets/profile_select.h +++ b/src/yuzu/applets/profile_select.h @@ -30,11 +30,11 @@ public: void reject() override; bool GetStatus() const; - u32 GetIndex() const; + int GetIndex() const; private: bool ok = false; - u32 user_index = 0; + int user_index = 0; void SelectUser(const QModelIndex& index); -- cgit v1.2.3