From 35ebbbc167986552f5fb4784cc53214ddcca505a Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 9 Feb 2019 09:05:47 +0100 Subject: gl_shader_disk_cache: Use Zstandard for compression --- src/video_core/renderer_opengl/gl_shader_disk_cache.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/video_core') diff --git a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp index d2d979997..e74ffd291 100644 --- a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp +++ b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp @@ -10,7 +10,7 @@ #include "common/common_types.h" #include "common/file_util.h" #include "common/logging/log.h" -#include "common/lz4_compression.h" +#include "common/zstd_compression.h" #include "common/scm_rev.h" #include "core/core.h" @@ -259,7 +259,7 @@ ShaderDiskCacheOpenGL::LoadPrecompiledFile(FileUtil::IOFile& file) { return {}; } - dump.binary = Common::Compression::DecompressDataLZ4(compressed_binary, binary_length); + dump.binary = Common::Compression::DecompressDataZSTD(compressed_binary, binary_length); if (dump.binary.empty()) { return {}; } @@ -288,7 +288,7 @@ std::optional ShaderDiskCacheOpenGL::LoadDecompiledEn return {}; } - const std::vector code = Common::Compression::DecompressDataLZ4(compressed_code, code_size); + const std::vector code = Common::Compression::DecompressDataZSTD(compressed_code, code_size); if (code.empty()) { return {}; } @@ -474,8 +474,8 @@ void ShaderDiskCacheOpenGL::SaveDecompiled(u64 unique_identifier, const std::str if (!IsUsable()) return; - const std::vector compressed_code{Common::Compression::CompressDataLZ4HC( - reinterpret_cast(code.data()), code.size(), 9)}; + const std::vector compressed_code{Common::Compression::CompressDataZSTDDefault( + reinterpret_cast(code.data()), code.size())}; if (compressed_code.empty()) { LOG_ERROR(Render_OpenGL, "Failed to compress GLSL code - skipping shader {:016x}", unique_identifier); @@ -506,7 +506,7 @@ void ShaderDiskCacheOpenGL::SaveDump(const ShaderDiskCacheUsage& usage, GLuint p glGetProgramBinary(program, binary_length, nullptr, &binary_format, binary.data()); const std::vector compressed_binary = - Common::Compression::CompressDataLZ4HC(binary.data(), binary.size(), 9); + Common::Compression::CompressDataZSTDDefault(binary.data(), binary.size()); if (compressed_binary.empty()) { LOG_ERROR(Render_OpenGL, "Failed to compress binary program in shader={:016x}", -- cgit v1.2.3 From aa92da205e3f975dffc3c706fb0a176f13649492 Mon Sep 17 00:00:00 2001 From: unknown Date: Sat, 9 Feb 2019 10:20:52 +0100 Subject: gl_shader_disk_cache: Fixup clang format --- src/video_core/renderer_opengl/gl_shader_disk_cache.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/video_core') diff --git a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp index e74ffd291..ec32602ad 100644 --- a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp +++ b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp @@ -10,8 +10,8 @@ #include "common/common_types.h" #include "common/file_util.h" #include "common/logging/log.h" -#include "common/zstd_compression.h" #include "common/scm_rev.h" +#include "common/zstd_compression.h" #include "core/core.h" #include "core/hle/kernel/process.h" @@ -288,7 +288,8 @@ std::optional ShaderDiskCacheOpenGL::LoadDecompiledEn return {}; } - const std::vector code = Common::Compression::DecompressDataZSTD(compressed_code, code_size); + const std::vector code = + Common::Compression::DecompressDataZSTD(compressed_code, code_size); if (code.empty()) { return {}; } -- cgit v1.2.3 From b4857e326fdf4c980c88ca399e7d12f99253777e Mon Sep 17 00:00:00 2001 From: unknown Date: Sun, 10 Feb 2019 10:28:04 +0100 Subject: common/zstd_compression: simplify decompression interface --- src/common/zstd_compression.cpp | 15 ++++++++------- src/common/zstd_compression.h | 4 +--- src/video_core/renderer_opengl/gl_shader_disk_cache.cpp | 5 ++--- 3 files changed, 11 insertions(+), 13 deletions(-) (limited to 'src/video_core') diff --git a/src/common/zstd_compression.cpp b/src/common/zstd_compression.cpp index f6cf7a791..60a35c67c 100644 --- a/src/common/zstd_compression.cpp +++ b/src/common/zstd_compression.cpp @@ -13,7 +13,6 @@ namespace Common::Compression { std::vector CompressDataZSTD(const u8* source, std::size_t source_size, s32 compression_level) { - compression_level = std::clamp(compression_level, 1, ZSTD_maxCLevel()); const std::size_t max_compressed_size = ZSTD_compressBound(source_size); @@ -36,17 +35,19 @@ std::vector CompressDataZSTDDefault(const u8* source, std::size_t source_siz return CompressDataZSTD(source, source_size, ZSTD_CLEVEL_DEFAULT); } -std::vector DecompressDataZSTD(const std::vector& compressed, - std::size_t uncompressed_size) { - std::vector uncompressed(uncompressed_size); +std::vector DecompressDataZSTD(const std::vector& compressed) { + const std::size_t decompressed_size = + ZSTD_getDecompressedSize(compressed.data(), compressed.size()); + std::vector decompressed(decompressed_size); + const std::size_t uncompressed_result_size = ZSTD_decompress( - uncompressed.data(), uncompressed.size(), compressed.data(), compressed.size()); + decompressed.data(), decompressed.size(), compressed.data(), compressed.size()); - if (uncompressed_size != uncompressed_result_size || ZSTD_isError(uncompressed_result_size)) { + if (decompressed_size != uncompressed_result_size || ZSTD_isError(uncompressed_result_size)) { // Decompression failed return {}; } - return uncompressed; + return decompressed; } } // namespace Common::Compression diff --git a/src/common/zstd_compression.h b/src/common/zstd_compression.h index c011ac34b..e0a64b035 100644 --- a/src/common/zstd_compression.h +++ b/src/common/zstd_compression.h @@ -34,11 +34,9 @@ std::vector CompressDataZSTDDefault(const u8* source, std::size_t source_siz * Decompresses a source memory region with Zstandard and returns the uncompressed data in a vector. * * @param compressed the compressed source memory region. - * @param uncompressed_size the size in bytes of the uncompressed data. * * @return the decompressed data. */ -std::vector DecompressDataZSTD(const std::vector& compressed, - std::size_t uncompressed_size); +std::vector DecompressDataZSTD(const std::vector& compressed); } // namespace Common::Compression \ No newline at end of file diff --git a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp index ec32602ad..8a43eb157 100644 --- a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp +++ b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp @@ -259,7 +259,7 @@ ShaderDiskCacheOpenGL::LoadPrecompiledFile(FileUtil::IOFile& file) { return {}; } - dump.binary = Common::Compression::DecompressDataZSTD(compressed_binary, binary_length); + dump.binary = Common::Compression::DecompressDataZSTD(compressed_binary); if (dump.binary.empty()) { return {}; } @@ -288,8 +288,7 @@ std::optional ShaderDiskCacheOpenGL::LoadDecompiledEn return {}; } - const std::vector code = - Common::Compression::DecompressDataZSTD(compressed_code, code_size); + const std::vector code = Common::Compression::DecompressDataZSTD(compressed_code); if (code.empty()) { return {}; } -- cgit v1.2.3