From 2d1f054c61f71656a72eedbd8bda7693e950ab94 Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Fri, 5 Apr 2019 18:31:24 -0300 Subject: gl_rasterizer: Use ARB_multi_bind to update UBOs across stages --- src/video_core/renderer_opengl/utils.cpp | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) (limited to 'src/video_core/renderer_opengl/utils.cpp') diff --git a/src/video_core/renderer_opengl/utils.cpp b/src/video_core/renderer_opengl/utils.cpp index d84634cb3..79bda54c1 100644 --- a/src/video_core/renderer_opengl/utils.cpp +++ b/src/video_core/renderer_opengl/utils.cpp @@ -5,11 +5,36 @@ #include #include #include +#include "common/assert.h" #include "common/common_types.h" #include "video_core/renderer_opengl/utils.h" namespace OpenGL { +BindBuffersRangePushBuffer::BindBuffersRangePushBuffer(GLenum target) : target{target} {} + +BindBuffersRangePushBuffer::~BindBuffersRangePushBuffer() = default; + +void BindBuffersRangePushBuffer::Setup(GLuint first_) { + first = first_; + buffers.clear(); + offsets.clear(); + sizes.clear(); +} + +void BindBuffersRangePushBuffer::Push(GLuint buffer, GLintptr offset, GLsizeiptr size) { + buffers.push_back(buffer); + offsets.push_back(offset); + sizes.push_back(size); +} + +void BindBuffersRangePushBuffer::Bind() const { + const std::size_t count{buffers.size()}; + DEBUG_ASSERT(count == offsets.size() && count == sizes.size()); + glBindBuffersRange(target, first, static_cast(count), buffers.data(), offsets.data(), + sizes.data()); +} + void LabelGLObject(GLenum identifier, GLuint handle, VAddr addr, std::string extra_info) { if (!GLAD_GL_KHR_debug) { return; // We don't need to throw an error as this is just for debugging -- cgit v1.2.3 From 34c3e2c7868620d9c1c76fd810db3cb368fbd22b Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Fri, 5 Apr 2019 19:19:49 -0300 Subject: renderer_opengl/utils: Skip empty binds --- src/video_core/renderer_opengl/utils.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/video_core/renderer_opengl/utils.cpp') diff --git a/src/video_core/renderer_opengl/utils.cpp b/src/video_core/renderer_opengl/utils.cpp index 79bda54c1..84a987371 100644 --- a/src/video_core/renderer_opengl/utils.cpp +++ b/src/video_core/renderer_opengl/utils.cpp @@ -31,6 +31,9 @@ void BindBuffersRangePushBuffer::Push(GLuint buffer, GLintptr offset, GLsizeiptr void BindBuffersRangePushBuffer::Bind() const { const std::size_t count{buffers.size()}; DEBUG_ASSERT(count == offsets.size() && count == sizes.size()); + if (count == 0) { + return; + } glBindBuffersRange(target, first, static_cast(count), buffers.data(), offsets.data(), sizes.data()); } -- cgit v1.2.3