From f8a11a664f579b413d11590408c2272ef332b23b Mon Sep 17 00:00:00 2001 From: Jannik Vogel Date: Sat, 14 May 2016 10:16:06 +0200 Subject: OpenGL: value-initialize variables which cause uninitialised access otherwise --- src/video_core/renderer_opengl/gl_rasterizer.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/video_core/renderer_opengl/gl_rasterizer.h') diff --git a/src/video_core/renderer_opengl/gl_rasterizer.h b/src/video_core/renderer_opengl/gl_rasterizer.h index eed00011a..f1b4fbed8 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.h +++ b/src/video_core/renderer_opengl/gl_rasterizer.h @@ -413,7 +413,7 @@ private: UniformData data; bool lut_dirty[6]; bool dirty; - } uniform_block_data; + } uniform_block_data = {}; std::array texture_samplers; OGLVertexArray vertex_array; @@ -422,5 +422,5 @@ private: OGLFramebuffer framebuffer; std::array lighting_luts; - std::array, 6> lighting_lut_data; + std::array, 6> lighting_lut_data{}; }; -- cgit v1.2.3 From 5389dedfa194460f325c29c9a54b9fde824aae27 Mon Sep 17 00:00:00 2001 From: Jannik Vogel Date: Sat, 14 May 2016 10:16:45 +0200 Subject: OpenGL: Only update depth uniforms if the depth changed --- src/video_core/renderer_opengl/gl_rasterizer.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'src/video_core/renderer_opengl/gl_rasterizer.h') diff --git a/src/video_core/renderer_opengl/gl_rasterizer.h b/src/video_core/renderer_opengl/gl_rasterizer.h index f1b4fbed8..d70369400 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.h +++ b/src/video_core/renderer_opengl/gl_rasterizer.h @@ -339,8 +339,11 @@ private: /// Syncs the cull mode to match the PICA register void SyncCullMode(); - /// Syncs the depth scale and offset to match the PICA registers - void SyncDepthModifiers(); + /// Syncs the depth scale to match the PICA register + void SyncDepthScale(); + + /// Syncs the depth offset to match the PICA register + void SyncDepthOffset(); /// Syncs the blend enabled status to match the PICA register void SyncBlendEnabled(); -- cgit v1.2.3