From bc16f7f3cce7b3a689f45697d9f6fbd970993e32 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 20 Aug 2018 19:22:43 -0400 Subject: renderer_base: Make creation of the rasterizer, the responsibility of the renderers themselves Given we use a base-class type within the renderer for the rasterizer (RasterizerInterface), we want to allow renderers to perform more complex initialization if they need to do such a thing. This makes it important to reserve type information. Given the OpenGL renderer is quite simple settings-wise, this is just a simple shuffling of the initialization code. For something like Vulkan however this might involve doing something like: // Initialize and call rasterizer-specific function that requires // the full type of the instance created. auto raster = std::make_unique(some, params); raster->CallSomeVulkanRasterizerSpecificFunction(); // Assign to base class variable rasterizer = std::move(raster) --- src/video_core/renderer_base.cpp | 8 -------- 1 file changed, 8 deletions(-) (limited to 'src/video_core/renderer_base.cpp') diff --git a/src/video_core/renderer_base.cpp b/src/video_core/renderer_base.cpp index afd86a83a..645d1521a 100644 --- a/src/video_core/renderer_base.cpp +++ b/src/video_core/renderer_base.cpp @@ -2,7 +2,6 @@ // Licensed under GPLv2 or any later version // Refer to the license.txt file included. -#include #include "core/frontend/emu_window.h" #include "core/settings.h" #include "video_core/renderer_base.h" @@ -17,18 +16,11 @@ RendererBase::RendererBase(Core::Frontend::EmuWindow& window) : render_window{wi RendererBase::~RendererBase() = default; void RendererBase::RefreshBaseSettings() { - RefreshRasterizerSetting(); UpdateCurrentFramebufferLayout(); renderer_settings.use_framelimiter = Settings::values.toggle_framelimit; } -void RendererBase::RefreshRasterizerSetting() { - if (rasterizer == nullptr) { - rasterizer = std::make_unique(render_window); - } -} - void RendererBase::UpdateCurrentFramebufferLayout() { const Layout::FramebufferLayout& layout = render_window.GetFramebufferLayout(); -- cgit v1.2.3