From 0f83c8dffaf8c6c5ff0a398276187b78333524bb Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 14 May 2019 13:38:01 -0400 Subject: video_core/engines/engine_upload: Remove unnecessary includes --- src/video_core/engines/engine_upload.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/video_core/engines/engine_upload.cpp') diff --git a/src/video_core/engines/engine_upload.cpp b/src/video_core/engines/engine_upload.cpp index f8aa4ff55..42faf0a40 100644 --- a/src/video_core/engines/engine_upload.cpp +++ b/src/video_core/engines/engine_upload.cpp @@ -2,6 +2,8 @@ // Licensed under GPLv2 or any later version // Refer to the license.txt file included. +#include + #include "common/assert.h" #include "video_core/engines/engine_upload.h" #include "video_core/memory_manager.h" -- cgit v1.2.3 From 9b6d993e520db29697263ef86b0498f98d15a8f2 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 14 May 2019 13:41:34 -0400 Subject: video_core/engines/engine_upload: Default destructor in the cpp file Avoids inlining destruction logic where applicable, and also makes forward declarations not cause unexpected compilation errors depending on where the State class is used. --- src/video_core/engines/engine_upload.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/video_core/engines/engine_upload.cpp') diff --git a/src/video_core/engines/engine_upload.cpp b/src/video_core/engines/engine_upload.cpp index 42faf0a40..1aaec1964 100644 --- a/src/video_core/engines/engine_upload.cpp +++ b/src/video_core/engines/engine_upload.cpp @@ -14,6 +14,8 @@ namespace Tegra::Engines::Upload { State::State(MemoryManager& memory_manager, Registers& regs) : memory_manager(memory_manager), regs(regs) {} +State::~State() = default; + void State::ProcessExec(const bool is_linear) { write_offset = 0; copy_size = regs.line_length_in * regs.line_count; -- cgit v1.2.3 From b01cce716e406bf8eb4d322344366e68a7250d6a Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 14 May 2019 13:43:23 -0400 Subject: video_core/engines/engine_upload: Amend constructor initializer list order Silences a -Wreorder warning. --- src/video_core/engines/engine_upload.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/video_core/engines/engine_upload.cpp') diff --git a/src/video_core/engines/engine_upload.cpp b/src/video_core/engines/engine_upload.cpp index 1aaec1964..082a40cd9 100644 --- a/src/video_core/engines/engine_upload.cpp +++ b/src/video_core/engines/engine_upload.cpp @@ -12,7 +12,7 @@ namespace Tegra::Engines::Upload { State::State(MemoryManager& memory_manager, Registers& regs) - : memory_manager(memory_manager), regs(regs) {} + : regs{regs}, memory_manager{memory_manager} {} State::~State() = default; -- cgit v1.2.3